From: David Teigland <teigland@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org,
"Wim Van Sebroeck" <wim@iguana.be>,
linux-kernel@vger.kernel.org,
"Timo Kokkonen" <timo.kokkonen@offcode.fi>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-doc@vger.kernel.org, "Jonathan Corbet" <corbet@lwn.net>
Subject: Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure
Date: Wed, 5 Aug 2015 12:13:49 -0500 [thread overview]
Message-ID: <20150805171349.GA15472@redhat.com> (raw)
In-Reply-To: <1438654414-29259-1-git-send-email-linux@roeck-us.net>
On Mon, Aug 03, 2015 at 07:13:26PM -0700, Guenter Roeck wrote:
> - Some watchdogs have a very short maximum timeout, in the range of just a few
> seconds. Such low timeouts are difficult if not impossible to support from
> user space. Drivers supporting such watchdog hardware need to implement
> a timer function to augment heartbeats from user space.
> - A new status flag, WDOG_RUNNING, informs the watchdog subsystem that a
> watchdog is running, and that the watchdog subsystem needs to generate
> heartbeat requests while the associated watchdog device is closed.
> Patch #2 adds timer functionality to the watchdog core. It solves the problem
> of short maximum hardware timeouts by augmenting heartbeats triggered from
> user space with internally triggered heartbeats.
>
> Patch #3 adds functionality to generate heartbeats while the watchdog device is
> closed. It handles situation where where the watchdog is running after
> the driver has been instantiated, but the device is not yet opened,
> and post-close situations necessary if a watchdog can not be stopped.
These sound concerning because it seems that heartbeats could be generated
outside of the direct control of userspace. I have a program that depends
on having direct control over whether heartbeats are generated (or more
specifically, *not* generated.) If these new features introduce a new way
for heartbeats to be generated, is there a way I can detect or disable
that behavior from userspace? Unwanted heartbeats could break my program
and may lead to data corruption.
A related issue from some years ago is the unfortunate fact that closing
the watchdog device also generates a heartbeat. I'd like to disable that
also, and submitted a patch for it here:
http://www.spinics.net/lists/linux-watchdog/msg01477.html
(Without the patch, I have to work around it by closing the device
prematurely as a way to generate the potentially final heartbeat, and then
reopen it again if I want to continue the heartbeats.)
Dave
next prev parent reply other threads:[~2015-08-05 17:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 2:13 [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure Guenter Roeck
2015-08-04 2:13 ` [PATCH 1/8] watchdog: watchdog_dev: Use single variable name for struct watchdog_device Guenter Roeck
2015-08-04 11:26 ` Uwe Kleine-König
2015-08-04 2:13 ` [PATCH 2/8] watchdog: Introduce hardware maximum timeout in watchdog core Guenter Roeck
2015-08-04 12:18 ` Uwe Kleine-König
2015-08-04 15:31 ` Guenter Roeck
2015-08-04 15:52 ` Uwe Kleine-König
2015-08-04 16:03 ` Guenter Roeck
2015-08-05 8:22 ` Uwe Kleine-König
2015-08-05 9:14 ` Guenter Roeck
2015-08-04 2:13 ` [PATCH 3/8] watchdog: Introduce WDOG_RUNNING flag Guenter Roeck
2015-08-04 12:25 ` Uwe Kleine-König
2015-08-04 15:41 ` Uwe Kleine-König
2015-08-04 15:56 ` Guenter Roeck
2015-08-04 2:13 ` [PATCH 4/8] watchdog: Make set_timeout function optional Guenter Roeck
2015-08-04 15:38 ` Uwe Kleine-König
2015-08-04 16:43 ` Guenter Roeck
2015-08-04 2:13 ` [PATCH 5/8] watchdog: imx2: Convert to use infrastructure triggered keepalives Guenter Roeck
2015-08-04 15:44 ` Uwe Kleine-König
2015-08-04 2:13 ` [PATCH 6/8] watchdog: retu: " Guenter Roeck
2015-08-04 2:13 ` [PATCH 7/8] watchdog: gpio_wdt: " Guenter Roeck
2015-08-04 2:13 ` [PATCH 8/8] watchdog: at91sam9: " Guenter Roeck
2015-08-04 11:24 ` [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure Uwe Kleine-König
2015-08-04 15:01 ` Guenter Roeck
2015-08-04 23:43 ` Pádraig Brady
2015-08-05 0:49 ` Guenter Roeck
2015-08-05 7:36 ` Uwe Kleine-König
2015-08-05 7:50 ` Guenter Roeck
2015-08-05 8:27 ` Uwe Kleine-König
2015-08-05 17:13 ` David Teigland [this message]
2015-08-05 17:41 ` Guenter Roeck
2015-08-05 17:51 ` David Teigland
2015-08-05 19:01 ` Guenter Roeck
2015-08-05 19:51 ` David Teigland
2015-08-05 20:21 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805171349.GA15472@redhat.com \
--to=teigland@redhat.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=timo.kokkonen@offcode.fi \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox