From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [RFC 6/6] wifi: mac80211: check vif radio_mask for monitor mode rx
Date: Fri, 23 Aug 2024 12:23:08 +0200 [thread overview]
Message-ID: <01d7528bc15ee682fbe2f200bdbf39066b39309a.camel@sipsolutions.net> (raw)
In-Reply-To: <7d713206957ec56dc297d5645203b45341578588.1722885720.git-series.nbd@nbd.name>
On Mon, 2024-08-05 at 21:23 +0200, Felix Fietkau wrote:
> When restricting a monitor vif to only operate on a specific set of radios,
> filter out rx packets belonging to other radios. This only works if drivers
> fill in radio_valid and radio_idx in the rx status.
Why does the driver need to provide the radio, it already provides the
frequency?
But then I wonder if this doesn't go a step too far? This is pretty much
pretending that monitor only exists on a specific sub-radio, but ...
what for? Even userspace could filter on the frequency.
I mean ... I get that you're trying to preserve a notion that you had
that an interface exists on a given PHY and they're all separate, but
they're not really separate any more, get used to it?
johannes
next prev parent reply other threads:[~2024-08-23 10:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 19:23 [RFC 0/6] wifi: cfg80211/mac80211: improve support for multiple radios Felix Fietkau
2024-08-05 19:23 ` [RFC 1/6] wifi: cfg80211/mac80211: add option for vif allowed radios Felix Fietkau
2024-08-05 19:23 ` [RFC 2/6] wifi: mac80211: remove status->ampdu_delimiter_crc Felix Fietkau
2024-08-05 19:23 ` [RFC 3/6] wifi: mac80211: notify driver about per-radio monitor enabled state Felix Fietkau
2024-08-23 10:16 ` Johannes Berg
2024-08-23 11:26 ` Felix Fietkau
2024-09-17 8:13 ` Johannes Berg
2024-09-17 15:26 ` Ben Greear
2024-08-05 19:23 ` [RFC 4/6] wifi: mac80211: support per-radio driver start/stop calls Felix Fietkau
2024-08-23 10:17 ` Johannes Berg
2024-08-23 11:31 ` Felix Fietkau
2024-09-17 8:59 ` Johannes Berg
2024-08-05 19:23 ` [RFC 5/6] wifi: mac80211: support per-radio filter flags Felix Fietkau
2024-08-23 10:20 ` Johannes Berg
2024-08-23 16:26 ` Felix Fietkau
2024-09-17 9:01 ` Johannes Berg
2024-08-05 19:23 ` [RFC 6/6] wifi: mac80211: check vif radio_mask for monitor mode rx Felix Fietkau
2024-08-23 10:23 ` Johannes Berg [this message]
2024-08-23 17:33 ` Felix Fietkau
2024-09-17 9:03 ` Johannes Berg
2024-08-23 10:14 ` [RFC 0/6] wifi: cfg80211/mac80211: improve support for multiple radios Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01d7528bc15ee682fbe2f200bdbf39066b39309a.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox