From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [RFC 5/6] wifi: mac80211: support per-radio filter flags
Date: Tue, 17 Sep 2024 11:01:27 +0200 [thread overview]
Message-ID: <29b0fe777228cedfa219fc8268b6a7fc8c04164f.camel@sipsolutions.net> (raw)
In-Reply-To: <4193632b-7eca-4dcb-b40a-982b3bf7705d@nbd.name>
On Fri, 2024-08-23 at 18:26 +0200, Felix Fietkau wrote:
> On 23.08.24 12:20, Johannes Berg wrote:
> > On Mon, 2024-08-05 at 21:23 +0200, Felix Fietkau wrote:
> > > This allows drivers to improve filtering of unwanted packets when using
> > > different combinations of filter/monitor settings on radios.
> > >
> >
> > Here, it would seem to make more sense to simply give the necessary per-
> > interface information to the driver? Drivers likely have more
> > restrictions and will need less complex data structures (or just
> > iteration) to figure out what's eventually needed for each hw etc.
> >
> > Some drivers might anyway even have different filters per interface,
> > even if they're operating on the same channel.
>
> I can do that as well. However, I do think it makes sense to have
> per-radio tracking in mac80211 as well, because I'm pretty sure that not
> just mt76, but ath12k would also be able to make use of this.
But if you have per-link, deriving per-radio is effectively trivial, so
I don't see why we should do the extra work to track it?
johannes
next prev parent reply other threads:[~2024-09-17 9:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 19:23 [RFC 0/6] wifi: cfg80211/mac80211: improve support for multiple radios Felix Fietkau
2024-08-05 19:23 ` [RFC 1/6] wifi: cfg80211/mac80211: add option for vif allowed radios Felix Fietkau
2024-08-05 19:23 ` [RFC 2/6] wifi: mac80211: remove status->ampdu_delimiter_crc Felix Fietkau
2024-08-05 19:23 ` [RFC 3/6] wifi: mac80211: notify driver about per-radio monitor enabled state Felix Fietkau
2024-08-23 10:16 ` Johannes Berg
2024-08-23 11:26 ` Felix Fietkau
2024-09-17 8:13 ` Johannes Berg
2024-09-17 15:26 ` Ben Greear
2024-08-05 19:23 ` [RFC 4/6] wifi: mac80211: support per-radio driver start/stop calls Felix Fietkau
2024-08-23 10:17 ` Johannes Berg
2024-08-23 11:31 ` Felix Fietkau
2024-09-17 8:59 ` Johannes Berg
2024-08-05 19:23 ` [RFC 5/6] wifi: mac80211: support per-radio filter flags Felix Fietkau
2024-08-23 10:20 ` Johannes Berg
2024-08-23 16:26 ` Felix Fietkau
2024-09-17 9:01 ` Johannes Berg [this message]
2024-08-05 19:23 ` [RFC 6/6] wifi: mac80211: check vif radio_mask for monitor mode rx Felix Fietkau
2024-08-23 10:23 ` Johannes Berg
2024-08-23 17:33 ` Felix Fietkau
2024-09-17 9:03 ` Johannes Berg
2024-08-23 10:14 ` [RFC 0/6] wifi: cfg80211/mac80211: improve support for multiple radios Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29b0fe777228cedfa219fc8268b6a7fc8c04164f.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox