From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 4/6] wifi: mac80211: support per-radio driver start/stop calls
Date: Tue, 17 Sep 2024 10:59:48 +0200 [thread overview]
Message-ID: <b628adea24aa4b3ab70092a9f6cc7d5e7f4b981a.camel@sipsolutions.net> (raw)
In-Reply-To: <6964618A-06A2-4E83-8AA7-B71FDAA282A0@nbd.name>
On Fri, 2024-08-23 at 13:31 +0200, Felix Fietkau wrote:
>
> > On 23. Aug 2024, at 12:17, Johannes Berg <johannes@sipsolutions.net> wrote:
> >
> > On Mon, 2024-08-05 at 21:23 +0200, Felix Fietkau wrote:
> > > Radios are started/stopped based on the vif allowed radios. This allows
> > > drivers to keep unused radios inactive.
> >
> > Similar argument here, I'd think you don't need this with
> > WANT_MONITOR_VIF. Is this really something we want? Why?
>
> I want to keep radios shut down when no scan, roc or normal operation can happen on them (based on allowed radios mask).
Makes sense I guess, but do you really need mac80211 helping with that?
You already know which vifs are enabled and which aren't, and you can
also access their radio mask if you want to. Not sure I see the added
value of mac80211 keeping track of it. Worst case iterate the existing
vifs when removing one?
This is only needed/useful when there are multiple "real" devices and
you don't have anything else managing them, so I kind of see this as a
corner case, but perhaps I'm wrong?
johannes
next prev parent reply other threads:[~2024-09-17 8:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 19:23 [RFC 0/6] wifi: cfg80211/mac80211: improve support for multiple radios Felix Fietkau
2024-08-05 19:23 ` [RFC 1/6] wifi: cfg80211/mac80211: add option for vif allowed radios Felix Fietkau
2024-08-05 19:23 ` [RFC 2/6] wifi: mac80211: remove status->ampdu_delimiter_crc Felix Fietkau
2024-08-05 19:23 ` [RFC 3/6] wifi: mac80211: notify driver about per-radio monitor enabled state Felix Fietkau
2024-08-23 10:16 ` Johannes Berg
2024-08-23 11:26 ` Felix Fietkau
2024-09-17 8:13 ` Johannes Berg
2024-09-17 15:26 ` Ben Greear
2024-08-05 19:23 ` [RFC 4/6] wifi: mac80211: support per-radio driver start/stop calls Felix Fietkau
2024-08-23 10:17 ` Johannes Berg
2024-08-23 11:31 ` Felix Fietkau
2024-09-17 8:59 ` Johannes Berg [this message]
2024-08-05 19:23 ` [RFC 5/6] wifi: mac80211: support per-radio filter flags Felix Fietkau
2024-08-23 10:20 ` Johannes Berg
2024-08-23 16:26 ` Felix Fietkau
2024-09-17 9:01 ` Johannes Berg
2024-08-05 19:23 ` [RFC 6/6] wifi: mac80211: check vif radio_mask for monitor mode rx Felix Fietkau
2024-08-23 10:23 ` Johannes Berg
2024-08-23 17:33 ` Felix Fietkau
2024-09-17 9:03 ` Johannes Berg
2024-08-23 10:14 ` [RFC 0/6] wifi: cfg80211/mac80211: improve support for multiple radios Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b628adea24aa4b3ab70092a9f6cc7d5e7f4b981a.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox