From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [RFC 0/6] wifi: cfg80211/mac80211: improve support for multiple radios
Date: Fri, 23 Aug 2024 12:14:21 +0200 [thread overview]
Message-ID: <d222feeb1f584428760236f7dfef5b506874b2b2.camel@sipsolutions.net> (raw)
In-Reply-To: <cover.c32cfe64c671566c111b1b7ea426dbd1e8f2c568.1722885720.git-series.nbd@nbd.name>
On Mon, 2024-08-05 at 21:23 +0200, Felix Fietkau wrote:
> This series adds support for restricting vifs to a set of radios.
> The allowed radios mask is used to restrict scanning, off-channel activity.
> This is also used for per-radio start/stop ops, monitor state and filter
> flags. It can also limit per-monitor-vif rx to specific radios.
>
I see the idea, I guess, but but honestly I don't like the way this is
all mixed up between cfg80211 and mac80211.
I think more of this should be in cfg80211 (e.g. not sure why the
changes to ieee80211_change_iface, nothing there that cfg80211 couldn't
do; and generally would prefer to have the patch split), but since it
can never be perfect there (internal scans like in mac80211, etc.), I
guess it really also should come with a feature flag. That'd also make
the series more robust, with enabling the feature only in the last
commit.
johannes
prev parent reply other threads:[~2024-08-23 10:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 19:23 [RFC 0/6] wifi: cfg80211/mac80211: improve support for multiple radios Felix Fietkau
2024-08-05 19:23 ` [RFC 1/6] wifi: cfg80211/mac80211: add option for vif allowed radios Felix Fietkau
2024-08-05 19:23 ` [RFC 2/6] wifi: mac80211: remove status->ampdu_delimiter_crc Felix Fietkau
2024-08-05 19:23 ` [RFC 3/6] wifi: mac80211: notify driver about per-radio monitor enabled state Felix Fietkau
2024-08-23 10:16 ` Johannes Berg
2024-08-23 11:26 ` Felix Fietkau
2024-09-17 8:13 ` Johannes Berg
2024-09-17 15:26 ` Ben Greear
2024-08-05 19:23 ` [RFC 4/6] wifi: mac80211: support per-radio driver start/stop calls Felix Fietkau
2024-08-23 10:17 ` Johannes Berg
2024-08-23 11:31 ` Felix Fietkau
2024-09-17 8:59 ` Johannes Berg
2024-08-05 19:23 ` [RFC 5/6] wifi: mac80211: support per-radio filter flags Felix Fietkau
2024-08-23 10:20 ` Johannes Berg
2024-08-23 16:26 ` Felix Fietkau
2024-09-17 9:01 ` Johannes Berg
2024-08-05 19:23 ` [RFC 6/6] wifi: mac80211: check vif radio_mask for monitor mode rx Felix Fietkau
2024-08-23 10:23 ` Johannes Berg
2024-08-23 17:33 ` Felix Fietkau
2024-09-17 9:03 ` Johannes Berg
2024-08-23 10:14 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d222feeb1f584428760236f7dfef5b506874b2b2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox