Re: [PATCH] mac80211: notify upper layers after lower

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1482 bytes --]


On Thu, 2008-04-03 at 16:08 -0700, Reinette Chatre wrote:
> When drivers receive change notification they may do work that
> will enable the changes to take effect. For example, if new association
> the device needs to be programmed with this information.
> Give the driver chance to make the changes before notifying the
> upper layer - thus preventing race condition where upper layer
> attempts to utilize state that may not be configured yet.
> 
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>

Looks good to me

Acked-by: Johannes Berg <johannes@sipsolutions.net>

> ---
>  net/mac80211/ieee80211_sta.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/mac80211/ieee80211_sta.c b/net/mac80211/ieee80211_sta.c
> index be2ce24..f3c8a21 100644
> --- a/net/mac80211/ieee80211_sta.c
> +++ b/net/mac80211/ieee80211_sta.c
> @@ -545,13 +545,13 @@ static void ieee80211_set_associated(struct net_device *dev,
>  
>  		memset(wrqu.ap_addr.sa_data, 0, ETH_ALEN);
>  	}
> -	wrqu.ap_addr.sa_family = ARPHRD_ETHER;
> -	wireless_send_event(dev, SIOCGIWAP, &wrqu, NULL);
>  	ifsta->last_probe = jiffies;
>  	ieee80211_led_assoc(local, assoc);
>  
>  	sdata->bss_conf.assoc = assoc;
>  	ieee80211_bss_info_change_notify(sdata, changed);
> +	wrqu.ap_addr.sa_family = ARPHRD_ETHER;
> +	wireless_send_event(dev, SIOCGIWAP, &wrqu, NULL);
>  }
>  
>  static void ieee80211_set_disassoc(struct net_device *dev,

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]