From: Johannes Berg <johannes@sipsolutions.net>
To: mohamed salim abbas <mabbaswireless@gmail.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net,
Mohamed Abbas <mabbas@linux.intel.com>
Subject: Re: [PATCH] mac80211: notify mac from low level driver (iwlwifi)
Date: Sat, 05 Apr 2008 01:47:25 +0200 [thread overview]
Message-ID: <1207352845.6675.5.camel@johannes.berg> (raw)
In-Reply-To: <b3153e950804041634k2c3fd960h3e118deb7c42f0e7@mail.gmail.com> (sfid-20080405_003409_229099_3DAFE7D7)
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
> for iwl the driver on suspend behave like the device is going down, on
> resume the driver reload the firmware and start fresh. the driver does
> save some data to restore on resume.
Right, I think most drivers/hw behave that way.
> I guess we can enhance on this to handle more scenario, but atleast
> this is good enough for iwl driver.
What happens, for example, when you enable hardware crypto and set a WEP
key? With b43, after suspend/resume, mac80211 and the driver think the
key is set in hardware, but it was obviously cleared. It would of course
be possible to handle that in the driver, but I'd prefer it to be done
in mac80211 because then the driver doesn't need all the extra code.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2008-04-04 23:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 23:08 [PATCH] mac80211: notify upper layers after lower Reinette Chatre
2008-04-03 23:08 ` [PATCH] mac80211: notify mac from low level driver (iwlwifi) Reinette Chatre
2008-04-04 14:46 ` Johannes Berg
2008-04-04 21:35 ` mohamed salim abbas
2008-04-04 21:39 ` Johannes Berg
2008-04-04 23:34 ` mohamed salim abbas
2008-04-04 23:47 ` Johannes Berg [this message]
2008-04-04 23:55 ` mohamed salim abbas
2008-04-04 14:44 ` [PATCH] mac80211: notify upper layers after lower Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207352845.6675.5.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mabbas@linux.intel.com \
--cc=mabbaswireless@gmail.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox