Re: [PATCH] mac80211: notify mac from low level driver (iwlwifi)

["mohamed salim abbas" <mabbaswireless@gmail.com>]

On 4/4/08, Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Fri, 2008-04-04 at 14:35 -0700, mohamed salim abbas wrote:
> > On 4/4/08, Johannes Berg <johannes@sipsolutions.net> wrote:
> > >
> > > > + * This function must be called by low level driver to inform mac80211 of
> > > > + * low level driver status change or force mac80211 to re-assoc for low
> > > > + * level driver internal error that require re-assoc. A good example to use
> > > > + * this notification to call mac80211 after suspend/resume, some NIC require
> > > > + * re-assoc.
> > >
> > > I think the suspend/resume text should be dropped since IMHO that
> > > requires more work, reprogramming all the hardware crypto keys for
> > > example.
>
> > I can remove the suspend/resume text will be that good enough?
>
> Sure. I hope at some point somebody will implement proper suspend/resume
> (i.e. when the suspend callback is invoked all interfaces, stations,
> keys etc. are removed from the driver) but that's a lot more work. That
> you mention suspend/resume though makes me wonder: does iwlwifi store
> all that information locally and restore it to the hardware so that it
> can actually work with this across suspend/resume? For b43, I at least
> need to reset all WEP keys.

for iwl the driver on suspend behave like the device is going down, on
resume the driver reload the firmware and start fresh. the driver does
save some data to restore on resume.
I guess we can enhance on this to handle more scenario, but atleast
this is good enough for iwl driver.

>
> Thanks,
> johannes
>
>