From: Johannes Berg <johannes@sipsolutions.net>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net,
Mohamed Abbas <mabbas@linux.intel.com>
Subject: Re: [PATCH] mac80211: notify mac from low level driver (iwlwifi)
Date: Fri, 04 Apr 2008 16:46:29 +0200 [thread overview]
Message-ID: <1207320389.19189.30.camel@johannes.berg> (raw)
In-Reply-To: <1207264130-25437-2-git-send-email-reinette.chatre@intel.com>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
> + * This function must be called by low level driver to inform mac80211 of
> + * low level driver status change or force mac80211 to re-assoc for low
> + * level driver internal error that require re-assoc. A good example to use
> + * this notification to call mac80211 after suspend/resume, some NIC require
> + * re-assoc.
I think the suspend/resume text should be dropped since IMHO that
requires more work, reprogramming all the hardware crypto keys for
example.
> + /* No need to wake the master device. */
> + if (sdata->dev == local->mdev)
> + continue;
That looks like a copy&paste bug, we're not waking it in any way. Also,
it's of IF_TYPE_AP so it's not necessary to test this at all.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2008-04-04 14:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 23:08 [PATCH] mac80211: notify upper layers after lower Reinette Chatre
2008-04-03 23:08 ` [PATCH] mac80211: notify mac from low level driver (iwlwifi) Reinette Chatre
2008-04-04 14:46 ` Johannes Berg [this message]
2008-04-04 21:35 ` mohamed salim abbas
2008-04-04 21:39 ` Johannes Berg
2008-04-04 23:34 ` mohamed salim abbas
2008-04-04 23:47 ` Johannes Berg
2008-04-04 23:55 ` mohamed salim abbas
2008-04-04 14:44 ` [PATCH] mac80211: notify upper layers after lower Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207320389.19189.30.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mabbas@linux.intel.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox