From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: iwlwifi aggregation info
Date: Tue, 29 Jul 2008 15:35:11 +0300 [thread overview]
Message-ID: <1ba2fa240807290535h3ebd4121h399b8a8cd1d8b276@mail.gmail.com> (raw)
In-Reply-To: <1217334452.10489.42.camel@johannes.berg>
On Tue, Jul 29, 2008 at 3:27 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Tue, 2008-07-29 at 15:25 +0300, Tomas Winkler wrote:
>
>> > Never mind, the queue won't get reassigned. I was just confused by a
>> > bunch of superfluous code in iwl-tx.c. You cannot ever run into having
>> > IWL_EMPTYING_HW_QUEUE_ADDBA set because you wait for the queue to drain
>> > before fully disabling it.
>>
>> Correct.
>
> I suppose you won't mind me removing that particular code then? I'm
> working on the agg refactoring right now.
Sorry for misleading I'm not in focus today :). You cannot remove this
code. This is form
This is required for emptying packets from legacy queue before
starting aggregation queue.
You cannot transmit from both queues for the same tid Aggregation is
sensitive on ordering.
Tomas
next prev parent reply other threads:[~2008-07-29 12:35 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 11:32 iwlwifi aggregation info Johannes Berg
2008-07-29 11:36 ` Johannes Berg
2008-07-29 12:25 ` Tomas Winkler
2008-07-29 12:27 ` Johannes Berg
2008-07-29 12:35 ` Tomas Winkler [this message]
2008-07-29 12:53 ` Johannes Berg
2008-07-29 13:04 ` Tomas Winkler
2008-07-29 13:07 ` Johannes Berg
2008-07-29 13:18 ` Tomas Winkler
2008-07-29 13:23 ` Johannes Berg
2008-07-29 13:43 ` Tomas Winkler
2008-07-29 13:46 ` Johannes Berg
2008-07-29 14:06 ` Tomas Winkler
2008-07-29 14:21 ` Johannes Berg
2008-07-29 15:55 ` Tomas Winkler
2008-07-30 9:53 ` Johannes Berg
2008-07-30 11:03 ` Friedrich.Beckmann
2008-07-30 13:19 ` Johannes Berg
2008-07-30 13:45 ` Tomas Winkler
2008-07-30 13:50 ` Johannes Berg
2008-07-30 13:59 ` Tomas Winkler
2008-07-30 15:19 ` Johannes Berg
2008-07-30 16:08 ` Tomas Winkler
2008-07-31 13:05 ` Johannes Berg
2008-07-31 18:14 ` Tomas Winkler
2008-07-31 18:23 ` Johannes Berg
2008-07-31 19:16 ` Tomas Winkler
2008-08-01 12:09 ` Johannes Berg
2008-08-01 12:40 ` Tomas Winkler
2008-08-01 12:54 ` Johannes Berg
2008-08-06 21:45 ` Johannes Berg
2008-08-06 22:05 ` Tomas Winkler
2008-08-06 22:31 ` Tomas Winkler
2008-08-07 11:13 ` mac80211 aggregation (was: iwlwifi aggregation info) Johannes Berg
2008-08-07 12:21 ` Friedrich.Beckmann
2008-08-07 12:31 ` Johannes Berg
2008-08-07 13:00 ` Friedrich.Beckmann
2008-07-30 12:01 ` iwlwifi aggregation info Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240807290535h3ebd4121h399b8a8cd1d8b276@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox