From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: iwlwifi aggregation info
Date: Tue, 29 Jul 2008 16:43:14 +0300 [thread overview]
Message-ID: <1ba2fa240807290643l4192ca62ia4db9966501caf0b@mail.gmail.com> (raw)
In-Reply-To: <1217337819.10489.57.camel@johannes.berg>
On Tue, Jul 29, 2008 at 4:23 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Tue, 2008-07-29 at 16:18 +0300, Tomas Winkler wrote:
>
>> This will require another queueing under what we already have. You
>> still need ability to stop and start the packet stream.
>> At that time it seems to be stupid not to reuse queueing.
>
> That's where you're actually wrong. If the aggregation queue is full,
> since they both go to the same FIFO, we should actually stop the queue
> that corresponds to the AC the aggregation goes into, otherwise we
> favour stations that enable aggregation over those who don't and they
> unfairly get more downstream throughput (if we are the AP).
No the mistake is on your side. FIFO is not relevant here. What is
important is whether HW queue is full or not.
Except the AC Back off scheduling done by FIFO there is BA protocol
which my stall HW queue. It doesn't mean that other packets with the
same FIFO should be stalled. You need additional SW queue that can be
stopped.
Tomas
next prev parent reply other threads:[~2008-07-29 13:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 11:32 iwlwifi aggregation info Johannes Berg
2008-07-29 11:36 ` Johannes Berg
2008-07-29 12:25 ` Tomas Winkler
2008-07-29 12:27 ` Johannes Berg
2008-07-29 12:35 ` Tomas Winkler
2008-07-29 12:53 ` Johannes Berg
2008-07-29 13:04 ` Tomas Winkler
2008-07-29 13:07 ` Johannes Berg
2008-07-29 13:18 ` Tomas Winkler
2008-07-29 13:23 ` Johannes Berg
2008-07-29 13:43 ` Tomas Winkler [this message]
2008-07-29 13:46 ` Johannes Berg
2008-07-29 14:06 ` Tomas Winkler
2008-07-29 14:21 ` Johannes Berg
2008-07-29 15:55 ` Tomas Winkler
2008-07-30 9:53 ` Johannes Berg
2008-07-30 11:03 ` Friedrich.Beckmann
2008-07-30 13:19 ` Johannes Berg
2008-07-30 13:45 ` Tomas Winkler
2008-07-30 13:50 ` Johannes Berg
2008-07-30 13:59 ` Tomas Winkler
2008-07-30 15:19 ` Johannes Berg
2008-07-30 16:08 ` Tomas Winkler
2008-07-31 13:05 ` Johannes Berg
2008-07-31 18:14 ` Tomas Winkler
2008-07-31 18:23 ` Johannes Berg
2008-07-31 19:16 ` Tomas Winkler
2008-08-01 12:09 ` Johannes Berg
2008-08-01 12:40 ` Tomas Winkler
2008-08-01 12:54 ` Johannes Berg
2008-08-06 21:45 ` Johannes Berg
2008-08-06 22:05 ` Tomas Winkler
2008-08-06 22:31 ` Tomas Winkler
2008-08-07 11:13 ` mac80211 aggregation (was: iwlwifi aggregation info) Johannes Berg
2008-08-07 12:21 ` Friedrich.Beckmann
2008-08-07 12:31 ` Johannes Berg
2008-08-07 13:00 ` Friedrich.Beckmann
2008-07-30 12:01 ` iwlwifi aggregation info Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240807290643l4192ca62ia4db9966501caf0b@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox