Re: [PATCH] rfkill-input: remove unused code

[Henrique de Moraes Holschuh <hmh@hmh.eng.br>]

On Fri, 27 Mar 2009, Johannes Berg wrote:
> There's a lot of rfkill-input code that cannot ever be
> compiled and is useless until somebody needs and tests
> it -- therefore remove it.

Just so that you guys know, that code *is* tested :-)

I'd suggest that the code removal be done leaving a comment in place, like this:

/* Currently, code to implement EV_SW SW_WLAN/WWAN/BLUETOOTH/etc is not
 * in place since it was unused and was therefore removed.  Please look
 * at past history to check how it was supposed to be done, if you need
 * to implement handling for EV_SW.
 */

Because that codepath is _not_ the most obvious thing in the world to
reimplement without hitting a pitfall, so people better look how it was done
once in time...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh