From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] rfkill-input: remove unused code
Date: Fri, 27 Mar 2009 21:55:01 -0300 [thread overview]
Message-ID: <20090328005501.GB7439@khazad-dum.debian.net> (raw)
In-Reply-To: <1238166712.4452.11.camel@johannes.local>
On Fri, 27 Mar 2009, Johannes Berg wrote:
> > Because that codepath is _not_ the most obvious thing in the world to
> > reimplement without hitting a pitfall, so people better look how it was done
> > once in time...
>
> Works for me. Do we expect it to be needed though?
Well, that depends. Did anyone produce a device with a
switch/push-button labelled "bluetooth", "wimax", "uwb" (instead of
just using a normal key)? Because if anyone does, we need EV_SW
SW_<whatever>, and that code to handle it in rfkill-input.
I *certainly* don't know of any such device, or I'd have asked for the
EV_SW SW_foo codepoints already, and uncommented that code :-) People
like the "kill all radios" push-button/switch, but one for a specific
type of transmitter I haven't seen yet.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2009-03-28 0:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 13:16 [PATCH] rfkill-input: remove unused code Johannes Berg
2009-03-27 14:36 ` Henrique de Moraes Holschuh
2009-03-27 14:59 ` Michael Buesch
2009-03-27 15:13 ` Henrique de Moraes Holschuh
2009-03-27 15:11 ` Johannes Berg
2009-03-28 0:55 ` Henrique de Moraes Holschuh [this message]
2009-03-27 21:10 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090328005501.GB7439@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox