From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Michael Buesch <mb@bu3sch.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
John Linville <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] rfkill-input: remove unused code
Date: Fri, 27 Mar 2009 12:13:37 -0300 [thread overview]
Message-ID: <20090327151337.GD24288@khazad-dum.debian.net> (raw)
In-Reply-To: <200903271559.02276.mb@bu3sch.de>
On Fri, 27 Mar 2009, Michael Buesch wrote:
> So in my opinion it's _not_ a good idea to lookup some old code for implementing
> a feature. Instead one should think about it and understand the stuff and then implement it.
> And if there are pitfalls that are not obvious after one completely read the code, one
> should consider a redesign.
Or better comments in the code, because right now there are no comments
since the code was quite easy to read and understand, and it was
feature-complete (even if part of it was commented out due to lack of
users).
Well, I certainly don't fell too strongly about it.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2009-03-27 15:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 13:16 [PATCH] rfkill-input: remove unused code Johannes Berg
2009-03-27 14:36 ` Henrique de Moraes Holschuh
2009-03-27 14:59 ` Michael Buesch
2009-03-27 15:13 ` Henrique de Moraes Holschuh [this message]
2009-03-27 15:11 ` Johannes Berg
2009-03-28 0:55 ` Henrique de Moraes Holschuh
2009-03-27 21:10 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327151337.GD24288@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox