Re: [PATCH] rfkill-input: remove unused code

[Michael Buesch <mb@bu3sch.de>]

On Friday 27 March 2009 15:36:08 Henrique de Moraes Holschuh wrote:
> On Fri, 27 Mar 2009, Johannes Berg wrote:
> > There's a lot of rfkill-input code that cannot ever be
> > compiled and is useless until somebody needs and tests
> > it -- therefore remove it.
> 
> Just so that you guys know, that code *is* tested :-)
> 
> I'd suggest that the code removal be done leaving a comment in place, like this:
> 
> /* Currently, code to implement EV_SW SW_WLAN/WWAN/BLUETOOTH/etc is not
>  * in place since it was unused and was therefore removed.  Please look
>  * at past history to check how it was supposed to be done, if you need
>  * to implement handling for EV_SW.
>  */
> 
> Because that codepath is _not_ the most obvious thing in the world to
> reimplement without hitting a pitfall, so people better look how it was done
> once in time...
> 

In practice this stuff does bitrot.
So in my opinion it's _not_ a good idea to lookup some old code for implementing
a feature. Instead one should think about it and understand the stuff and then implement it.
And if there are pitfalls that are not obvious after one completely read the code, one
should consider a redesign.

-- 
Greetings, Michael.