From: Bob Copeland <me@bobcopeland.com>
To: Pierre Ossman <pierre@ossman.eu>
Cc: Kalle Valo <kalle.valo@iki.fi>,
linux-wireless@vger.kernel.org, san@google.com
Subject: Re: [PATCH/RFC 7/7] wl12xx: add sdio support
Date: Sun, 21 Jun 2009 20:05:12 -0400 [thread overview]
Message-ID: <20090622000512.GA30186@hash.localnet> (raw)
In-Reply-To: <20090621203800.08cb4a2d@mjolnir.ossman.eu>
On Sun, Jun 21, 2009 at 08:38:00PM +0200, Pierre Ossman wrote:
> This does not sound very Linux:y. Module loading order should not foul
> up things. If it does, then there is some missing dependency somewhere.
Agreed.
> I noticed one more thing though. You call wl12xx_irq() on interrupts,
> and that's all you do. So I have to assume that calls back to
> wl12xx_sdio_read().
It schedules a workqueue, so it shouldn't be a problem.
> Has this code actually been tested? It doesn't seem like it can work to
> me.
Only very basic testing but yeah, it works.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-06-22 0:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 2:02 [PATCH/RFC 0/7] wl12xx SDIO interface Bob Copeland
2009-06-11 2:02 ` [PATCH/RFC 1/7] wl12xx: separate bus i/o code into io.c Bob Copeland
2009-06-11 2:02 ` [PATCH/RFC 2/7] wl12xx: use wiphy_dev instead of wl->spi->dev Bob Copeland
2009-06-11 2:02 ` [PATCH/RFC 3/7] wl12xx: introduce wl12xx_if_operations struct Bob Copeland
2009-06-11 2:02 ` [PATCH/RFC 4/7] wl12xx: make wl12xx_set_partition bus agnostic Bob Copeland
2009-06-11 2:02 ` [PATCH/RFC 5/7] wl12xx: move module probe methods into spi.c Bob Copeland
2009-06-11 2:02 ` [PATCH/RFC 6/7] wl12xx: split spi interface into separate module Bob Copeland
2009-06-11 2:03 ` [PATCH/RFC 7/7] wl12xx: add sdio support Bob Copeland
2009-06-13 11:21 ` Pierre Ossman
2009-06-13 16:00 ` Kalle Valo
2009-06-13 19:41 ` Marcel Holtmann
2009-06-13 20:13 ` Kalle Valo
2009-06-13 20:24 ` Marcel Holtmann
2009-06-13 20:44 ` Kalle Valo
2009-06-13 20:09 ` Pierre Ossman
2009-06-13 20:57 ` Bob Copeland
2009-06-18 2:25 ` Bob Copeland
2009-06-19 19:24 ` Pierre Ossman
2009-06-19 20:31 ` Bob Copeland
2009-06-20 4:29 ` Kalle Valo
2009-06-21 18:38 ` Pierre Ossman
2009-06-22 0:05 ` Bob Copeland [this message]
2009-06-22 6:09 ` Pierre Ossman
2009-06-22 6:14 ` Pierre Ossman
2009-06-23 2:18 ` Bob Copeland
2009-07-15 7:12 ` Ohad Ben-Cohen
2009-07-15 12:08 ` Bob Copeland
2009-06-11 14:38 ` [PATCH/RFC 0/7] wl12xx SDIO interface Gábor Stefanik
2009-06-11 14:54 ` Florian Fainelli
2009-06-11 17:06 ` Bob Copeland
2009-06-11 14:55 ` Samuel Ortiz
2009-06-11 14:59 ` Florian Fainelli
2009-06-11 15:04 ` Gábor Stefanik
2009-06-11 15:08 ` Florian Fainelli
2009-06-11 15:03 ` Samuel Ortiz
2009-06-11 15:54 ` Kalle Valo
2009-06-11 17:08 ` Bob Copeland
2009-06-11 17:14 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090622000512.GA30186@hash.localnet \
--to=me@bobcopeland.com \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=pierre@ossman.eu \
--cc=san@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox