Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH v3 12/22] iwlwifi: mvm: start to remove the code for d0i3
Date: Mon, 19 Aug 2019 19:49:57 +0300	[thread overview]
Message-ID: <20190819165007.10181-13-luca@coelho.fi> (raw)
In-Reply-To: <20190819165007.10181-1-luca@coelho.fi>

From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

For runtime PM to work with d0i3 code, a lot of integration work needs
to be done with the platform (e.g. the out-of-band wake up interrupt)
and we currently don't have any platforms where this integration
happened.  So, this code has been pretty much stale for a while and
when someone enables it, it just breaks things.

Therefore, to simplify the code base and make sure no one enables this
by mistake, we will remove the whole code.

This is only the very start, much more work is needed.
Remove the places where we check iwl_mvm_is_d0i3_supported
but leave all the refs, those will be removed in a different
patch.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 .../net/wireless/intel/iwlwifi/mvm/mac80211.c  | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
index 438a8b5b90c2..07d576d29086 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
@@ -762,12 +762,6 @@ int iwl_mvm_mac_setup_register(struct iwl_mvm *mvm)
 	mvm->rts_threshold = IEEE80211_MAX_RTS_THRESHOLD;
 
 #ifdef CONFIG_PM_SLEEP
-	if (iwl_mvm_is_d0i3_supported(mvm) &&
-	    device_can_wakeup(mvm->trans->dev)) {
-		mvm->wowlan.flags = WIPHY_WOWLAN_ANY;
-		hw->wiphy->wowlan = &mvm->wowlan;
-	}
-
 	if ((unified || mvm->fw->img[IWL_UCODE_WOWLAN].num_sec) &&
 	    mvm->trans->ops->d3_suspend &&
 	    mvm->trans->ops->d3_resume &&
@@ -1359,17 +1353,6 @@ static void iwl_mvm_restart_complete(struct iwl_mvm *mvm)
 	mutex_unlock(&mvm->mutex);
 }
 
-static void iwl_mvm_resume_complete(struct iwl_mvm *mvm)
-{
-	if (iwl_mvm_is_d0i3_supported(mvm) &&
-	    iwl_mvm_enter_d0i3_on_suspend(mvm))
-		WARN_ONCE(!wait_event_timeout(mvm->d0i3_exit_waitq,
-					      !test_bit(IWL_MVM_STATUS_IN_D0I3,
-							&mvm->status),
-					      HZ),
-			  "D0i3 exit on resume timed out\n");
-}
-
 static void
 iwl_mvm_mac_reconfig_complete(struct ieee80211_hw *hw,
 			      enum ieee80211_reconfig_type reconfig_type)
@@ -1381,7 +1364,6 @@ iwl_mvm_mac_reconfig_complete(struct ieee80211_hw *hw,
 		iwl_mvm_restart_complete(mvm);
 		break;
 	case IEEE80211_RECONFIG_TYPE_SUSPEND:
-		iwl_mvm_resume_complete(mvm);
 		break;
 	}
 }
-- 
2.23.0.rc1


  parent reply	other threads:[~2019-08-19 16:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-19 16:49 [PATCH v3 00/22] iwlwifi: updates intended for v5.4 2019-08-17-3 Luca Coelho
2019-08-19 16:49 ` [PATCH v3 01/22] iwlwifi: bump FW API to 49 for 22000 series Luca Coelho
2019-08-19 16:49 ` [PATCH v3 02/22] iwlwifi: Send DQA enable command only if TVL is on Luca Coelho
2019-08-19 16:49 ` [PATCH v3 03/22] iwlwifi: mvm: remove redundant condition in iwl_mvm_set_hw_rfkill_state Luca Coelho
2019-08-19 16:49 ` [PATCH v3 04/22] iwlwifi: mvm: Block 26-tone RU OFDMA transmissions Luca Coelho
2019-08-19 16:49 ` [PATCH v3 05/22] iwlwifi: mvm: remove unnecessary forward declarations Luca Coelho
2019-08-19 16:49 ` [PATCH v3 06/22] iwlwifi: dbg: move monitor recording functionality from header file Luca Coelho
2019-08-19 16:49 ` [PATCH v3 07/22] iwlwifi: dbg: move debug recording stop from trans to op mode Luca Coelho
2019-08-19 16:49 ` [PATCH v3 08/22] iwlwifi: dbg: support debug recording suspend resume command Luca Coelho
2019-08-19 16:49 ` [PATCH v3 09/22] iwlwifi: add ldbg config cmd debug print Luca Coelho
2019-08-19 16:49 ` [PATCH v3 10/22] iwlwifi: mvm: fix scan config command size Luca Coelho
2019-08-19 16:49 ` [PATCH v3 11/22] iwlwifi: mvm: add the skb length to a print Luca Coelho
2019-08-19 16:49 ` Luca Coelho [this message]
2019-08-19 16:49 ` [PATCH v3 13/22] iwlwifi: remove all the d0i3 references Luca Coelho
2019-08-19 16:49 ` [PATCH v3 14/22] iwlwifi: mvm: remove the tx defer for d0i3 Luca Coelho
2019-08-19 16:50 ` [PATCH v3 15/22] iwlwifi: mvm: remove the d0i3 entry/exit flow Luca Coelho
2019-08-19 16:50 ` [PATCH v3 16/22] iwlwifi: mvm: iwl_mvm_wowlan_config_key_params is for wowlan only Luca Coelho
2019-08-19 16:50 ` [PATCH v3 17/22] iwlwifi: mvm: remove d0i3_ap_sta_id Luca Coelho
2019-08-19 16:50 ` [PATCH v3 18/22] iwlwifi: mvm: remove iwl_mvm_update_d0i3_power_mode Luca Coelho
2019-08-19 16:50 ` [PATCH v3 19/22] iwlwifi: mvm: remove last leftovers of d0i3 Luca Coelho
2019-08-19 16:50 ` [PATCH v3 20/22] iwlwifi: remove CMD_HIGH_PRIO Luca Coelho
2019-08-19 16:50 ` [PATCH v3 21/22] iwlwifi: trans: remove suspending flag Luca Coelho
2019-08-19 16:50 ` [PATCH v3 22/22] iwlwifi: remove the code under IWLWIFI_PCIE_RTPM Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190819165007.10181-13-luca@coelho.fi \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox