Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH v3 03/22] iwlwifi: mvm: remove redundant condition in iwl_mvm_set_hw_rfkill_state
Date: Mon, 19 Aug 2019 19:49:48 +0300	[thread overview]
Message-ID: <20190819165007.10181-4-luca@coelho.fi> (raw)
In-Reply-To: <20190819165007.10181-1-luca@coelho.fi>

From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

If mvm->fwrt.cur_fw_img != IWL_UCODE_INIT, then
rfkill_safe_init_done must be true since
rfkill_safe_init_done is set to true before we start to load
the runtime image.
Remove the redundant condition.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
index 4888054dc3d8..722e427d534c 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
@@ -1234,8 +1234,7 @@ static bool iwl_mvm_set_hw_rfkill_state(struct iwl_op_mode *op_mode, bool state)
 	 * Stop the device if we run OPERATIONAL firmware or if we are in the
 	 * middle of the calibrations.
 	 */
-	return state && (mvm->fwrt.cur_fw_img != IWL_UCODE_INIT ||
-			 rfkill_safe_init_done);
+	return state && rfkill_safe_init_done;
 }
 
 static void iwl_mvm_free_skb(struct iwl_op_mode *op_mode, struct sk_buff *skb)
-- 
2.23.0.rc1


  parent reply	other threads:[~2019-08-19 16:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-19 16:49 [PATCH v3 00/22] iwlwifi: updates intended for v5.4 2019-08-17-3 Luca Coelho
2019-08-19 16:49 ` [PATCH v3 01/22] iwlwifi: bump FW API to 49 for 22000 series Luca Coelho
2019-08-19 16:49 ` [PATCH v3 02/22] iwlwifi: Send DQA enable command only if TVL is on Luca Coelho
2019-08-19 16:49 ` Luca Coelho [this message]
2019-08-19 16:49 ` [PATCH v3 04/22] iwlwifi: mvm: Block 26-tone RU OFDMA transmissions Luca Coelho
2019-08-19 16:49 ` [PATCH v3 05/22] iwlwifi: mvm: remove unnecessary forward declarations Luca Coelho
2019-08-19 16:49 ` [PATCH v3 06/22] iwlwifi: dbg: move monitor recording functionality from header file Luca Coelho
2019-08-19 16:49 ` [PATCH v3 07/22] iwlwifi: dbg: move debug recording stop from trans to op mode Luca Coelho
2019-08-19 16:49 ` [PATCH v3 08/22] iwlwifi: dbg: support debug recording suspend resume command Luca Coelho
2019-08-19 16:49 ` [PATCH v3 09/22] iwlwifi: add ldbg config cmd debug print Luca Coelho
2019-08-19 16:49 ` [PATCH v3 10/22] iwlwifi: mvm: fix scan config command size Luca Coelho
2019-08-19 16:49 ` [PATCH v3 11/22] iwlwifi: mvm: add the skb length to a print Luca Coelho
2019-08-19 16:49 ` [PATCH v3 12/22] iwlwifi: mvm: start to remove the code for d0i3 Luca Coelho
2019-08-19 16:49 ` [PATCH v3 13/22] iwlwifi: remove all the d0i3 references Luca Coelho
2019-08-19 16:49 ` [PATCH v3 14/22] iwlwifi: mvm: remove the tx defer for d0i3 Luca Coelho
2019-08-19 16:50 ` [PATCH v3 15/22] iwlwifi: mvm: remove the d0i3 entry/exit flow Luca Coelho
2019-08-19 16:50 ` [PATCH v3 16/22] iwlwifi: mvm: iwl_mvm_wowlan_config_key_params is for wowlan only Luca Coelho
2019-08-19 16:50 ` [PATCH v3 17/22] iwlwifi: mvm: remove d0i3_ap_sta_id Luca Coelho
2019-08-19 16:50 ` [PATCH v3 18/22] iwlwifi: mvm: remove iwl_mvm_update_d0i3_power_mode Luca Coelho
2019-08-19 16:50 ` [PATCH v3 19/22] iwlwifi: mvm: remove last leftovers of d0i3 Luca Coelho
2019-08-19 16:50 ` [PATCH v3 20/22] iwlwifi: remove CMD_HIGH_PRIO Luca Coelho
2019-08-19 16:50 ` [PATCH v3 21/22] iwlwifi: trans: remove suspending flag Luca Coelho
2019-08-19 16:50 ` [PATCH v3 22/22] iwlwifi: remove the code under IWLWIFI_PCIE_RTPM Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190819165007.10181-4-luca@coelho.fi \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox