Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH v3 19/22] iwlwifi: mvm: remove last leftovers of d0i3
Date: Mon, 19 Aug 2019 19:50:04 +0300	[thread overview]
Message-ID: <20190819165007.10181-20-luca@coelho.fi> (raw)
In-Reply-To: <20190819165007.10181-1-luca@coelho.fi>

From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

We're now left with a status bit that is never set and a few
other leftovers.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 3 ---
 drivers/net/wireless/intel/iwlwifi/mvm/mvm.h      | 7 -------
 drivers/net/wireless/intel/iwlwifi/mvm/sta.c      | 7 -------
 3 files changed, 17 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
index f4aa121f36f8..e49558fb8aa3 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
@@ -1079,9 +1079,6 @@ static void iwl_mvm_restart_cleanup(struct iwl_mvm *mvm)
 
 	ieee80211_wake_queues(mvm->hw);
 
-	/* clear any stale d0i3 state */
-	clear_bit(IWL_MVM_STATUS_IN_D0I3, &mvm->status);
-
 	mvm->vif_count = 0;
 	mvm->rx_ba_sessions = 0;
 	mvm->fwrt.dump.conf = FW_DBG_INVALID;
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
index 15780e994a30..ed52e2ea97d9 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
@@ -588,11 +588,6 @@ struct iwl_mvm_frame_stats {
 	int last_frame_idx;
 };
 
-enum {
-	D0I3_DEFER_WAKEUP,
-	D0I3_PENDING_WAKEUP,
-};
-
 #define IWL_MVM_DEBUG_SET_TEMPERATURE_DISABLE 0xff
 #define IWL_MVM_DEBUG_SET_TEMPERATURE_MIN -100
 #define IWL_MVM_DEBUG_SET_TEMPERATURE_MAX 200
@@ -1157,7 +1152,6 @@ struct iwl_mvm {
  * @IWL_MVM_STATUS_ROC_RUNNING: remain-on-channel is running
  * @IWL_MVM_STATUS_HW_RESTART_REQUESTED: HW restart was requested
  * @IWL_MVM_STATUS_IN_HW_RESTART: HW restart is active
- * @IWL_MVM_STATUS_IN_D0I3: NIC is in D0i3
  * @IWL_MVM_STATUS_ROC_AUX_RUNNING: AUX remain-on-channel is running
  * @IWL_MVM_STATUS_FIRMWARE_RUNNING: firmware is running
  * @IWL_MVM_STATUS_NEED_FLUSH_P2P: need to flush P2P bcast STA
@@ -1168,7 +1162,6 @@ enum iwl_mvm_status {
 	IWL_MVM_STATUS_ROC_RUNNING,
 	IWL_MVM_STATUS_HW_RESTART_REQUESTED,
 	IWL_MVM_STATUS_IN_HW_RESTART,
-	IWL_MVM_STATUS_IN_D0I3,
 	IWL_MVM_STATUS_ROC_AUX_RUNNING,
 	IWL_MVM_STATUS_FIRMWARE_RUNNING,
 	IWL_MVM_STATUS_NEED_FLUSH_P2P,
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
index b0f92c9b20f0..aa0a2a3e0875 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
@@ -2759,13 +2759,6 @@ int iwl_mvm_sta_tx_agg_start(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
 
 	spin_lock_bh(&mvmsta->lock);
 
-	/* possible race condition - we entered D0i3 while starting agg */
-	if (test_bit(IWL_MVM_STATUS_IN_D0I3, &mvm->status)) {
-		spin_unlock_bh(&mvmsta->lock);
-		IWL_ERR(mvm, "Entered D0i3 while starting Tx agg\n");
-		return -EIO;
-	}
-
 	/*
 	 * Note the possible cases:
 	 *  1. An enabled TXQ - TXQ needs to become agg'ed
-- 
2.23.0.rc1


  parent reply	other threads:[~2019-08-19 16:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-19 16:49 [PATCH v3 00/22] iwlwifi: updates intended for v5.4 2019-08-17-3 Luca Coelho
2019-08-19 16:49 ` [PATCH v3 01/22] iwlwifi: bump FW API to 49 for 22000 series Luca Coelho
2019-08-19 16:49 ` [PATCH v3 02/22] iwlwifi: Send DQA enable command only if TVL is on Luca Coelho
2019-08-19 16:49 ` [PATCH v3 03/22] iwlwifi: mvm: remove redundant condition in iwl_mvm_set_hw_rfkill_state Luca Coelho
2019-08-19 16:49 ` [PATCH v3 04/22] iwlwifi: mvm: Block 26-tone RU OFDMA transmissions Luca Coelho
2019-08-19 16:49 ` [PATCH v3 05/22] iwlwifi: mvm: remove unnecessary forward declarations Luca Coelho
2019-08-19 16:49 ` [PATCH v3 06/22] iwlwifi: dbg: move monitor recording functionality from header file Luca Coelho
2019-08-19 16:49 ` [PATCH v3 07/22] iwlwifi: dbg: move debug recording stop from trans to op mode Luca Coelho
2019-08-19 16:49 ` [PATCH v3 08/22] iwlwifi: dbg: support debug recording suspend resume command Luca Coelho
2019-08-19 16:49 ` [PATCH v3 09/22] iwlwifi: add ldbg config cmd debug print Luca Coelho
2019-08-19 16:49 ` [PATCH v3 10/22] iwlwifi: mvm: fix scan config command size Luca Coelho
2019-08-19 16:49 ` [PATCH v3 11/22] iwlwifi: mvm: add the skb length to a print Luca Coelho
2019-08-19 16:49 ` [PATCH v3 12/22] iwlwifi: mvm: start to remove the code for d0i3 Luca Coelho
2019-08-19 16:49 ` [PATCH v3 13/22] iwlwifi: remove all the d0i3 references Luca Coelho
2019-08-19 16:49 ` [PATCH v3 14/22] iwlwifi: mvm: remove the tx defer for d0i3 Luca Coelho
2019-08-19 16:50 ` [PATCH v3 15/22] iwlwifi: mvm: remove the d0i3 entry/exit flow Luca Coelho
2019-08-19 16:50 ` [PATCH v3 16/22] iwlwifi: mvm: iwl_mvm_wowlan_config_key_params is for wowlan only Luca Coelho
2019-08-19 16:50 ` [PATCH v3 17/22] iwlwifi: mvm: remove d0i3_ap_sta_id Luca Coelho
2019-08-19 16:50 ` [PATCH v3 18/22] iwlwifi: mvm: remove iwl_mvm_update_d0i3_power_mode Luca Coelho
2019-08-19 16:50 ` Luca Coelho [this message]
2019-08-19 16:50 ` [PATCH v3 20/22] iwlwifi: remove CMD_HIGH_PRIO Luca Coelho
2019-08-19 16:50 ` [PATCH v3 21/22] iwlwifi: trans: remove suspending flag Luca Coelho
2019-08-19 16:50 ` [PATCH v3 22/22] iwlwifi: remove the code under IWLWIFI_PCIE_RTPM Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190819165007.10181-20-luca@coelho.fi \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox