Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH v3 17/22] iwlwifi: mvm: remove d0i3_ap_sta_id
Date: Mon, 19 Aug 2019 19:50:02 +0300	[thread overview]
Message-ID: <20190819165007.10181-18-luca@coelho.fi> (raw)
In-Reply-To: <20190819165007.10181-1-luca@coelho.fi>

From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

This variable read, but never set. Remove it.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 4 ----
 drivers/net/wireless/intel/iwlwifi/mvm/mvm.h      | 3 ---
 drivers/net/wireless/intel/iwlwifi/mvm/sta.c      | 4 ----
 3 files changed, 11 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
index 2a246f69229d..f4aa121f36f8 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
@@ -1071,7 +1071,6 @@ static void iwl_mvm_restart_cleanup(struct iwl_mvm *mvm)
 	ieee80211_iterate_interfaces(mvm->hw, 0, iwl_mvm_cleanup_iterator, mvm);
 
 	mvm->p2p_device_vif = NULL;
-	mvm->d0i3_ap_sta_id = IWL_MVM_INVALID_STA;
 
 	iwl_mvm_reset_phy_ctxts(mvm);
 	memset(mvm->fw_key_table, 0, sizeof(mvm->fw_key_table));
@@ -2335,9 +2334,6 @@ static void iwl_mvm_bss_info_changed_station(struct iwl_mvm *mvm,
 					IWL_ERR(mvm,
 						"failed to remove AP station\n");
 
-				if (mvm->d0i3_ap_sta_id == mvmvif->ap_sta_id)
-					mvm->d0i3_ap_sta_id =
-						IWL_MVM_INVALID_STA;
 				mvmvif->ap_sta_id = IWL_MVM_INVALID_STA;
 			}
 
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
index 03f3faa02781..4a9e8ae99cac 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
@@ -1015,9 +1015,6 @@ struct iwl_mvm {
 #endif
 #endif
 
-	/* d0i3 */
-	u8 d0i3_ap_sta_id;
-
 	wait_queue_head_t rx_sync_waitq;
 
 	/* BT-Coex */
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
index 4fae0cb22195..b0f92c9b20f0 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
@@ -1887,10 +1887,6 @@ int iwl_mvm_rm_sta(struct iwl_mvm *mvm,
 
 		/* unassoc - go ahead - remove the AP STA now */
 		mvmvif->ap_sta_id = IWL_MVM_INVALID_STA;
-
-		/* clear d0i3_ap_sta_id if no longer relevant */
-		if (mvm->d0i3_ap_sta_id == sta_id)
-			mvm->d0i3_ap_sta_id = IWL_MVM_INVALID_STA;
 	}
 
 	/*
-- 
2.23.0.rc1


  parent reply	other threads:[~2019-08-19 16:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-19 16:49 [PATCH v3 00/22] iwlwifi: updates intended for v5.4 2019-08-17-3 Luca Coelho
2019-08-19 16:49 ` [PATCH v3 01/22] iwlwifi: bump FW API to 49 for 22000 series Luca Coelho
2019-08-19 16:49 ` [PATCH v3 02/22] iwlwifi: Send DQA enable command only if TVL is on Luca Coelho
2019-08-19 16:49 ` [PATCH v3 03/22] iwlwifi: mvm: remove redundant condition in iwl_mvm_set_hw_rfkill_state Luca Coelho
2019-08-19 16:49 ` [PATCH v3 04/22] iwlwifi: mvm: Block 26-tone RU OFDMA transmissions Luca Coelho
2019-08-19 16:49 ` [PATCH v3 05/22] iwlwifi: mvm: remove unnecessary forward declarations Luca Coelho
2019-08-19 16:49 ` [PATCH v3 06/22] iwlwifi: dbg: move monitor recording functionality from header file Luca Coelho
2019-08-19 16:49 ` [PATCH v3 07/22] iwlwifi: dbg: move debug recording stop from trans to op mode Luca Coelho
2019-08-19 16:49 ` [PATCH v3 08/22] iwlwifi: dbg: support debug recording suspend resume command Luca Coelho
2019-08-19 16:49 ` [PATCH v3 09/22] iwlwifi: add ldbg config cmd debug print Luca Coelho
2019-08-19 16:49 ` [PATCH v3 10/22] iwlwifi: mvm: fix scan config command size Luca Coelho
2019-08-19 16:49 ` [PATCH v3 11/22] iwlwifi: mvm: add the skb length to a print Luca Coelho
2019-08-19 16:49 ` [PATCH v3 12/22] iwlwifi: mvm: start to remove the code for d0i3 Luca Coelho
2019-08-19 16:49 ` [PATCH v3 13/22] iwlwifi: remove all the d0i3 references Luca Coelho
2019-08-19 16:49 ` [PATCH v3 14/22] iwlwifi: mvm: remove the tx defer for d0i3 Luca Coelho
2019-08-19 16:50 ` [PATCH v3 15/22] iwlwifi: mvm: remove the d0i3 entry/exit flow Luca Coelho
2019-08-19 16:50 ` [PATCH v3 16/22] iwlwifi: mvm: iwl_mvm_wowlan_config_key_params is for wowlan only Luca Coelho
2019-08-19 16:50 ` Luca Coelho [this message]
2019-08-19 16:50 ` [PATCH v3 18/22] iwlwifi: mvm: remove iwl_mvm_update_d0i3_power_mode Luca Coelho
2019-08-19 16:50 ` [PATCH v3 19/22] iwlwifi: mvm: remove last leftovers of d0i3 Luca Coelho
2019-08-19 16:50 ` [PATCH v3 20/22] iwlwifi: remove CMD_HIGH_PRIO Luca Coelho
2019-08-19 16:50 ` [PATCH v3 21/22] iwlwifi: trans: remove suspending flag Luca Coelho
2019-08-19 16:50 ` [PATCH v3 22/22] iwlwifi: remove the code under IWLWIFI_PCIE_RTPM Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190819165007.10181-18-luca@coelho.fi \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox