Re: [PATCH wireless-next v2 1/3] wifi: cfg80211: Add support for S1G Response Indication Configuration

[Ria Thomas <ria.thomas@morsemicro.com>]

Hi Johannes,

Thanks for the feedback.

> And for the certification test, presumably the choice for testbed STA
> (for certain frames at least, I guess not intended to break the rules
> for cases where there's no/less choice) is not meant to be left to the
> implementation, but rather meant to be set, presumably to check that the
> receiver reacts correctly.

Yes, for certification testing this configuration is intended to verify
that the receiver of the PPDU correctly interprets and acts upon the
Response Indication value set by the transmitter.

> Now that I've described it this way, I think the biggest question I have
> is actually how, if at all, we need this in a non-testing scenario?

This configuration is not expected to be used in any non-testing cases.

> But we still need to decide where it should live, although in
> that case I'd be more willing to accept an interface setting despite
> the lifetime issues.)
> 

We think it makes the most sense to treat Response Indication as an
interface-level setting  as it avoids introducing peer-specific state
that is neither negotiated nor maintained by the protocol.

That said as the response indication is only a test configuration there
is expected to be some changes to the upcoming patches. I would preferably
submit the response indication configuration as a single patch and NDP
ADDBA/DELBA negotiations as a different patch. This would open up two different
new mail chains for two patches which is different from the current one.

Looking forward to hear your thoughts on this.

Ria