Re: [PATCH wireless-next v2 1/3] wifi: cfg80211: Add support for S1G Response Indication Configuration

[Johannes Berg <johannes@sipsolutions.net>]

Hi,

> > But we still need to decide where it should live, although in
> > that case I'd be more willing to accept an interface setting despite
> > the lifetime issues.)
> > 
> 
> We think it makes the most sense to treat Response Indication as an
> interface-level setting  as it avoids introducing peer-specific state
> that is neither negotiated nor maintained by the protocol.

Fair. I don't really think it makes a huge difference - this state is
not negotiated nor maintained by the protocol at the interface level
either, after all :-) In a way I don't think it's a good argument either
way I guess, but if it's only a debug config I also don't care much (and
we already have things like tkip_mic_test that are in a way similar.)

> That said as the response indication is only a test configuration there
> is expected to be some changes to the upcoming patches. I would preferably
> submit the response indication configuration as a single patch and NDP
> ADDBA/DELBA negotiations as a different patch. This would open up two different
> new mail chains for two patches which is different from the current one.

Sure, if it can be separated I have no issues with that.

johannes