From: Johannes Berg <johannes@sipsolutions.net>
To: Ria Thomas <ria.thomas@morsemicro.com>
Cc: linux-wireless@vger.kernel.org, lachlan.hodges@morsemicro.com,
arien.judge@morsemicro.com, pradeep.reddy@morsemicro.com,
simon@morsemicro.com
Subject: Re: [PATCH wireless-next v2 1/3] wifi: cfg80211: Add support for S1G Response Indication Configuration
Date: Thu, 08 Jan 2026 13:27:44 +0100 [thread overview]
Message-ID: <9eb13765529bac88337ab2fd1a13769fa4519f52.camel@sipsolutions.net> (raw)
In-Reply-To: <20251209062424.3926297-2-ria.thomas@morsemicro.com> (sfid-20251209_072520_787538_A301A7A4)
On Tue, 2025-12-09 at 11:54 +0530, Ria Thomas wrote:
> In S1G, a STA distributes a Response Indication (RI) to protect the
> frame expected at SIFS after the eliciting frame. Introduce a
> userspace configurable selector for the expected response frame
> type (i.e., Block Ack, NDP, or no response) after transmitting
> certain S1G frames.
> + int (*set_s1g_ri)(struct wiphy *wiphy, struct net_device *dev,
> + u8 val);
I'm generally not very happy with state that simply "exists" at the
interface level. The documentation doesn't indicate anything, but the
implementation in mac80211 just treats it as such.
Does it really _need_ to be that way for any reason, rather than being a
setting that is, say, part of the association and/or AP setup?
johannes
next prev parent reply other threads:[~2026-01-08 12:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 6:24 [PATCH wireless-next v2 0/3] wifi: add S1G response indication configuration with NDP BA support Ria Thomas
2025-12-09 6:24 ` [PATCH wireless-next v2 1/3] wifi: cfg80211: Add support for S1G Response Indication Configuration Ria Thomas
2026-01-08 12:27 ` Johannes Berg [this message]
2026-01-09 4:00 ` Ria Thomas
2026-01-13 8:50 ` Johannes Berg
2026-01-16 5:31 ` Ria Thomas
2026-02-06 6:11 ` Ria Thomas
2026-02-06 7:57 ` Johannes Berg
2026-02-12 8:43 ` Ria Thomas
2026-02-17 11:41 ` Johannes Berg
2025-12-09 6:24 ` [PATCH wireless-next v2 2/3] wifi: mac80211: track S1G Response Indication (RI) and notify drivers Ria Thomas
2025-12-09 6:24 ` [PATCH wireless-next v2 3/3] wifi: mac80211: add support for NDP ADDBA/DELBA for S1G Ria Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9eb13765529bac88337ab2fd1a13769fa4519f52.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arien.judge@morsemicro.com \
--cc=lachlan.hodges@morsemicro.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pradeep.reddy@morsemicro.com \
--cc=ria.thomas@morsemicro.com \
--cc=simon@morsemicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox