From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Cc: Nicolai Stange <nicstange@gmail.com>
Subject: Re: 6.7.0-rc1 + hacks deadlock bug, wifi netdev delete + cat of debugfs file.
Date: Wed, 08 Nov 2023 17:21:35 +0100 [thread overview]
Message-ID: <63879a52c28d0140730d8504889c3da17738fe2e.camel@sipsolutions.net> (raw)
In-Reply-To: <d77c0a76201f77b7e86c2f200d2fea5cb6bffb94.camel@sipsolutions.net>
On Wed, 2023-11-08 at 16:44 +0100, Johannes Berg wrote:
>
> > I have been running similar code for...like 15 years, and haven't seen this particular
> > deadlock before, so I think it is at least exacerbated by the locking changes. Or maybe
> > I had particularly bad luck yesterday....
>
> Oh, it almost certainly did get at least worse or perhaps introduced by
> (a) moving everything to a single lock and (b) moving debugfs file
> removal under the lock.
>
FWIW, the debugfs remove was under lock before, but we didn't acquire
much locks in the debugfs itself (only sta mtx and only in aql write,
and that mutex isn't held in remove) ... So indeed it couldn't happen.
I added that to call into drivers with the wiphy mutex though, can't
really remove that, I think.
johannes
prev parent reply other threads:[~2023-11-08 16:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 22:08 6.7.0-rc1 + hacks deadlock bug, wifi netdev delete + cat of debugfs file Ben Greear
2023-11-08 10:31 ` Johannes Berg
2023-11-08 15:07 ` Ben Greear
2023-11-08 15:44 ` Johannes Berg
2023-11-08 15:55 ` Ben Greear
2023-11-08 16:07 ` Johannes Berg
2023-11-08 17:39 ` Benjamin Berg
2023-11-08 17:46 ` Ben Greear
2023-11-08 17:44 ` Ben Greear
2023-11-08 18:43 ` Johannes Berg
2023-11-08 20:04 ` Ben Greear
2023-11-08 20:06 ` Johannes Berg
2023-11-08 16:21 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63879a52c28d0140730d8504889c3da17738fe2e.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nicstange@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox