Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: 6.7.0-rc1 + hacks deadlock bug, wifi netdev delete + cat of debugfs file.
Date: Wed, 08 Nov 2023 11:31:57 +0100	[thread overview]
Message-ID: <cb377661e760d7728d11bd155b016f852b2681eb.camel@sipsolutions.net> (raw)
In-Reply-To: <56d0b043-0585-5380-5703-f25d9a42f39d@candelatech.com>

On Tue, 2023-11-07 at 14:08 -0800, Ben Greear wrote:
> Hello,
> 
> I think this lockup is because iw is holding rtnl and wiphy mutex,
> and is blocked waiting for debugfs to be closed.  Another 'cat'
> program has debugfs file open, and is blocking on trying to acquire
> wiphy mutex.
> 
> I think we must not acquire wiphy mutex in debugfs methods, somehow,
> to resolve this deadlock.  I do not know a safe way to do that.

Hmm. I almost want to say "don't do that then", but I guess you're just
randomly accessing debugfs files.

I guess we can at least make the mutex acquisition in debugfs killable
(or interruptible), so you can recover from this.

But fundamentally this is probably not really even a new issue.

I don't know how to interrupt a specific task that's stuck in a specific
debugfs file though, e.g. when removing them.

johannes

  reply	other threads:[~2023-11-08 10:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07 22:08 6.7.0-rc1 + hacks deadlock bug, wifi netdev delete + cat of debugfs file Ben Greear
2023-11-08 10:31 ` Johannes Berg [this message]
2023-11-08 15:07   ` Ben Greear
2023-11-08 15:44     ` Johannes Berg
2023-11-08 15:55       ` Ben Greear
2023-11-08 16:07         ` Johannes Berg
2023-11-08 17:39           ` Benjamin Berg
2023-11-08 17:46             ` Ben Greear
2023-11-08 17:44           ` Ben Greear
2023-11-08 18:43             ` Johannes Berg
2023-11-08 20:04               ` Ben Greear
2023-11-08 20:06                 ` Johannes Berg
2023-11-08 16:21       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb377661e760d7728d11bd155b016f852b2681eb.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox