Re: [PATCH rtw-next 01/15] wifi: rtw89: coex: fix RF band check in _set_rf_trx_para() and its propagation

[Ping-Ke Shih <pkshih@realtek.com>]

Ping-Ke Shih <pkshih@realtek.com> wrote:

> From: Ching-Te Ku <ku920601@realtek.com>
> 
> dm->tdd_bind.rf_band holds a bitmask built from BIT(BTC_BT_B2G) and
> BIT(BTC_BT_B5G), but _set_rf_trx_para() compared it against the raw
> band enum values RTW89_BAND_5G and RTW89_BAND_2G instead of their
> BIT() form. Every other site in this file that reads tdd_bind.rf_band
> wraps the enum with BIT() before comparing.
> 
> Because RTW89_BAND_5G equals 1 and BIT(BTC_BT_B2G) also equals 1, a
> Wi-Fi/Bluetooth coexistence session bound to the 2.4 GHz band was
> misclassified as BTC_WLINK_V0_5G. This incorrectly skipped the RF
> Tx/Rx parameter adjustment for 2.4 GHz STA traffic and kept clearing
> wl_stb_chg to 0, so chip->ops->btc_wl_s1_standby() never re-enabled
> the Wi-Fi standby workaround for the Bluetooth Tx-to-Rx GNT switch on
> RTL8852C, degrading Wi-Fi performance while coexisting with Bluetooth
> on 2.4 GHz.
> 
> Compare rf_band against BIT(RTW89_BAND_5G) and BIT(RTW89_BAND_2G) to
> match its actual bitmask representation.
> 
> Signed-off-by: Ching-Te Ku <ku920601@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

15 patch(es) applied to rtw-next branch of rtw.git, thanks.

bf4c84e72fbd wifi: rtw89: coex: fix RF band check in _set_rf_trx_para() and its propagation
fd4d5551eae1 wifi: rtw89: coex: track per-HW-band WL role fields with arrays
fbe6912f1980 wifi: rtw89: coex: show per-HW-band MLO state in WL status dump
806bd61d5139 wifi: rtw89: coex: add outsrc-set-info v7 for BT SPDT state
235a6ff568c3 wifi: rtw89: coex: compute WL/BT cross-talk interference maps
c4b17492a37c wifi: rtw89: coex: add 1SS MIMO-PS decision for dual-BT CIS
a35cf81f6084 wifi: rtw89: coex: add firmware 0.35.119.3 support for RTL8922A/D
8773800337cd wifi: rtw89: coex: raise default BT TX power to 10 dBm
d4a862cf7661 wifi: rtw89: coex: bind the RF band in use while WL is doing RFK
96ad55bfbb65 wifi: rtw89: coex: store BT TX power per device and per RF band
f3207ae57274 wifi: rtw89: coex: set the WL/BT antenna map on shared-antenna chips
236478d51ffc wifi: rtw89: coex: use the right switch-type enum on RTL8922D
c739640e347f wifi: rtw89: phy: Implement API to control BTG to turn on/off BT TX/RX
256725d0ec78 wifi: rtw89: coex: turn BT TX/RX on and off through the BTG control
57dc6b251419 wifi: rtw89: coex: set rf_combination in _update_wl_mlo_info()

---
https://github.com/pkshih/rtw.git