Linux IEEE 802.15.4 and 6LoWPAN development
 help / color / mirror / Atom feed
From: Stefan Schmidt <stefan@osg.samsung.com>
To: Alexander Aring <alex.aring@gmail.com>, linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de
Subject: Re: [RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation
Date: Wed, 12 Aug 2015 10:15:52 +0200	[thread overview]
Message-ID: <55CB00B8.8010909@osg.samsung.com> (raw)
In-Reply-To: <1438583035-6287-1-git-send-email-alex.aring@gmail.com>

Hello.

On 03/08/15 08:23, Alexander Aring wrote:
> Hi,
>
> this patch series contains a rework of 802.15.4 6LoWPAN receive handling.
> We need to check on some things before which never checked before, like
> is 802.15.4 dataframe, if we can access skb->data[0] (could be that skb->len
> is 0 then), etc.
>
> Also various bug fixes like the masking for fragmentation dispatch value which
> is currently wrong. Also we should again check the dispatch value after successful
> reassembly a fragment, we currently assume always a iphc header there. This is wrong
> it could also be a non-compressed header. This can occur if the compressed header is
> larger than lower interface MTU size, we doesn't react on this while transmit which
> is another issue. Nevertheless we also don't reach this case at worst-case compression
> currently.
>
> I introduced a complete new handling for the dispatch values based on mac80211
> datatype receive handling mechanism.

I'm going to review this set over the next days. Just as a heads up.

> This patch series based on bluetooth-next with various pending patches, I uploaded
> the branch at:
>
> https://github.com/linux-wpan/linux-wpan-next/commits/802154_6lowpan_cleanup2
>
> so everybody can test it.

I tried to apply the patches directly on bluetooth-next but they did not 
apply. Guess you want to rebase them when sending out a new round. For 
now I will review the patches here and use the branch you uploaded for 
testing. Will report back later.

regards
Stefan Schmidt

  parent reply	other threads:[~2015-08-12  8:15 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03  6:23 [RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation Alexander Aring
2015-08-03  6:23 ` [RFC 01/16] ieee802154: 6lowpan: change dev vars to wdev and ldev Alexander Aring
2015-08-12  8:49   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 02/16] ieee802154: 6lowpan: remove set to zero Alexander Aring
2015-08-12  8:49   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 03/16] ieee802154: 6lowpan: remove EXPORT_SYMBOL Alexander Aring
2015-08-12  8:49   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 04/16] ieee802154: 6lowpan: remove check on wdev is running Alexander Aring
2015-08-12  8:49   ` Stefan Schmidt
2015-08-15 11:50   ` Alexander Aring
2015-08-03  6:23 ` [RFC 05/16] ieee802154: 6lowpan: cleanup pull of iphc bytes Alexander Aring
2015-08-12  9:03   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 06/16] ieee802154: 6lowpan: trivial checks at first Alexander Aring
2015-08-12  9:04   ` Stefan Schmidt
2015-08-12  9:21     ` Alexander Aring
2015-08-15  9:15   ` Alexander Aring
2015-08-03  6:23 ` [RFC 07/16] ieee802154: 6lowpan: change skb->dev earlier Alexander Aring
2015-08-12  9:13   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 08/16] ieee802154: 6lowpan: change frag return value handling Alexander Aring
2015-08-12  9:14   ` Stefan Schmidt
2015-08-12  9:26     ` Alexander Aring
2015-08-03  6:23 ` [RFC 09/16] ieee820154: 6lowpan: dispatch evaluation rework Alexander Aring
2015-08-12 12:51   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 10/16] ieee802154: 6lowpan: add dispatch evalualtion helpers Alexander Aring
2015-08-12 12:51   ` Stefan Schmidt
2015-08-12 13:20     ` Alexander Aring
2015-08-12 13:48       ` Stefan Schmidt
2015-08-12 13:55         ` Alexander Aring
2015-08-03  6:23 ` [RFC 11/16] ieee802154: 6lowpan: fix fragmentation dispatch mask Alexander Aring
2015-08-12 12:51   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 12/16] ieee802154: 6lowpan: add generic lowpan header check Alexander Aring
2015-08-12 13:37   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 13/16] ieee802154: 6lowpan: add handler for all dispatch values Alexander Aring
2015-08-12 13:37   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 14/16] ieee802154: 6lowpan: add check for reserved dispatch Alexander Aring
2015-08-12 13:37   ` Stefan Schmidt
2015-08-13 20:17     ` Alexander Aring
2015-08-03  6:23 ` [RFC 15/16] ieee802154: 6lowpan: check on valid 802.15.4 frame Alexander Aring
2015-08-12 13:37   ` Stefan Schmidt
2015-08-12 13:54     ` Alexander Aring
2015-08-03  6:23 ` [RFC 16/16] ieee802154: 6lowpan: remove packet type to host Alexander Aring
2015-08-12 13:37   ` Stefan Schmidt
2015-08-12  8:15 ` Stefan Schmidt [this message]
2015-08-13  9:10   ` [RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation Stefan Schmidt
  -- strict thread matches above, loose matches on Subject: below --
2015-08-02 11:31 Alexander Aring
2015-08-02 11:38 ` Alexander Aring
2015-08-03  6:12   ` Alexander Aring
2015-08-02 11:30 Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CB00B8.8010909@osg.samsung.com \
    --to=stefan@osg.samsung.com \
    --cc=alex.aring@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox