Linux IEEE 802.15.4 and 6LoWPAN development
 help / color / mirror / Atom feed
From: Stefan Schmidt <stefan@osg.samsung.com>
To: Alexander Aring <alex.aring@gmail.com>, linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de
Subject: Re: [RFC 11/16] ieee802154: 6lowpan: fix fragmentation dispatch mask
Date: Wed, 12 Aug 2015 14:51:16 +0200	[thread overview]
Message-ID: <55CB4144.5050102@osg.samsung.com> (raw)
In-Reply-To: <1438583035-6287-12-git-send-email-alex.aring@gmail.com>

Hello.

On 03/08/15 08:23, Alexander Aring wrote:
> This patch fix the dispatch fragmentation masking. With "0xe" we also
> get some reserved dispatch values.
>
> Signed-off-by: Alexander Aring<alex.aring@gmail.com>
> ---
>   net/ieee802154/6lowpan/rx.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/ieee802154/6lowpan/rx.c b/net/ieee802154/6lowpan/rx.c
> index b0066b7..595830f 100644
> --- a/net/ieee802154/6lowpan/rx.c
> +++ b/net/ieee802154/6lowpan/rx.c
> @@ -122,7 +122,8 @@ static lowpan_rx_result lowpan_rx_h_frag(struct sk_buff *skb)
>   	      lowpan_is_fragn(*skb_network_header(skb))))
>   		return RX_CONTINUE;
>   
> -	ret = lowpan_frag_rcv(skb, *skb_network_header(skb) & 0xe0);
> +	ret = lowpan_frag_rcv(skb, *skb_network_header(skb) &
> +			      LOWPAN_DISPATCH_FRAG_MASK);
>   	if (ret == 1)
>   		return RX_CONTINUE;
>   

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>

regards
Stefan Schmidt

  reply	other threads:[~2015-08-12 12:51 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03  6:23 [RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation Alexander Aring
2015-08-03  6:23 ` [RFC 01/16] ieee802154: 6lowpan: change dev vars to wdev and ldev Alexander Aring
2015-08-12  8:49   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 02/16] ieee802154: 6lowpan: remove set to zero Alexander Aring
2015-08-12  8:49   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 03/16] ieee802154: 6lowpan: remove EXPORT_SYMBOL Alexander Aring
2015-08-12  8:49   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 04/16] ieee802154: 6lowpan: remove check on wdev is running Alexander Aring
2015-08-12  8:49   ` Stefan Schmidt
2015-08-15 11:50   ` Alexander Aring
2015-08-03  6:23 ` [RFC 05/16] ieee802154: 6lowpan: cleanup pull of iphc bytes Alexander Aring
2015-08-12  9:03   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 06/16] ieee802154: 6lowpan: trivial checks at first Alexander Aring
2015-08-12  9:04   ` Stefan Schmidt
2015-08-12  9:21     ` Alexander Aring
2015-08-15  9:15   ` Alexander Aring
2015-08-03  6:23 ` [RFC 07/16] ieee802154: 6lowpan: change skb->dev earlier Alexander Aring
2015-08-12  9:13   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 08/16] ieee802154: 6lowpan: change frag return value handling Alexander Aring
2015-08-12  9:14   ` Stefan Schmidt
2015-08-12  9:26     ` Alexander Aring
2015-08-03  6:23 ` [RFC 09/16] ieee820154: 6lowpan: dispatch evaluation rework Alexander Aring
2015-08-12 12:51   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 10/16] ieee802154: 6lowpan: add dispatch evalualtion helpers Alexander Aring
2015-08-12 12:51   ` Stefan Schmidt
2015-08-12 13:20     ` Alexander Aring
2015-08-12 13:48       ` Stefan Schmidt
2015-08-12 13:55         ` Alexander Aring
2015-08-03  6:23 ` [RFC 11/16] ieee802154: 6lowpan: fix fragmentation dispatch mask Alexander Aring
2015-08-12 12:51   ` Stefan Schmidt [this message]
2015-08-03  6:23 ` [RFC 12/16] ieee802154: 6lowpan: add generic lowpan header check Alexander Aring
2015-08-12 13:37   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 13/16] ieee802154: 6lowpan: add handler for all dispatch values Alexander Aring
2015-08-12 13:37   ` Stefan Schmidt
2015-08-03  6:23 ` [RFC 14/16] ieee802154: 6lowpan: add check for reserved dispatch Alexander Aring
2015-08-12 13:37   ` Stefan Schmidt
2015-08-13 20:17     ` Alexander Aring
2015-08-03  6:23 ` [RFC 15/16] ieee802154: 6lowpan: check on valid 802.15.4 frame Alexander Aring
2015-08-12 13:37   ` Stefan Schmidt
2015-08-12 13:54     ` Alexander Aring
2015-08-03  6:23 ` [RFC 16/16] ieee802154: 6lowpan: remove packet type to host Alexander Aring
2015-08-12 13:37   ` Stefan Schmidt
2015-08-12  8:15 ` [RFC 00/16] ieee802154: 6lowpan: cleanup and rework dispatch evaluation Stefan Schmidt
2015-08-13  9:10   ` Stefan Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CB4144.5050102@osg.samsung.com \
    --to=stefan@osg.samsung.com \
    --cc=alex.aring@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox