From: "Darrick J. Wong" <djwong@kernel.org>
To: cem@kernel.org, djwong@kernel.org
Cc: stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 08/12] xfs: actually report corrupt xattrs as XFAIL during cross-referencing
Date: Tue, 22 Sep 2026 23:02:49 -0700 [thread overview]
Message-ID: <179014159713.1875436.4353102591557994166.stgit@frogsfrogsfrogs> (raw)
In-Reply-To: <179014159469.1875436.5857342164999236687.stgit@frogsfrogsfrogs>
From: Darrick J. Wong <djwong@kernel.org>
Some LLM reports that xchk_dir_parent_pointer really ought to report
xattr corruption errors as XFAIL (cross-referencing failed) when a
directory scrub tries to find the parent pointer for a dirent name.
Let's do that.
Cc: <stable@vger.kernel.org> # v6.10
Fixes: 61b3f0df5c2358 ("xfs: check dirents have parent pointers")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
fs/xfs/scrub/dir.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/xfs/scrub/dir.c b/fs/xfs/scrub/dir.c
index 19d974c7e2b7a9..4ab7e646924828 100644
--- a/fs/xfs/scrub/dir.c
+++ b/fs/xfs/scrub/dir.c
@@ -155,6 +155,8 @@ xchk_dir_parent_pointer(
&sd->pptr_args);
if (error == -ENOATTR)
xchk_fblock_xref_set_corrupt(sc, XFS_DATA_FORK, 0);
+ else
+ xchk_fblock_xref_process_error(sc, XFS_DATA_FORK, 0, &error);
return 0;
}
next prev parent reply other threads:[~2026-09-23 6:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 5:57 [PATCHSET 2/2] xfs: LLM-inspired bug fixes, part 17 Darrick J. Wong
2026-09-23 6:01 ` [PATCH 01/12] xfs: compute the correct fdblocks/frextents for repair when they're negative Darrick J. Wong
2026-09-23 6:29 ` Christoph Hellwig
2026-09-23 6:01 ` [PATCH 02/12] xfs: mark cow extents bad if there's no rmap mapping for them Darrick J. Wong
2026-09-24 5:49 ` Christoph Hellwig
2026-09-23 6:01 ` [PATCH 03/12] xfs: clear the symlink zapped flag if inline symlink is ok Darrick J. Wong
2026-09-24 5:49 ` Christoph Hellwig
2026-09-23 6:01 ` [PATCH 04/12] xfs: reinitialize dquot block if non-first dquot can't load Darrick J. Wong
2026-09-24 5:49 ` Christoph Hellwig
2026-09-23 6:02 ` [PATCH 05/12] xfs: fix inode btree repair when a cluster is larger than a chunk Darrick J. Wong
2026-09-24 5:50 ` Christoph Hellwig
2026-09-23 6:02 ` [PATCH 06/12] xfs: fix integer overflow problem when setting large free areas Darrick J. Wong
2026-09-24 5:51 ` Christoph Hellwig
2026-09-24 19:04 ` Darrick J. Wong
2026-09-23 6:02 ` [PATCH 07/12] xfs: fix buffer overflow in corrupt inline attr structure Darrick J. Wong
2026-09-24 5:51 ` Christoph Hellwig
2026-09-23 6:02 ` Darrick J. Wong [this message]
2026-09-24 5:51 ` [PATCH 08/12] xfs: actually report corrupt xattrs as XFAIL during cross-referencing Christoph Hellwig
2026-09-23 6:03 ` [PATCH 09/12] xfs: improve dir block reporting when cross-referencing dirents to pptrs Darrick J. Wong
2026-09-24 5:52 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 10/12] xfs: fix unnecessary dapos truncation in xchk_dir_walk Darrick J. Wong
2026-09-24 5:54 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 11/12] xfs: actually lock the metafile reservation when adjusting after repair Darrick J. Wong
2026-09-24 5:55 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 12/12] xfs: avoid cross-rtgroup reaping after a repair Darrick J. Wong
2026-09-24 5:57 ` Christoph Hellwig
2026-09-24 19:34 ` Darrick J. Wong
2026-10-05 10:05 ` Carlos Maiolino
2026-10-05 14:40 ` Darrick J. Wong
2026-10-05 18:06 ` [PATCHSET 2/2] xfs: LLM-inspired bug fixes, part 17 Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179014159713.1875436.4353102591557994166.stgit@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox