From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 10/12] xfs: fix unnecessary dapos truncation in xchk_dir_walk
Date: Wed, 23 Sep 2026 22:54:38 -0700 [thread overview]
Message-ID: <arS7Ho2yZJ3M6KZG@infradead.org> (raw)
In-Reply-To: <179014159756.1875436.1369162178937848347.stgit@frogsfrogsfrogs>
On Tue, Sep 22, 2026 at 11:03:20PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> LOLLM points out that the all the implementations of xchk_dirent_fn can
> handle a signed @dapos parameter, so the truncation here breaks the
> information captured in scrub tracepoints if the directory is very
> large. I don't think it ever made sense to do the truncation for the
> VFS readdir code for programs that can handle 64-bit offsets, but commit
> 15440319767942 has been around for 17 years without complaints so I'll
> leave that alone.
That code doesn't make sense for various other reasons..
But the Posix definition of seekdir/telldir, to which the offset is tied,
have a hardcoded signed long, not a off_t of some kind, so we can't
really go beyond that. But silently truncating in readdir for this
almost impossible to hit case doesn't make thing better.
Enough ranting, the fix itself looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-09-24 5:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 5:57 [PATCHSET 2/2] xfs: LLM-inspired bug fixes, part 17 Darrick J. Wong
2026-09-23 6:01 ` [PATCH 01/12] xfs: compute the correct fdblocks/frextents for repair when they're negative Darrick J. Wong
2026-09-23 6:29 ` Christoph Hellwig
2026-09-23 6:01 ` [PATCH 02/12] xfs: mark cow extents bad if there's no rmap mapping for them Darrick J. Wong
2026-09-24 5:49 ` Christoph Hellwig
2026-09-23 6:01 ` [PATCH 03/12] xfs: clear the symlink zapped flag if inline symlink is ok Darrick J. Wong
2026-09-24 5:49 ` Christoph Hellwig
2026-09-23 6:01 ` [PATCH 04/12] xfs: reinitialize dquot block if non-first dquot can't load Darrick J. Wong
2026-09-24 5:49 ` Christoph Hellwig
2026-09-23 6:02 ` [PATCH 05/12] xfs: fix inode btree repair when a cluster is larger than a chunk Darrick J. Wong
2026-09-24 5:50 ` Christoph Hellwig
2026-09-23 6:02 ` [PATCH 06/12] xfs: fix integer overflow problem when setting large free areas Darrick J. Wong
2026-09-24 5:51 ` Christoph Hellwig
2026-09-24 19:04 ` Darrick J. Wong
2026-09-23 6:02 ` [PATCH 07/12] xfs: fix buffer overflow in corrupt inline attr structure Darrick J. Wong
2026-09-24 5:51 ` Christoph Hellwig
2026-09-23 6:02 ` [PATCH 08/12] xfs: actually report corrupt xattrs as XFAIL during cross-referencing Darrick J. Wong
2026-09-24 5:51 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 09/12] xfs: improve dir block reporting when cross-referencing dirents to pptrs Darrick J. Wong
2026-09-24 5:52 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 10/12] xfs: fix unnecessary dapos truncation in xchk_dir_walk Darrick J. Wong
2026-09-24 5:54 ` Christoph Hellwig [this message]
2026-09-23 6:03 ` [PATCH 11/12] xfs: actually lock the metafile reservation when adjusting after repair Darrick J. Wong
2026-09-24 5:55 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 12/12] xfs: avoid cross-rtgroup reaping after a repair Darrick J. Wong
2026-09-24 5:57 ` Christoph Hellwig
2026-09-24 19:34 ` Darrick J. Wong
2026-10-05 10:05 ` Carlos Maiolino
2026-10-05 14:40 ` Darrick J. Wong
2026-10-05 18:06 ` [PATCHSET 2/2] xfs: LLM-inspired bug fixes, part 17 Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arS7Ho2yZJ3M6KZG@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox