Re: [PATCH 12/12] xfs: avoid cross-rtgroup reaping after a repair

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Sep 23, 2026 at 10:57:09PM -0700, Christoph Hellwig wrote:
> On Tue, Sep 22, 2026 at 11:03:52PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > LOLLM notices that the extents stored in a xrtb_bitmap (aka xfs_rtblock
> > bitmap) can span multiple rtgroups due to two circumstances.  The first
> > is that the size of an rtgroup is an exact power of two, which means
> > that rtgroups are adjacent in the segmented xfs_rtblock_t address space.
> > This is fairly common to reduce the amount of multiplication and
> > division needed to handle space on the rt volume.
> > 
> > The second is that (unlike in the original rtgroups design), rtgroups do
> > not have fixed-location metadata like AGs do, which means that there's
> > nothing to force a break between rtgroups.
> > 
> > Therefore, we must loop through the rtgroups in xreap_rtmeta_extent to
> > avoid running off the end of an rtgroup while reaping.
> 
> This fix looks good.
> 
> Sashiko complains this could use some additional input sanitization,
> though.

Oh yeah.  If rgbno points into the gap between rtgroups, we should
advance *done to the start of the next rtgroup.

--D