From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: cem@kernel.org, stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 06/12] xfs: fix integer overflow problem when setting large free areas
Date: Thu, 24 Sep 2026 12:04:40 -0700 [thread overview]
Message-ID: <20260924190440.GQ2705364@frogsfrogsfrogs> (raw)
In-Reply-To: <arS6U6GRYEQaSBIZ@infradead.org>
On Wed, Sep 23, 2026 at 10:51:15PM -0700, Christoph Hellwig wrote:
> On Tue, Sep 22, 2026 at 11:02:18PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > LOLLM points out that the min_t comparison in xrep_rtbitmap_mark_free
> > operates on a 64-bit bitmap word offset quantity and a 32-bit
> > words-per-block ratio. Unfortunately, I should have done the comparison
> > with the (64-bit) xrep_wordoff_t type, but used the 32-bit word count
> > type. Oops.
>
> I don't think we'll see rtbitmaps beyond 32-bits in our lifetimes, but
> the fix still looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
I really hope not. You can't create them at all with rtgroups, and that
usecase was horribly broken (and still unfixed) on old kernels. Thanks
for the review!
--D
next prev parent reply other threads:[~2026-09-24 19:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 5:57 [PATCHSET 2/2] xfs: LLM-inspired bug fixes, part 17 Darrick J. Wong
2026-09-23 6:01 ` [PATCH 01/12] xfs: compute the correct fdblocks/frextents for repair when they're negative Darrick J. Wong
2026-09-23 6:29 ` Christoph Hellwig
2026-09-23 6:01 ` [PATCH 02/12] xfs: mark cow extents bad if there's no rmap mapping for them Darrick J. Wong
2026-09-24 5:49 ` Christoph Hellwig
2026-09-23 6:01 ` [PATCH 03/12] xfs: clear the symlink zapped flag if inline symlink is ok Darrick J. Wong
2026-09-24 5:49 ` Christoph Hellwig
2026-09-23 6:01 ` [PATCH 04/12] xfs: reinitialize dquot block if non-first dquot can't load Darrick J. Wong
2026-09-24 5:49 ` Christoph Hellwig
2026-09-23 6:02 ` [PATCH 05/12] xfs: fix inode btree repair when a cluster is larger than a chunk Darrick J. Wong
2026-09-24 5:50 ` Christoph Hellwig
2026-09-23 6:02 ` [PATCH 06/12] xfs: fix integer overflow problem when setting large free areas Darrick J. Wong
2026-09-24 5:51 ` Christoph Hellwig
2026-09-24 19:04 ` Darrick J. Wong [this message]
2026-09-23 6:02 ` [PATCH 07/12] xfs: fix buffer overflow in corrupt inline attr structure Darrick J. Wong
2026-09-24 5:51 ` Christoph Hellwig
2026-09-23 6:02 ` [PATCH 08/12] xfs: actually report corrupt xattrs as XFAIL during cross-referencing Darrick J. Wong
2026-09-24 5:51 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 09/12] xfs: improve dir block reporting when cross-referencing dirents to pptrs Darrick J. Wong
2026-09-24 5:52 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 10/12] xfs: fix unnecessary dapos truncation in xchk_dir_walk Darrick J. Wong
2026-09-24 5:54 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 11/12] xfs: actually lock the metafile reservation when adjusting after repair Darrick J. Wong
2026-09-24 5:55 ` Christoph Hellwig
2026-09-23 6:03 ` [PATCH 12/12] xfs: avoid cross-rtgroup reaping after a repair Darrick J. Wong
2026-09-24 5:57 ` Christoph Hellwig
2026-09-24 19:34 ` Darrick J. Wong
2026-10-05 10:05 ` Carlos Maiolino
2026-10-05 14:40 ` Darrick J. Wong
2026-10-05 18:06 ` [PATCHSET 2/2] xfs: LLM-inspired bug fixes, part 17 Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924190440.GQ2705364@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox