[ANNOUNCE] xfs; for-next branch updated to 31bb236

[ANNOUNCE] xfs; for-next branch updated to 31bb236

[Dave Chinner]

[-- Attachment #1.1: Type: text/plain, Size: 1368 bytes --]

Hi folks,

The for-next branch of the xfs kernel repository at

git://git.kernel.org/pub/scm/linux/kernel/git/dgc/linux-xfs.git

has just been updated.

The new head of the for-next branch is commit:

31bb236 Merge branch 'xfs-misc-fixes-4.6-2' into for-next

New Commits:

Christoph Hellwig (1):
      [a7e5d03] xfs: remove xfs_trans_get_block_res

Colin Ian King (1):
      [5d518bd] xfs: fix format specifier , should be %llx and not %llu

Dave Chinner (1):
      [31bb236] Merge branch 'xfs-misc-fixes-4.6-2' into for-next

Eric Sandeen (3):
      [2e74af0] xfs: convert mount option parsing to tokens
      [a08ee40] xfs: sanitize remount options
      [12c3f05] xfs: fix up inode32/64 (re)mount handling

Mateusz Guzik (1):
      [2e83b79] xfs: fix two memory leaks in xfs_attr_list.c error paths


Code Diffstat:

 fs/xfs/libxfs/xfs_bmap.c       |   6 +-
 fs/xfs/libxfs/xfs_bmap_btree.c |   4 +-
 fs/xfs/xfs_attr_list.c         |  19 +-
 fs/xfs/xfs_discard.c           |   2 +-
 fs/xfs/xfs_mount.c             |  20 +-
 fs/xfs/xfs_mount.h             |   5 +-
 fs/xfs/xfs_super.c             | 525 +++++++++++++++++++++++--------------------
 fs/xfs/xfs_super.h             |   4 +-
 fs/xfs/xfs_trans.h             |   1 -
 9 files changed, 304 insertions(+), 282 deletions(-)
-- 
Dave Chinner
david@fromorbit.com

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [ANNOUNCE] xfs; for-next branch updated to 31bb236

[Christoph Hellwig]

> Mateusz Guzik (1):
>       [2e83b79] xfs: fix two memory leaks in xfs_attr_list.c error paths

This didn't seem to address the comment about using a goto for
error handling?

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [ANNOUNCE] xfs; for-next branch updated to 31bb236

[Dave Chinner]

On Wed, Mar 02, 2016 at 01:45:59AM -0800, Christoph Hellwig wrote:
> > Mateusz Guzik (1):
> >       [2e83b79] xfs: fix two memory leaks in xfs_attr_list.c error paths
> 
> This didn't seem to address the comment about using a goto for
> error handling?

I looked at it, and there isn't a case for a goto. The allocated
memory is in a variable local to the if branch where the leak was
found. Using a jump-based error handling stack means making
all those variables global, and then having to make the freeing
of it conditional. Simply didn't seem worth it to me.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs