From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>
Cc: "Darrick J . Wong" <djwong@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH 16/21] xfs: add data checksum support to zoned garbage collection
Date: Thu, 24 Sep 2026 11:59:48 +0200 [thread overview]
Message-ID: <20260924100032.2733101-17-hch@lst.de> (raw)
In-Reply-To: <20260924100032.2733101-1-hch@lst.de>
Transfer the checksum from the old location to the new one. The
implementation mirrors that of user data reads and writes.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_zone_gc.c | 65 ++++++++++++++++++++++++++++++++++++--------
1 file changed, 53 insertions(+), 12 deletions(-)
diff --git a/fs/xfs/xfs_zone_gc.c b/fs/xfs/xfs_zone_gc.c
index 5fdcf98a2133..1cebd2ee2136 100644
--- a/fs/xfs/xfs_zone_gc.c
+++ b/fs/xfs/xfs_zone_gc.c
@@ -21,6 +21,7 @@
#include "xfs_zone_alloc.h"
#include "xfs_zone_priv.h"
#include "xfs_zones.h"
+#include "xfs_rtcsum.h"
#include "xfs_trace.h"
/*
@@ -106,6 +107,10 @@ struct xfs_gc_bio {
/* Realtime group currently being reclaimed */
struct xfs_rtgroup *victim_rtg;
+ /* Buffer for data checksums */
+ struct xfs_buf *csum_bp;
+ void *csum_buf;
+
/* Bio used for reads and writes, including the bvec used by it */
struct bio bio; /* must be last */
};
@@ -660,6 +665,20 @@ xfs_zone_gc_alloc_blocks(
return true;
}
+static void
+xfs_zone_gc_free_chunk(
+ struct xfs_gc_bio *chunk)
+{
+ atomic_dec(&chunk->victim_rtg->rtg_gccount);
+ xfs_rtgroup_rele(chunk->victim_rtg);
+ list_del(&chunk->entry);
+ xfs_open_zone_put(chunk->oz);
+ if (chunk->csum_bp)
+ xfs_buf_rele(chunk->csum_bp);
+ xfs_irele(chunk->ip);
+ bio_put(&chunk->bio);
+}
+
static void
xfs_zone_gc_add_data(
struct xfs_gc_bio *chunk)
@@ -725,6 +744,11 @@ xfs_zone_gc_start_chunk(
if (!xfs_zone_gc_iter_irec(mp, iter, &irec, &ip))
return false;
+ if (xfs_has_rtcsum(mp)) {
+ irec.rm_blockcount = min(irec.rm_blockcount,
+ xfs_rtcsum_max_len(mp, irec.rm_startblock));
+ }
+
if (!xfs_zone_gc_alloc_blocks(data, &irec.rm_blockcount, &daddr,
&is_seq)) {
xfs_irele(ip);
@@ -748,6 +772,7 @@ xfs_zone_gc_start_chunk(
chunk->data = data;
chunk->oz = data->oz;
chunk->victim_rtg = iter->victim_rtg;
+ chunk->csum_bp = NULL;
atomic_inc(&rtg_group(chunk->victim_rtg)->xg_active_ref);
atomic_inc(&chunk->victim_rtg->rtg_gccount);
@@ -764,22 +789,22 @@ xfs_zone_gc_start_chunk(
list_add_tail(&chunk->entry, &data->reading);
xfs_zone_gc_iter_advance(iter, irec.rm_blockcount);
+ if (xfs_is_rtcsum_inode(ip)) {
+ int error;
+
+ error = xfs_rtcsum_read_async(mp, chunk->old_startblock,
+ &chunk->csum_bp);
+ if (error) {
+ xfs_force_shutdown(mp, SHUTDOWN_META_IO_ERROR);
+ xfs_zone_gc_free_chunk(chunk);
+ return false;
+ }
+ }
+
submit_bio(bio);
return true;
}
-static void
-xfs_zone_gc_free_chunk(
- struct xfs_gc_bio *chunk)
-{
- atomic_dec(&chunk->victim_rtg->rtg_gccount);
- xfs_rtgroup_rele(chunk->victim_rtg);
- list_del(&chunk->entry);
- xfs_open_zone_put(chunk->oz);
- xfs_irele(chunk->ip);
- bio_put(&chunk->bio);
-}
-
static void
xfs_zone_gc_submit_write(
struct xfs_zone_gc_data *data,
@@ -832,6 +857,9 @@ xfs_zone_gc_split_write(
split_chunk->old_startblock = chunk->old_startblock;
split_chunk->new_daddr = chunk->new_daddr;
split_chunk->oz = chunk->oz;
+ split_chunk->csum_bp = chunk->csum_bp;
+ if (split_chunk->csum_bp)
+ xfs_buf_hold(split_chunk->csum_bp);
atomic_inc(&chunk->oz->oz_ref);
split_chunk->victim_rtg = chunk->victim_rtg;
@@ -919,6 +947,19 @@ xfs_zone_gc_finish_chunk(
if (chunk->is_seq)
chunk->new_daddr = chunk->bio.bi_iter.bi_sector;
+
+ if (xfs_is_rtcsum_inode(ip)) {
+ unsigned int boff;
+
+ error = xfs_buf_read_async_wait(chunk->csum_bp);
+ if (error)
+ goto free;
+
+ boff = xfs_rtb_to_rtcsumoff(mp, chunk->old_startblock);
+ error = xfs_rtcsum_log(chunk->oz, chunk->new_daddr, chunk->len,
+ chunk->csum_bp->b_addr + boff);
+ }
+
error = xfs_zoned_end_io(ip, chunk->offset, chunk->len,
chunk->new_daddr, chunk->oz, chunk->old_startblock);
free:
--
2.53.0
next prev parent reply other threads:[~2026-09-24 10:02 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 9:59 support for RT data checksums Christoph Hellwig
2026-09-24 9:59 ` [PATCH 01/21] block: export fs_bio_integrity_verify Christoph Hellwig
2026-09-24 20:29 ` Darrick J. Wong
2026-09-24 9:59 ` [PATCH 02/21] iomap: add support for data checksumming Christoph Hellwig
2026-09-24 21:39 ` Darrick J. Wong
2026-09-25 5:53 ` Christoph Hellwig
2026-09-24 9:59 ` [PATCH 03/21] xfs: add a xfs_buf_read_async buffer cache API Christoph Hellwig
2026-09-24 21:43 ` Darrick J. Wong
2026-09-25 5:54 ` Christoph Hellwig
2026-09-24 9:59 ` [PATCH 04/21] xfs: add xfs_daddr_to_rgno and xfs_daddr_to_rgbno helpers Christoph Hellwig
2026-09-24 21:44 ` Darrick J. Wong
2026-09-24 9:59 ` [PATCH 05/21] xfs: introduce XFS_BLI_PREALLOC Christoph Hellwig
2026-09-24 21:49 ` Darrick J. Wong
2026-09-25 5:57 ` Christoph Hellwig
2026-10-08 11:46 ` Anuj gupta
2026-09-24 9:59 ` [PATCH 06/21] xfs: prepare xfs_rtfile_initialize_blocks for larger than FSB blocks Christoph Hellwig
2026-09-24 22:03 ` Darrick J. Wong
2026-09-25 5:58 ` Christoph Hellwig
2026-09-24 9:59 ` [PATCH 07/21] xfs: relase zi_open_zones_lock over xfs_open_zone_put on unmount Christoph Hellwig
2026-09-24 9:59 ` [PATCH 08/21] xfs: define the RT data checksum on-disk format Christoph Hellwig
2026-09-24 22:13 ` Darrick J. Wong
2026-09-25 0:04 ` Eric Biggers
2026-09-25 6:01 ` Christoph Hellwig
2026-09-24 9:59 ` [PATCH 09/21] xfs: add support for per-RTG csum files Christoph Hellwig
2026-09-24 22:24 ` Darrick J. Wong
2026-09-25 6:10 ` Christoph Hellwig
2026-09-24 9:59 ` [PATCH 10/21] xfs: calculate the log reservation for logging data checksum buffers Christoph Hellwig
2026-09-24 22:30 ` Darrick J. Wong
2026-09-25 6:12 ` Christoph Hellwig
2026-09-24 9:59 ` [PATCH 11/21] xfs: core RT data checksum support Christoph Hellwig
2026-09-25 23:20 ` Darrick J. Wong
2026-09-26 6:13 ` Christoph Hellwig
2026-09-24 9:59 ` [PATCH 12/21] xfs: data checksums require stable writes Christoph Hellwig
2026-09-25 23:21 ` Darrick J. Wong
2026-09-24 9:59 ` [PATCH 13/21] xfs: require file system block size alignment when using data checksums Christoph Hellwig
2026-09-25 23:24 ` Darrick J. Wong
2026-09-26 6:15 ` Christoph Hellwig
2026-09-24 9:59 ` [PATCH 14/21] xfs: add support for reading with " Christoph Hellwig
2026-09-29 0:42 ` Darrick J. Wong
2026-10-05 12:59 ` Christoph Hellwig
2026-09-24 9:59 ` [PATCH 15/21] xfs: add support for writing " Christoph Hellwig
2026-09-29 1:01 ` Darrick J. Wong
2026-10-05 13:00 ` Christoph Hellwig
2026-09-24 9:59 ` Christoph Hellwig [this message]
2026-09-29 1:06 ` [PATCH 16/21] xfs: add data checksum support to zoned garbage collection Darrick J. Wong
2026-10-05 13:11 ` Christoph Hellwig
2026-09-24 9:59 ` [PATCH 17/21] xfs: verify data checksums during media verification Christoph Hellwig
2026-09-29 1:19 ` Darrick J. Wong
2026-10-05 13:13 ` Christoph Hellwig
2026-09-24 9:59 ` [PATCH 18/21] xfs: don't try to verify checksums on empty zones Christoph Hellwig
2026-09-29 1:25 ` Darrick J. Wong
2026-10-05 13:14 ` Christoph Hellwig
2026-10-08 11:43 ` Anuj gupta
2026-09-24 9:59 ` [PATCH 19/21] xfs: report RT data checksum information via XFS_FSOP_GEOM Christoph Hellwig
2026-09-29 1:26 ` Darrick J. Wong
2026-09-24 9:59 ` [PATCH 20/21] xfs: add an experimental feature warning for RT data checksums Christoph Hellwig
2026-09-29 1:27 ` Darrick J. Wong
2026-09-24 9:59 ` [PATCH 21/21] xfs: enable " Christoph Hellwig
2026-09-29 1:27 ` Darrick J. Wong
2026-10-05 13:16 ` Christoph Hellwig
2026-09-24 22:52 ` support for " Dave Chinner
2026-09-25 6:27 ` Christoph Hellwig
2026-09-27 22:59 ` Dave Chinner
2026-09-28 5:24 ` Christoph Hellwig
2026-09-29 14:11 ` Dave Chinner
2026-09-30 7:11 ` Dave Chinner
2026-10-05 13:53 ` Christoph Hellwig
2026-10-06 5:31 ` Dave Chinner
2026-10-07 13:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924100032.2733101-17-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox