Re: [PATCH 04/21] xfs: add xfs_daddr_to_rgno and xfs_daddr_to_rgbno helpers

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Sep 24, 2026 at 11:59:36AM +0200, Christoph Hellwig wrote:
> Translate from a disk address to the realtime group and group-relative
> block numbers.  This will be needed by the data checksumming code.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks fine to me.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/libxfs/xfs_rtgroup.h | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/fs/xfs/libxfs/xfs_rtgroup.h b/fs/xfs/libxfs/xfs_rtgroup.h
> index fca2eb74908c..f26e324f0de3 100644
> --- a/fs/xfs/libxfs/xfs_rtgroup.h
> +++ b/fs/xfs/libxfs/xfs_rtgroup.h
> @@ -390,4 +390,24 @@ xfs_rtgroup_raw_size(
>  	return g->blocks;
>  }
>  
> +static inline xfs_rgnumber_t
> +xfs_daddr_to_rgno(struct xfs_mount *mp, xfs_daddr_t d)
> +{
> +	struct xfs_groups	*g = &mp->m_groups[XG_TYPE_RTG];
> +	xfs_rfsblock_t		rbno = XFS_BB_TO_FSBT(mp, d) - g->start_fsb;
> +
> +	ASSERT(xfs_has_rtgroups(mp));
> +	return div_u64(rbno, xfs_rtgroup_raw_size(mp));
> +}
> +
> +static inline xfs_rgblock_t
> +xfs_daddr_to_rgbno(struct xfs_mount *mp, xfs_daddr_t d)
> +{
> +	struct xfs_groups	*g = &mp->m_groups[XG_TYPE_RTG];
> +	xfs_rfsblock_t		rbno = XFS_BB_TO_FSBT(mp, d) - g->start_fsb;
> +
> +	ASSERT(xfs_has_rtgroups(mp));
> +	return do_div(rbno, xfs_rtgroup_raw_size(mp));
> +}
> +
>  #endif /* __LIBXFS_RTGROUP_H */
> -- 
> 2.53.0
> 
>