LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Bordug <vbordug@ru.mvista.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] CPM_UART: Fix non-console initialisation (v2)
Date: Mon, 13 Nov 2006 11:22:30 +0300	[thread overview]
Message-ID: <20061113112230.4c1af7b0@localhost.localdomain> (raw)
In-Reply-To: <17749.46096.241328.470093@cargo.ozlabs.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

Paul,

patch with proper description inlined.

Thanks,
-Vitaly
---
[POWERPC] CPM_UART: Fixes inconsistency of function definition

From: Kalle Pokki <kalle.pokki@iki.fi>

The below hunk was missed from the recent patch, and now, there are somewhat 
inconsistent definitions:

in cpm_uart.h:
int __init cpm_uart_init_portdesc(void);

in cpm_uart_cpm1.c:
int __init cpm_uart_init_portdesc(void)
{
}

in cpm_uart_cpm2.c:
int cpm_uart_init_portdesc(void)
{
}

Signed-off-by: Kalle Pokki <kalle.pokki@iki.fi>
Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
---

 drivers/serial/cpm_uart/cpm_uart_cpm2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/cpm_uart/cpm_uart_cpm2.c b/drivers/serial/cpm_uart/cpm_uart_cpm2.c
index b691d3e..787a8f1 100644
--- a/drivers/serial/cpm_uart/cpm_uart_cpm2.c
+++ b/drivers/serial/cpm_uart/cpm_uart_cpm2.c
@@ -282,7 +282,7 @@ void cpm_uart_freebuf(struct uart_cpm_po
 }
 
 /* Setup any dynamic params in the uart desc */
-int cpm_uart_init_portdesc(void)
+int __init cpm_uart_init_portdesc(void)
 {
 #if defined(CONFIG_SERIAL_CPM_SMC1) || defined(CONFIG_SERIAL_CPM_SMC2)
 	u32 addr;

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2006-11-13  8:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-01 13:08 [PATCH] CPM_UART: Fix non-console initialisation (v2) Kalle Pokki
2006-11-01 13:47 ` Vitaly Bordug
2006-11-10 10:29 ` Paul Mackerras
2006-11-10 11:45   ` Kalle Pokki
2006-11-10 12:02     ` Kalle Pokki
2006-11-11 11:29       ` Paul Mackerras
2006-11-11 14:15         ` Kalle Pokki
2006-11-13  8:22         ` Vitaly Bordug [this message]
2006-11-13  9:54           ` Paul Mackerras
2006-11-13 11:01             ` Kalle Pokki
2006-11-13 18:45             ` Vitaly Bordug

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061113112230.4c1af7b0@localhost.localdomain \
    --to=vbordug@ru.mvista.com \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox