From: "Kalle Pokki" <kalle.pokki@iki.fi>
To: "Paul Mackerras" <paulus@samba.org>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] CPM_UART: Fix non-console initialisation (v2)
Date: Fri, 10 Nov 2006 13:45:21 +0200 [thread overview]
Message-ID: <a425f86c0611100345h40b104cchdb766e35f1767656@mail.gmail.com> (raw)
In-Reply-To: <17748.21645.621069.105453@cargo.ozlabs.ibm.com>
On 11/10/06, Paul Mackerras <paulus@samba.org> wrote:
>
> The last hunk, i.e. the change to drivers/serial/cpm_uart/cpm_uart_cpm2.c,
> doesn't apply because cpm_uart_init_portdesc now looks different to the
> context in your patch, so I dropped that hunk (it looked to be pretty
> much independent of the other changes).
OK, better drop all the hunks except the one that concerns
drivers/serial/cpm_uart/cpm_uart_core.c then, since I added the same
'__init' lines in cpm_uart.h, cpm_uart_cpm1.c, and cpm_uart_cpm2.c.
> Also, the whitespace is damaged throughout this and your other
> patches. I fixed it up this time, but please fix your mailer not to
> munge the whitespace. Specifically, where a line begins with a space
> character, your mailer removes it if there is nothing else on the
> line, or turns it into two spaces otherwise. :P
I'll fix this. It seems I was sending the patches with pine making them flowed.
next prev parent reply other threads:[~2006-11-10 11:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 13:08 [PATCH] CPM_UART: Fix non-console initialisation (v2) Kalle Pokki
2006-11-01 13:47 ` Vitaly Bordug
2006-11-10 10:29 ` Paul Mackerras
2006-11-10 11:45 ` Kalle Pokki [this message]
2006-11-10 12:02 ` Kalle Pokki
2006-11-11 11:29 ` Paul Mackerras
2006-11-11 14:15 ` Kalle Pokki
2006-11-13 8:22 ` Vitaly Bordug
2006-11-13 9:54 ` Paul Mackerras
2006-11-13 11:01 ` Kalle Pokki
2006-11-13 18:45 ` Vitaly Bordug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a425f86c0611100345h40b104cchdb766e35f1767656@mail.gmail.com \
--to=kalle.pokki@iki.fi \
--cc=linuxppc-embedded@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox