LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Kalle Pokki" <kalle.pokki@iki.fi>
To: "Paul Mackerras" <paulus@samba.org>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] CPM_UART: Fix non-console initialisation (v2)
Date: Sat, 11 Nov 2006 16:15:19 +0200	[thread overview]
Message-ID: <a425f86c0611110615r5b5d1daeydd6007a657548f96@mail.gmail.com> (raw)
In-Reply-To: <17749.46096.241328.470093@cargo.ozlabs.ibm.com>

On 11/11/06, Paul Mackerras <paulus@samba.org> wrote:
> Kalle Pokki writes:
>
> > Hmm, it seems you already pushed the changes. This should apply to the
> > current 'merge' branch.
>
> That on its own is hard to justify as a bug fix, isn't it?

Sure, but since you removed the last hunk of the patch that became
0091cf5a6ae6e52fc95ceb53200975ef2c81c206, we now have a little
inconsistent definitions:

in cpm_uart.h
int __init cpm_uart_init_portdesc(void);

in cpm_uart_cpm1.c
int __init cpm_uart_init_portdesc(void)
{
}

in cpm_uart_cpm2.c
int cpm_uart_init_portdesc(void)
{
}

  reply	other threads:[~2006-11-11 14:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-01 13:08 [PATCH] CPM_UART: Fix non-console initialisation (v2) Kalle Pokki
2006-11-01 13:47 ` Vitaly Bordug
2006-11-10 10:29 ` Paul Mackerras
2006-11-10 11:45   ` Kalle Pokki
2006-11-10 12:02     ` Kalle Pokki
2006-11-11 11:29       ` Paul Mackerras
2006-11-11 14:15         ` Kalle Pokki [this message]
2006-11-13  8:22         ` Vitaly Bordug
2006-11-13  9:54           ` Paul Mackerras
2006-11-13 11:01             ` Kalle Pokki
2006-11-13 18:45             ` Vitaly Bordug

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a425f86c0611110615r5b5d1daeydd6007a657548f96@mail.gmail.com \
    --to=kalle.pokki@iki.fi \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox