[PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Georg Gottleuber]

Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
Snapdragon X Elite SoC (X1E78100).

Changes in v3:
- add DisplayPort audio to dts
- add el2.dtb to Makefile
- change dts firmware paths
- fix dt-binding (x1e78100 instead of x1e80100)
- improve commit message for elite14gen1 dt-bindings
- remove smb2360_1 from dts (only one USB-C port is present)
- remove "VA MIC BIAS1" from dts
- remove regulator-always-on from vreg_edp_3p3 (display) in dts
- rename vendor prefix of ASL Xiamen Technology to asl-tek
- sort dts

Changes in v2:
- Rebase to v6.18-rc4/master
- Add support for accelerated video decoding
- Add support for audio (speakers, microphones, headset)
- Add support for Bluetooth
- Add support for camera
- Add support for fingerprint reader
- Add support for HDMI-A port
- Add support for QSEECOM
- Add support for USB Type-A
- Add support for USB-C DP altmode
- Add ASL Xiamen Technology Co. Ltd. vendor prefix
- Add TUXEDO vendor prefix
- Add cover letter
- Removal of pointless comments
- Coding style fixes
- Spell check

The device tree uses the dtschema from Linaro DisplayPort PHY patch [1].
ALSA UCM and Audioreach topology patches are available at [2] and [3].
The fingerprint reader requires USB IDs to be patched into libfprint.
WiFi requires a firmware patch [4].

Announcement and request for comments:
Because the SoC is now outdated and some functions still do not work as
well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1
will not be offered for sale. We would still like to submit our device
tree to the mainline kernel and thus contribute to Linux support for a
compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in
Germany, this device was sold in many large stores. (An official press
statement will follow on our website.)

Do you think it would make sense to implement this in a similar way to the
X1E ThinkPad T14s and Thinkpad T14s OLED (with a common dtsi)?

[1]: https://lore.kernel.org/all/20251006-topic-x1e80100-hdmi-v5-1-c006311d59d7@linaro.org/
[2]: https://github.com/ektor5/alsa-ucm-conf/tree/x1e80100-tuxedo-dp
[3]: https://github.com/ektor5/audioreach-topology/tree/tuxedo-display-port
[4]: https://lore.kernel.org/linux-wireless/59ed6306-28f8-478e-90fe-4a1b73ae3051@tuxedocomputers.com/

Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>

Ettore Chimenti (4):
  dt-bindings: vendor-prefixes: Add ASL Xiamen Technology
  dt-bindings: display: bridge: simple: document the ASL CS5263
    DP-to-HDMI bridge
  drm/bridge: simple: add ASL CS5263 DP-to-HDMI bridge
  firmware: qcom: scm: Allow QSEECOM on Tuxedo Elite 14 Gen1

Georg Gottleuber (3):
  dt-bindings: vendor-prefixes: Add prefix for TUXEDO Computers GmbH
  dt-bindings: arm: qcom: Add TUXEDO Computers device
  arm64: dts: qcom: Add device tree for TUXEDO Elite 14 Gen1

 .../devicetree/bindings/arm/qcom.yaml         |    6 +
 .../display/bridge/simple-bridge.yaml         |    1 +
 .../devicetree/bindings/vendor-prefixes.yaml  |    4 +
 arch/arm64/boot/dts/qcom/Makefile             |    2 +
 .../qcom/x1e80100-tuxedo-elite-14-gen1.dts    | 1515 +++++++++++++++++
 drivers/firmware/qcom/qcom_scm.c              |    1 +
 drivers/gpu/drm/bridge/simple-bridge.c        |    5 +
 7 files changed, 1534 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-tuxedo-elite-14-gen1.dts

-- 
2.43.0

[PATCH v3 1/7] dt-bindings: vendor-prefixes: Add ASL Xiamen Technology

[Georg Gottleuber]

From: Ettore Chimenti <ettore.chimenti@linaro.org>

ASL Xiamen Technology Co. Ltd. is a Chinese high-speed interface and
display system chip design company. Adding it to the vendor prefixes.

Link: https://www.asl-tek.com/

Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index f1d1882009ba..82bb5c25cd0f 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -176,6 +176,8 @@ patternProperties:
     description: All Sensors Corporation
   "^asix,.*":
     description: ASIX Electronics Corporation
+  "^asl-tek,.*":
+    description: ASL Xiamen Technology Co., Ltd.
   "^aspeed,.*":
     description: ASPEED Technology Inc.
   "^asrock,.*":
-- 
2.43.0

[PATCH v3 2/7] dt-bindings: display: bridge: simple: document the ASL CS5263 DP-to-HDMI bridge

[Georg Gottleuber]

From: Ettore Chimenti <ettore.chimenti@linaro.org>

The ASL CS5263 is a high-performance DP1.4 to HDMI2.0b converter,
designed to connect a DP1.4 source to an HDMI2.0b sink. The CS5263AN
integrates a DP1.4 compliant receiver, and a HDMI2.0b compliant
transmitter.

Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
---
 .../devicetree/bindings/display/bridge/simple-bridge.yaml        | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
index 9ef587d46506..3439c1da4d3a 100644
--- a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
@@ -27,6 +27,7 @@ properties:
           - const: adi,adv7123
       - enum:
           - adi,adv7123
+          - asl-tek,cs5263
           - dumb-vga-dac
           - radxa,ra620
           - realtek,rtd2171
-- 
2.43.0

[PATCH v3 3/7] drm/bridge: simple: add ASL CS5263 DP-to-HDMI bridge

[Georg Gottleuber]

From: Ettore Chimenti <ettore.chimenti@linaro.org>

Add support for the transparent ASL CS5263 DP-to-HDMI bridge.

Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
---
 drivers/gpu/drm/bridge/simple-bridge.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
index e4d0bc2200f8..94aba5a9c9b9 100644
--- a/drivers/gpu/drm/bridge/simple-bridge.c
+++ b/drivers/gpu/drm/bridge/simple-bridge.c
@@ -261,6 +261,11 @@ static const struct of_device_id simple_bridge_match[] = {
 			.timings = &default_bridge_timings,
 			.connector_type = DRM_MODE_CONNECTOR_VGA,
 		},
+	}, {
+		.compatible = "asl-tek,cs5263",
+		.data = &(const struct simple_bridge_info) {
+			.connector_type = DRM_MODE_CONNECTOR_HDMIA,
+		},
 	}, {
 		.compatible = "radxa,ra620",
 		.data = &(const struct simple_bridge_info) {
-- 
2.43.0

[PATCH v3 4/7] dt-bindings: vendor-prefixes: Add prefix for TUXEDO Computers GmbH

[Georg Gottleuber]

TUXEDO Computers GmbH is a German supplier for computers.

Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 82bb5c25cd0f..4e2066007746 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1677,6 +1677,8 @@ patternProperties:
     description: Theobroma Systems Design und Consulting GmbH
   "^turing,.*":
     description: Turing Machines, Inc.
+  "^tuxedo,.*":
+    description: TUXEDO Computers GmbH
   "^tyan,.*":
     description: Tyan Computer Corporation
   "^tyhx,.*":
-- 
2.43.0

[PATCH v3 5/7] dt-bindings: arm: qcom: Add TUXEDO Computers device

[Georg Gottleuber]

Introduce new binding for the TUXEDO Elite 14 Gen1 laptop with X1E78100
SoC.

Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 18b5ed044f9f..f77dcc379494 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1059,6 +1059,12 @@ properties:
           - const: qcom,x1e78100
           - const: qcom,x1e80100
 
+      - items:
+          - enum:
+              - tuxedo,elite14gen1
+          - const: qcom,x1e78100
+          - const: qcom,x1e80100
+
       - items:
           - enum:
               - asus,vivobook-s15
-- 
2.43.0

[PATCH v3 6/7] arm64: dts: qcom: Add device tree for TUXEDO Elite 14 Gen1

[Georg Gottleuber]

Initial support for TUXEDO Elite 14 Gen1 based on Qualcomm Snapdragon X
Elite SoC (X1E78100).

Working:
* Touchpad
* Keyboard
* eDP (no brightness control yet)
* NVMe
* USB Type-C port
* USB-C DP altmode
* HDMI-A port
* WiFi (WiFi 7 untested)
* Bluetooth
* GPU
* Video decoding
* USB Type-A
* Audio, speakers, microphones
	- 4x speakers.
	- 2x dmic
	- headset
* Camera
* Fingerprint reader

Co-developed-by: Srinivas Kandagatla <srini@kernel.org>
Signed-off-by: Srinivas Kandagatla <srini@kernel.org>
Co-developed-by: Ettore Chimenti <ettore.chimenti@linaro.org>
Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
---
 arch/arm64/boot/dts/qcom/Makefile             |    2 +
 .../qcom/x1e80100-tuxedo-elite-14-gen1.dts    | 1515 +++++++++++++++++
 2 files changed, 1517 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-tuxedo-elite-14-gen1.dts

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 296688f7cb26..a15d8efcc24c 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -342,6 +342,8 @@ x1e80100-microsoft-romulus15-el2-dtbs	:= x1e80100-microsoft-romulus15.dtb x1-el2
 dtb-$(CONFIG_ARCH_QCOM)	+= x1e80100-microsoft-romulus15.dtb x1e80100-microsoft-romulus15-el2.dtb
 x1e80100-qcp-el2-dtbs	:= x1e80100-qcp.dtb x1-el2.dtbo
 dtb-$(CONFIG_ARCH_QCOM)	+= x1e80100-qcp.dtb x1e80100-qcp-el2.dtb
+x1e80100-tuxedo-elite-14-gen1-el2-dtbs	:=  x1e80100-tuxedo-elite-14-gen1.dtb x1-el2.dtbo
+dtb-$(CONFIG_ARCH_QCOM)	+= x1e80100-tuxedo-elite-14-gen1.dtb x1e80100-tuxedo-elite-14-gen1-el2.dtb
 x1p42100-asus-zenbook-a14-el2-dtbs	:= x1p42100-asus-zenbook-a14.dtb x1-el2.dtbo
 dtb-$(CONFIG_ARCH_QCOM)	+= x1p42100-asus-zenbook-a14.dtb x1p42100-asus-zenbook-a14-el2.dtb
 x1p42100-crd-el2-dtbs	:= x1p42100-crd.dtb x1-el2.dtbo
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-tuxedo-elite-14-gen1.dts b/arch/arm64/boot/dts/qcom/x1e80100-tuxedo-elite-14-gen1.dts
new file mode 100644
index 000000000000..0aa952c355cc
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/x1e80100-tuxedo-elite-14-gen1.dts
@@ -0,0 +1,1515 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2025 TUXEDO Computers GmbH
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+#include "x1e80100.dtsi"
+#include "x1e80100-pmics.dtsi"
+
+/ {
+	model = "TUXEDO Elite 14 Gen1";
+	compatible = "tuxedo,elite14gen1", "qcom,x1e78100", "qcom,x1e80100";
+
+	aliases {
+		serial0 = &uart21;
+		serial1 = &uart14;
+	};
+
+	wcd938x: audio-codec {
+		compatible = "qcom,wcd9385-codec";
+
+		pinctrl-0 = <&wcd_default>;
+		pinctrl-names = "default";
+
+		qcom,micbias1-microvolt = <1800000>;
+		qcom,micbias2-microvolt = <1800000>;
+		qcom,micbias3-microvolt = <1800000>;
+		qcom,micbias4-microvolt = <1800000>;
+		qcom,mbhc-buttons-vthreshold-microvolt = <75000 150000 237000 500000 500000 500000 500000 500000>;
+		qcom,mbhc-headset-vthreshold-microvolt = <1700000>;
+		qcom,mbhc-headphone-vthreshold-microvolt = <50000>;
+		qcom,rx-device = <&wcd_rx>;
+		qcom,tx-device = <&wcd_tx>;
+
+		reset-gpios = <&tlmm 191 GPIO_ACTIVE_LOW>;
+
+		vdd-buck-supply = <&vreg_l15b_1p8>;
+		vdd-rxtx-supply = <&vreg_l15b_1p8>;
+		vdd-io-supply = <&vreg_l15b_1p8>;
+		vdd-mic-bias-supply = <&vreg_bob1>;
+
+		#sound-dai-cells = <1>;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+
+		pinctrl-0 = <&hall_int_n_default>;
+		pinctrl-names = "default";
+
+		switch-lid {
+			gpios = <&tlmm 92 GPIO_ACTIVE_LOW>;
+			linux,input-type = <EV_SW>;
+			linux,code = <SW_LID>;
+			wakeup-source;
+		};
+	};
+
+	hdmi-bridge {
+		compatible = "asl-tek,cs5263";
+
+		pinctrl-0 = <&hdmi_hpd_default>;
+		pinctrl-names = "default";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+
+				hdmi_bridge_dp_in: endpoint {
+					remote-endpoint = <&usb_1_ss2_qmpphy_out_dp>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+
+				hdmi_bridge_tmds_out: endpoint {
+					remote-endpoint = <&hdmi_con>;
+				};
+			};
+		};
+	};
+
+	hdmi-connector {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con: endpoint {
+				remote-endpoint = <&hdmi_bridge_tmds_out>;
+			};
+		};
+	};
+
+	pmic-glink {
+		compatible = "qcom,x1e80100-pmic-glink",
+			     "qcom,sm8550-pmic-glink",
+			     "qcom,pmic-glink";
+		orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		connector@0 {
+			compatible = "usb-c-connector";
+			reg = <0>;
+			power-role = "dual";
+			data-role = "dual";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+
+					pmic_glink_ss0_hs_in: endpoint {
+						remote-endpoint = <&usb_1_ss0_dwc3_hs>;
+					};
+				};
+
+				port@1 {
+					reg = <1>;
+
+					pmic_glink_ss0_ss_in: endpoint {
+						remote-endpoint = <&retimer_ss0_ss_out>;
+					};
+				};
+				port@2 {
+					reg = <2>;
+
+					pmic_glink_ss0_con_sbu_in: endpoint {
+						remote-endpoint = <&retimer_ss0_con_sbu_out>;
+					};
+				};
+			};
+		};
+	};
+
+	vreg_edp_3p3: regulator-edp-3p3 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_EDP_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&tlmm 54 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&edp_reg_en>;
+		pinctrl-names = "default";
+
+		regulator-boot-on;
+	};
+
+	vreg_nvme: regulator-nvme {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_NVME_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&tlmm 18 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&nvme_reg_en>;
+		pinctrl-names = "default";
+		regulator-boot-on;
+	};
+
+	vreg_rtmr0_1p15: regulator-rtmr0-1p15 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_RTMR0_1P15";
+		regulator-min-microvolt = <1150000>;
+		regulator-max-microvolt = <1150000>;
+
+		gpio = <&pmc8380_5_gpios 8 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&usb0_pwr_1p15_reg_en>;
+		pinctrl-names = "default";
+
+		regulator-boot-on;
+	};
+
+	vreg_rtmr0_1p8: regulator-rtmr0-1p8 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_RTMR0_1P8";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+
+		gpio = <&pm8550ve_9_gpios 8 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&usb0_1p8_reg_en>;
+		pinctrl-names = "default";
+
+		regulator-boot-on;
+	};
+
+	vreg_rtmr0_3p3: regulator-rtmr0-3p3 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_RTMR0_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&pm8550_gpios 11 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&usb0_3p3_reg_en>;
+		pinctrl-names = "default";
+
+		regulator-boot-on;
+	};
+
+	vph_pwr: regulator-vph-pwr {
+		compatible = "regulator-fixed";
+
+		regulator-name = "vph_pwr";
+		regulator-min-microvolt = <3700000>;
+		regulator-max-microvolt = <3700000>;
+
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
+	/*
+	 * TODO: These two regulators are actually part of the removable M.2
+	 * card and not the mainboard. Need to describe this differently.
+	 * Functionally it works correctly, because all we need to do is to
+	 * turn on the actual 3.3V supply above.
+	 */
+	vreg_wcn_0p95: regulator-wcn-0p95 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_WCN_0P95";
+		regulator-min-microvolt = <950000>;
+		regulator-max-microvolt = <950000>;
+
+		vin-supply = <&vreg_wcn_3p3>;
+	};
+
+	vreg_wcn_1p9: regulator-wcn-1p9 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_WCN_1P9";
+		regulator-min-microvolt = <1900000>;
+		regulator-max-microvolt = <1900000>;
+
+		vin-supply = <&vreg_wcn_3p3>;
+	};
+
+	vreg_wcn_3p3: regulator-wcn-3p3 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_WCN_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&tlmm 214 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&wcn_sw_en>;
+		pinctrl-names = "default";
+
+		regulator-boot-on;
+	};
+
+	reserved-memory {
+		linux,cma {
+			compatible = "shared-dma-pool";
+			size = <0x0 0x8000000>;
+			reusable;
+			linux,cma-default;
+		};
+	};
+
+	sound {
+		compatible = "qcom,x1e80100-sndcard";
+		model = "X1E80100-TUXEDO-Elite-14";
+		audio-routing = "WooferLeft IN", "WSA WSA_SPK1 OUT",
+				"TweeterLeft IN", "WSA WSA_SPK2 OUT",
+				"WooferRight IN", "WSA2 WSA_SPK2 OUT",
+				"TweeterRight IN", "WSA2 WSA_SPK2 OUT",
+				"IN1_HPHL", "HPHL_OUT",
+				"IN2_HPHR", "HPHR_OUT",
+				"AMIC2", "MIC BIAS2",
+				"VA DMIC0", "MIC BIAS1",
+				"VA DMIC1", "MIC BIAS1",
+				"TX SWR_INPUT1", "ADC2_OUTPUT";
+
+		displayport-0-dai-link {
+			link-name = "DisplayPort0 Playback";
+
+			codec {
+				sound-dai = <&mdss_dp0>;
+			};
+
+			cpu {
+				sound-dai = <&q6apmbedai DISPLAY_PORT_RX_0>;
+			};
+
+			platform {
+				sound-dai = <&q6apm>;
+			};
+		};
+
+		displayport-2-dai-link {
+			link-name = "DisplayPort2 Playback";
+
+			codec {
+				sound-dai = <&mdss_dp2>;
+			};
+
+			cpu {
+				sound-dai = <&q6apmbedai DISPLAY_PORT_RX_2>;
+			};
+
+			platform {
+				sound-dai = <&q6apm>;
+			};
+		};
+
+		va-dai-link {
+			link-name = "VA Capture";
+
+			codec {
+				sound-dai = <&lpass_vamacro 0>;
+			};
+
+			cpu {
+				sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>;
+			};
+
+			platform {
+				sound-dai = <&q6apm>;
+			};
+		};
+
+		wcd-capture-dai-link {
+			link-name = "WCD Capture";
+
+			codec {
+				sound-dai = <&wcd938x 1>, <&swr2 1>, <&lpass_txmacro 0>;
+			};
+
+			cpu {
+				sound-dai = <&q6apmbedai TX_CODEC_DMA_TX_3>;
+			};
+
+			platform {
+				sound-dai = <&q6apm>;
+			};
+		};
+
+		wcd-playback-dai-link {
+			link-name = "WCD Playback";
+
+			codec {
+				sound-dai = <&wcd938x 0>, <&swr1 0>, <&lpass_rxmacro 0>;
+			};
+
+			cpu {
+				sound-dai = <&q6apmbedai RX_CODEC_DMA_RX_0>;
+			};
+
+			platform {
+				sound-dai = <&q6apm>;
+			};
+		};
+
+		wsa-dai-link {
+			link-name = "WSA Playback";
+
+			codec {
+				sound-dai = <&left_woofer>, <&left_tweeter>,
+					    <&swr0 0>, <&lpass_wsamacro 0>,
+					    <&right_woofer>, <&right_tweeter>,
+					    <&swr3 0>, <&lpass_wsa2macro 0>;
+			};
+
+			cpu {
+				sound-dai = <&q6apmbedai WSA_CODEC_DMA_RX_0>;
+			};
+
+			platform {
+				sound-dai = <&q6apm>;
+			};
+		};
+	};
+
+	wcn7850-pmu {
+		compatible = "qcom,wcn7850-pmu";
+
+		vdd-supply = <&vreg_wcn_0p95>;
+		vddio-supply = <&vreg_l15b_1p8>;
+		vddaon-supply = <&vreg_wcn_0p95>;
+		vdddig-supply = <&vreg_wcn_0p95>;
+		vddrfa1p2-supply = <&vreg_wcn_1p9>;
+		vddrfa1p8-supply = <&vreg_wcn_1p9>;
+
+		wlan-enable-gpios = <&tlmm 117 GPIO_ACTIVE_HIGH>;
+		bt-enable-gpios = <&tlmm 116 GPIO_ACTIVE_HIGH>;
+
+		pinctrl-0 = <&wcn_wlan_bt_en>;
+		pinctrl-names = "default";
+
+		regulators {
+			vreg_pmu_rfa_cmn: ldo0 {
+				regulator-name = "vreg_pmu_rfa_cmn";
+			};
+
+			vreg_pmu_aon_0p59: ldo1 {
+				regulator-name = "vreg_pmu_aon_0p59";
+			};
+
+			vreg_pmu_wlcx_0p8: ldo2 {
+				regulator-name = "vreg_pmu_wlcx_0p8";
+			};
+
+			vreg_pmu_wlmx_0p85: ldo3 {
+				regulator-name = "vreg_pmu_wlmx_0p85";
+			};
+
+			vreg_pmu_btcmx_0p85: ldo4 {
+				regulator-name = "vreg_pmu_btcmx_0p85";
+			};
+
+			vreg_pmu_rfa_0p8: ldo5 {
+				regulator-name = "vreg_pmu_rfa_0p8";
+			};
+
+			vreg_pmu_rfa_1p2: ldo6 {
+				regulator-name = "vreg_pmu_rfa_1p2";
+			};
+
+			vreg_pmu_rfa_1p8: ldo7 {
+				regulator-name = "vreg_pmu_rfa_1p8";
+			};
+
+			vreg_pmu_pcie_0p9: ldo8 {
+				regulator-name = "vreg_pmu_pcie_0p9";
+			};
+
+			vreg_pmu_pcie_1p8: ldo9 {
+				regulator-name = "vreg_pmu_pcie_1p8";
+			};
+		};
+	};
+};
+
+&apps_rsc {
+	regulators-0 {
+		compatible = "qcom,pm8550-rpmh-regulators";
+		qcom,pmic-id = "b";
+		vdd-bob1-supply = <&vph_pwr>;
+		vdd-bob2-supply = <&vph_pwr>;
+		vdd-l1-l4-l10-supply = <&vreg_s4c_1p8>;
+		vdd-l2-l13-l14-supply = <&vreg_bob1>;
+		vdd-l5-l16-supply = <&vreg_bob1>;
+		vdd-l6-l7-supply = <&vreg_bob2>;
+		vdd-l8-l9-supply = <&vreg_bob1>;
+		vdd-l12-supply = <&vreg_s5j_1p2>;
+		vdd-l15-supply = <&vreg_s4c_1p8>;
+		vdd-l17-supply = <&vreg_bob2>;
+
+		vreg_bob1: bob1 {
+			regulator-name = "vreg_bob1";
+			regulator-min-microvolt = <3008000>;
+			regulator-max-microvolt = <3960000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_bob2: bob2 {
+			regulator-name = "vreg_bob2";
+			regulator-min-microvolt = <2504000>;
+			regulator-max-microvolt = <3008000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l1b_1p8: ldo1 {
+			regulator-name = "vreg_l1b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2b_3p0: ldo2 {
+			regulator-name = "vreg_l2b_3p0";
+			regulator-min-microvolt = <3072000>;
+			regulator-max-microvolt = <3072000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l4b_1p8: ldo4 {
+			regulator-name = "vreg_l4b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l6b_1p8: ldo6 {
+			regulator-name = "vreg_l6b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <2960000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l7b_2p8: ldo7 {
+			regulator-name = "vreg_l7b_2p8";
+			regulator-min-microvolt = <2800000>;
+			regulator-max-microvolt = <2800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l8b_3p0: ldo8 {
+			regulator-name = "vreg_l8b_3p0";
+			regulator-min-microvolt = <3072000>;
+			regulator-max-microvolt = <3072000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l9b_2p9: ldo9 {
+			regulator-name = "vreg_l9b_2p9";
+			regulator-min-microvolt = <2960000>;
+			regulator-max-microvolt = <2960000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l10b_1p8: ldo10 {
+			regulator-name = "vreg_l10b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l12b_1p2: ldo12 {
+			regulator-name = "vreg_l12b_1p2";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l13b_3p0: ldo13 {
+			regulator-name = "vreg_l13b_3p0";
+			regulator-min-microvolt = <3072000>;
+			regulator-max-microvolt = <3072000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l14b_3p0: ldo14 {
+			regulator-name = "vreg_l14b_3p0";
+			regulator-min-microvolt = <3072000>;
+			regulator-max-microvolt = <3072000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l15b_1p8: ldo15 {
+			regulator-name = "vreg_l15b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l16b_2p8: ldo16 {
+			regulator-name = "vreg_l16b_2p8";
+			regulator-min-microvolt = <2800000>;
+			regulator-max-microvolt = <2800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l17b_2p5: ldo17 {
+			regulator-name = "vreg_l17b_2p5";
+			regulator-min-microvolt = <2504000>;
+			regulator-max-microvolt = <2504000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	regulators-1 {
+		compatible = "qcom,pm8550ve-rpmh-regulators";
+		qcom,pmic-id = "c";
+
+		vdd-l1-supply = <&vreg_s5j_1p2>;
+		vdd-l2-supply = <&vreg_s1f_0p7>;
+		vdd-l3-supply = <&vreg_s1f_0p7>;
+		vdd-s4-supply = <&vph_pwr>;
+
+		vreg_l1c_1p2: ldo1 {
+			regulator-name = "vreg_l1c_1p2";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2c_0p8: ldo2 {
+			regulator-name = "vreg_l2c_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <880000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3c_0p9: ldo3 {
+			regulator-name = "vreg_l3c_0p9";
+			regulator-min-microvolt = <920000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_s4c_1p8: smps4 {
+			regulator-name = "vreg_s4c_1p8";
+			regulator-min-microvolt = <1856000>;
+			regulator-max-microvolt = <2000000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	regulators-2 {
+		compatible = "qcom,pmc8380-rpmh-regulators";
+		qcom,pmic-id = "d";
+
+		vdd-l1-supply = <&vreg_s1f_0p7>;
+		vdd-l2-supply = <&vreg_s1f_0p7>;
+		vdd-l3-supply = <&vreg_s4c_1p8>;
+		vdd-s1-supply = <&vph_pwr>;
+
+		vreg_l1d_0p8: ldo1 {
+			regulator-name = "vreg_l1d_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <880000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2d_0p9: ldo2 {
+			regulator-name = "vreg_l2d_0p9";
+			regulator-min-microvolt = <912000>;
+			regulator-max-microvolt = <912000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3d_1p8: ldo3 {
+			regulator-name = "vreg_l3d_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	regulators-3 {
+		compatible = "qcom,pmc8380-rpmh-regulators";
+		qcom,pmic-id = "e";
+
+		vdd-l2-supply = <&vreg_s1f_0p7>;
+		vdd-l3-supply = <&vreg_s5j_1p2>;
+
+		vreg_l2e_0p8: ldo2 {
+			regulator-name = "vreg_l2e_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <880000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3e_1p2: ldo3 {
+			regulator-name = "vreg_l3e_1p2";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	regulators-4 {
+		compatible = "qcom,pmc8380-rpmh-regulators";
+		qcom,pmic-id = "f";
+
+		vdd-l1-supply = <&vreg_s5j_1p2>;
+		vdd-l2-supply = <&vreg_s5j_1p2>;
+		vdd-l3-supply = <&vreg_s5j_1p2>;
+		vdd-s1-supply = <&vph_pwr>;
+
+		vreg_s1f_0p7: smps1 {
+			regulator-name = "vreg_s1f_0p7";
+			regulator-min-microvolt = <700000>;
+			regulator-max-microvolt = <1100000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	regulators-6 {
+		compatible = "qcom,pm8550ve-rpmh-regulators";
+		qcom,pmic-id = "i";
+
+		vdd-l1-supply = <&vreg_s4c_1p8>;
+		vdd-l2-supply = <&vreg_s5j_1p2>;
+		vdd-l3-supply = <&vreg_s1f_0p7>;
+		vdd-s1-supply = <&vph_pwr>;
+		vdd-s2-supply = <&vph_pwr>;
+
+		vreg_l1i_1p8: ldo1 {
+			regulator-name = "vreg_l1i_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2i_1p2: ldo2 {
+			regulator-name = "vreg_l2i_1p2";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3i_0p8: ldo3 {
+			regulator-name = "vreg_l3i_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <880000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_s1i_0p9: smps1 {
+			regulator-name = "vreg_s1i_0p9";
+			regulator-min-microvolt = <900000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_s2i_1p0: smps2 {
+			regulator-name = "vreg_s2i_1p0";
+			regulator-min-microvolt = <1000000>;
+			regulator-max-microvolt = <1100000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	regulators-7 {
+		compatible = "qcom,pm8550ve-rpmh-regulators";
+		qcom,pmic-id = "j";
+
+		vdd-l1-supply = <&vreg_s1f_0p7>;
+		vdd-l2-supply = <&vreg_s5j_1p2>;
+		vdd-l3-supply = <&vreg_s1f_0p7>;
+		vdd-s5-supply = <&vph_pwr>;
+
+		vreg_l1j_0p9: ldo1 {
+			regulator-name = "vreg_l1j_0p9";
+			regulator-min-microvolt = <912000>;
+			regulator-max-microvolt = <912000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2j_1p2: ldo2 {
+			regulator-name = "vreg_l2j_1p2";
+			regulator-min-microvolt = <1256000>;
+			regulator-max-microvolt = <1256000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3j_0p8: ldo3 {
+			regulator-name = "vreg_l3j_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <880000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_s5j_1p2: smps5 {
+			regulator-name = "vreg_s5j_1p2";
+			regulator-min-microvolt = <1256000>;
+			regulator-max-microvolt = <1304000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+};
+
+&gpu {
+	status = "okay";
+
+	zap-shader {
+		firmware-name = "qcom/x1e80100/TUXEDO/qcdxkmsuc8380.mbn";
+	};
+};
+
+&i2c0 {
+	clock-frequency = <400000>;
+
+	status = "okay";
+
+	touchpad@2c {
+		compatible = "hid-over-i2c";
+		reg = <0x2c>;
+
+		hid-descr-addr = <0x20>;
+		interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>;
+
+		pinctrl-0 = <&tpad_default>;
+		pinctrl-names = "default";
+
+		wakeup-source;
+	};
+
+	keyboard@3a {
+		compatible = "hid-over-i2c";
+		reg = <0x3a>;
+
+		hid-descr-addr = <0x1>;
+		interrupts-extended = <&tlmm 67 IRQ_TYPE_LEVEL_LOW>;
+
+		pinctrl-0 = <&kybd_default>;
+		pinctrl-names = "default";
+
+		wakeup-source;
+	};
+};
+
+&i2c3 {
+	clock-frequency = <400000>;
+
+	status = "okay";
+
+	typec-mux@8 {
+		compatible = "parade,ps8830";
+		reg = <0x8>;
+
+		clocks = <&rpmhcc RPMH_RF_CLK3>;
+
+		vdd33-supply = <&vreg_rtmr0_3p3>;
+		vdd33-cap-supply = <&vreg_rtmr0_3p3>;
+
+		vddio-supply = <&vreg_rtmr0_1p8>;
+
+		vdd-supply = <&vreg_rtmr0_1p15>;
+		vddar-supply = <&vreg_rtmr0_1p15>;
+		vddat-supply = <&vreg_rtmr0_1p15>;
+
+		reset-gpios = <&pm8550_gpios 10 GPIO_ACTIVE_LOW>;
+
+		pinctrl-0 = <&rtmr0_default>;
+		pinctrl-names = "default";
+
+		retimer-switch;
+		orientation-switch;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+
+				retimer_ss0_ss_out: endpoint {
+					remote-endpoint = <&pmic_glink_ss0_ss_in>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+
+				retimer_ss0_ss_in: endpoint {
+					remote-endpoint = <&usb_1_ss0_qmpphy_out>;
+				};
+			};
+
+			port@2 {
+				reg = <2>;
+
+				retimer_ss0_con_sbu_out: endpoint {
+					remote-endpoint = <&pmic_glink_ss0_con_sbu_in>;
+				};
+			};
+		};
+	};
+};
+
+&i2c5 {
+	clock-frequency = <400000>;
+
+	status = "okay";
+
+	eusb5_repeater: redriver@43 {
+		compatible = "nxp,ptn3222";
+		reg = <0x43>;
+		#phy-cells = <0>;
+
+		vdd1v8-supply = <&vreg_l4b_1p8>;
+		vdd3v3-supply = <&vreg_l13b_3p0>;
+
+		reset-gpios = <&tlmm 184 GPIO_ACTIVE_LOW>;
+
+		pinctrl-0 = <&eusb5_reset_n>;
+		pinctrl-names = "default";
+	};
+
+	eusb3_repeater: redriver@47 {
+		compatible = "nxp,ptn3222";
+		reg = <0x47>;
+		#phy-cells = <0>;
+
+		vdd1v8-supply = <&vreg_l4b_1p8>;
+		vdd3v3-supply = <&vreg_l13b_3p0>;
+
+		reset-gpios = <&tlmm 124 GPIO_ACTIVE_LOW>;
+
+		pinctrl-0 = <&eusb3_reset_n>;
+		pinctrl-names = "default";
+	};
+
+	eusb6_repeater: redriver@4f {
+		compatible = "nxp,ptn3222";
+		reg = <0x4f>;
+		#phy-cells = <0>;
+
+		vdd1v8-supply = <&vreg_l4b_1p8>;
+		vdd3v3-supply = <&vreg_l13b_3p0>;
+
+		reset-gpios = <&tlmm 111 GPIO_ACTIVE_LOW>;
+
+		pinctrl-0 = <&eusb6_reset_n>;
+		pinctrl-names = "default";
+	};
+};
+
+&iris {
+	firmware-name = "qcom/x1e80100/TUXEDO/qcvss8380.mbn";
+	status = "okay";
+};
+
+&lpass_tlmm {
+	spkr_01_sd_n_active: spkr-01-sd-n-active-state {
+		pins = "gpio12";
+		function = "gpio";
+		drive-strength = <16>;
+		bias-disable;
+		output-low;
+	};
+
+	spkr_23_sd_n_active: spkr-23-sd-n-active-state {
+		pins = "gpio13";
+		function = "gpio";
+		drive-strength = <16>;
+		bias-disable;
+		output-low;
+	};
+};
+
+&lpass_vamacro {
+	pinctrl-0 = <&dmic01_default>;
+	pinctrl-names = "default";
+
+	vdd-micb-supply = <&vreg_l1b_1p8>;
+	qcom,dmic-sample-rate = <4800000>;
+};
+
+&mdss {
+	status = "okay";
+};
+
+&mdss_dp0 {
+	sound-name-prefix = "DisplayPort0";
+
+	status = "okay";
+};
+
+&mdss_dp0_out {
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp2 {
+	sound-name-prefix = "DisplayPort2";
+
+	status = "okay";
+};
+
+&mdss_dp2_out {
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp3 {
+	/delete-property/ #sound-dai-cells;
+
+	pinctrl-0 = <&edp0_hpd_default>;
+	pinctrl-names = "default";
+
+	status = "okay";
+
+	aux-bus {
+		panel {
+			compatible = "edp-panel";
+			power-supply = <&vreg_edp_3p3>;
+
+			port {
+				edp_panel_in: endpoint {
+					remote-endpoint = <&mdss_dp3_out>;
+				};
+			};
+		};
+	};
+
+	ports {
+		port@1 {
+			reg = <1>;
+
+			mdss_dp3_out: endpoint {
+				data-lanes = <0 1 2 3>;
+				link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+
+				remote-endpoint = <&edp_panel_in>;
+			};
+		};
+	};
+};
+
+&mdss_dp3_phy {
+	vdda-phy-supply = <&vreg_l3j_0p8>;
+	vdda-pll-supply = <&vreg_l2j_1p2>;
+
+	status = "okay";
+};
+
+&pcie4 {
+	perst-gpios = <&tlmm 146 GPIO_ACTIVE_LOW>;
+	wake-gpios = <&tlmm 148 GPIO_ACTIVE_LOW>;
+
+	pinctrl-0 = <&pcie4_default>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
+&pcie4_phy {
+	vdda-phy-supply = <&vreg_l3j_0p8>;
+	vdda-pll-supply = <&vreg_l3e_1p2>;
+
+	status = "okay";
+};
+
+&pcie4_port0 {
+	wifi@0 {
+		compatible = "pci17cb,1107";
+		reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+		vddaon-supply = <&vreg_pmu_aon_0p59>;
+		vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+		vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
+		vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
+		vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+		vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+		vddrfa1p8-supply = <&vreg_pmu_rfa_1p8>;
+		vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>;
+		vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>;
+	};
+};
+
+&pcie6a {
+	perst-gpios = <&tlmm 152 GPIO_ACTIVE_LOW>;
+
+	wake-gpios = <&tlmm 154 GPIO_ACTIVE_LOW>;
+
+	vddpe-3v3-supply = <&vreg_nvme>;
+
+	pinctrl-0 = <&pcie6a_default>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
+&pcie6a_phy {
+	vdda-phy-supply = <&vreg_l1d_0p8>;
+	vdda-pll-supply = <&vreg_l2j_1p2>;
+
+	status = "okay";
+};
+
+&pm8550_gpios {
+	rtmr0_default: rtmr0-reset-n-active-state {
+		pins = "gpio10";
+		function = "normal";
+		power-source = <1>; /* 1.8V */
+		bias-disable;
+		input-disable;
+		output-enable;
+	};
+
+	usb0_3p3_reg_en: usb0-3p3-reg-en-state {
+		pins = "gpio11";
+		function = "normal";
+		power-source = <1>; /* 1.8V */
+		bias-disable;
+		input-disable;
+		output-enable;
+	};
+};
+
+&pm8550ve_9_gpios {
+	usb0_1p8_reg_en: usb0-1p8-reg-en-state {
+		pins = "gpio8";
+		function = "normal";
+		power-source = <1>; /* 1.8V */
+		bias-disable;
+		input-disable;
+		output-enable;
+	};
+};
+
+&pmc8380_5_gpios {
+	usb0_pwr_1p15_reg_en: usb0-pwr-1p15-reg-en-state {
+		pins = "gpio8";
+		function = "normal";
+		power-source = <1>; /* 1.8V */
+		bias-disable;
+		input-disable;
+		output-enable;
+	};
+};
+
+&qupv3_0 {
+	status = "okay";
+};
+
+&qupv3_1 {
+	status = "okay";
+};
+
+&qupv3_2 {
+	status = "okay";
+};
+
+&remoteproc_adsp {
+	firmware-name = "qcom/x1e80100/TUXEDO/qcadsp8380.mbn",
+			"qcom/x1e80100/TUXEDO/adsp_dtbs.elf";
+
+	status = "okay";
+};
+
+&remoteproc_cdsp {
+	firmware-name = "qcom/x1e80100/TUXEDO/qccdsp8380.mbn",
+			"qcom/x1e80100/TUXEDO/cdsp_dtbs.elf";
+
+	status = "okay";
+};
+
+&smb2360_0 {
+	status = "okay";
+};
+
+&smb2360_0_eusb2_repeater {
+	vdd18-supply = <&vreg_l3d_1p8>;
+	vdd3-supply = <&vreg_l2b_3p0>;
+};
+
+&swr0 {
+	status = "okay";
+
+	pinctrl-0 = <&wsa_swr_active>, <&spkr_01_sd_n_active>;
+	pinctrl-names = "default";
+
+	/* WSA8845, Left Woofer */
+	left_woofer: speaker@0,0 {
+		compatible = "sdw20217020400";
+		reg = <0 0>;
+		reset-gpios = <&lpass_tlmm 12 GPIO_ACTIVE_LOW>;
+		#sound-dai-cells = <0>;
+		sound-name-prefix = "WooferLeft";
+		vdd-1p8-supply = <&vreg_l15b_1p8>;
+		vdd-io-supply = <&vreg_l12b_1p2>;
+		qcom,port-mapping = <1 2 3 7 10 13>;
+	};
+
+	/* WSA8845, Left Tweeter */
+	left_tweeter: speaker@0,1 {
+		compatible = "sdw20217020400";
+		reg = <0 1>;
+		reset-gpios = <&lpass_tlmm 12 GPIO_ACTIVE_LOW>;
+		#sound-dai-cells = <0>;
+		sound-name-prefix = "TweeterLeft";
+		vdd-1p8-supply = <&vreg_l15b_1p8>;
+		vdd-io-supply = <&vreg_l12b_1p2>;
+		qcom,port-mapping = <4 5 6 7 11 13>;
+	};
+};
+
+&swr1 {
+	status = "okay";
+
+	/* WCD9385 RX */
+	wcd_rx: codec@0,4 {
+		compatible = "sdw20217010d00";
+		reg = <0 4>;
+		qcom,rx-port-mapping = <1 2 3 4 5>;
+	};
+};
+
+&swr2 {
+	status = "okay";
+
+	/* WCD9385 TX */
+	wcd_tx: codec@0,3 {
+		compatible = "sdw20217010d00";
+		reg = <0 3>;
+		qcom,tx-port-mapping = <2 2 3 4>;
+	};
+};
+
+&swr3 {
+	status = "okay";
+
+	pinctrl-0 = <&wsa2_swr_active>, <&spkr_23_sd_n_active>;
+	pinctrl-names = "default";
+
+	/* WSA8845, Right Woofer */
+	right_woofer: speaker@0,0 {
+		compatible = "sdw20217020400";
+		reg = <0 0>;
+		reset-gpios = <&lpass_tlmm 13 GPIO_ACTIVE_LOW>;
+		#sound-dai-cells = <0>;
+		sound-name-prefix = "WooferRight";
+		vdd-1p8-supply = <&vreg_l15b_1p8>;
+		vdd-io-supply = <&vreg_l12b_1p2>;
+		qcom,port-mapping = <1 2 3 7 10 13>;
+	};
+
+	/* WSA8845, Right Tweeter */
+	right_tweeter: speaker@0,1 {
+		compatible = "sdw20217020400";
+		reg = <0 1>;
+		reset-gpios = <&lpass_tlmm 13 GPIO_ACTIVE_LOW>;
+		#sound-dai-cells = <0>;
+		sound-name-prefix = "TweeterRight";
+		vdd-1p8-supply = <&vreg_l15b_1p8>;
+		vdd-io-supply = <&vreg_l12b_1p2>;
+		qcom,port-mapping = <4 5 6 7 11 13>;
+	};
+};
+
+&tlmm {
+	gpio-reserved-ranges = <28 4>, /* Unused */
+			       <44 4>, /* SPI (TPM) */
+			       <238 1>; /* UFS Reset */
+
+	edp_reg_en: edp-reg-en-state {
+		pins = "gpio54";
+		function = "gpio";
+		drive-strength = <16>;
+		bias-pull-up;
+	};
+
+	eusb3_reset_n: eusb3-reset-n-state {
+		pins = "gpio124";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+		output-low;
+	};
+
+	eusb6_reset_n: eusb6-reset-n-state {
+		pins = "gpio111";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+		output-low;
+	};
+
+	eusb5_reset_n: eusb5-reset-n-state {
+		pins = "gpio184";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+		output-low;
+	};
+
+	hall_int_n_default: hall-int-n-state {
+		pins = "gpio92";
+		function = "gpio";
+		bias-disable;
+	};
+
+	hdmi_hpd_default: hdmi-hpd-default-state {
+		pins = "gpio126";
+		function = "usb2_dp";
+		bias-disable;
+	};
+
+	kybd_default: kybd-default-state {
+		pins = "gpio67";
+		function = "gpio";
+		bias-disable;
+	};
+
+	nvme_reg_en: nvme-reg-en-state {
+		pins = "gpio18";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+	};
+
+	pcie4_default: pcie4-default-state {
+		clkreq-n-pins {
+			pins = "gpio147";
+			function = "pcie4_clk";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+
+		perst-n-pins {
+			pins = "gpio146";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-down;
+		};
+
+		wake-n-pins {
+			pins = "gpio148";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+	};
+
+	pcie6a_default: pcie6a-default-state {
+		clkreq-n-pins {
+			pins = "gpio153";
+			function = "pcie6a_clk";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+
+		perst-n-pins {
+			pins = "gpio152";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-disable;
+		};
+
+		wake-n-pins {
+			pins = "gpio154";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+	};
+
+	tpad_default: tpad-default-state {
+		pins = "gpio3";
+		function = "gpio";
+		bias-disable;
+	};
+
+	wcd_default: wcd-reset-n-active-state {
+		pins = "gpio191";
+		function = "gpio";
+		drive-strength = <16>;
+		bias-disable;
+		output-low;
+	};
+
+	wcn_sw_en: wcn-sw-en-state {
+		pins = "gpio214";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+	};
+
+	wcn_wlan_bt_en: wcn-wlan-bt-en-state {
+		pins = "gpio116", "gpio117";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+	};
+};
+
+&uart14 {
+	status = "okay";
+
+	bluetooth {
+		compatible = "qcom,wcn7850-bt";
+		max-speed = <3200000>;
+
+		vddaon-supply = <&vreg_pmu_aon_0p59>;
+		vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+		vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
+		vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
+		vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+		vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+		vddrfa1p8-supply = <&vreg_pmu_rfa_1p8>;
+	};
+};
+
+&usb_1_ss0_hsphy {
+	vdd-supply = <&vreg_l3j_0p8>;
+	vdda12-supply = <&vreg_l2j_1p2>;
+
+	phys = <&smb2360_0_eusb2_repeater>;
+
+	status = "okay";
+};
+
+&usb_1_ss0_qmpphy {
+	vdda-phy-supply = <&vreg_l2j_1p2>;
+	vdda-pll-supply = <&vreg_l1j_0p9>;
+
+	status = "okay";
+};
+
+&usb_1_ss0 {
+	status = "okay";
+};
+
+&usb_1_ss0_dwc3 {
+	dr_mode = "host";
+};
+
+&usb_1_ss0_dwc3_hs {
+	remote-endpoint = <&pmic_glink_ss0_hs_in>;
+};
+
+&usb_1_ss0_qmpphy_out {
+	remote-endpoint = <&retimer_ss0_ss_in>;
+};
+
+&usb_1_ss2_qmpphy {
+	vdda-phy-supply = <&vreg_l2j_1p2>;
+	vdda-pll-supply = <&vreg_l2d_0p9>;
+
+	/delete-property/ mode-switch;
+	/delete-property/ orientation-switch;
+
+	status = "okay";
+
+	ports {
+		port@0 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			/delete-node/ endpoint;
+
+			usb_1_ss2_qmpphy_out_dp: endpoint@0 {
+				reg = <0>;
+
+				data-lanes = <3 2 1 0>;
+				remote-endpoint = <&hdmi_bridge_dp_in>;
+			};
+
+			/* No USB3 lanes connected */
+		};
+	};
+};
+
+/* Camera */
+&usb_2 {
+	status = "okay";
+};
+
+&usb_2_dwc3 {
+	dr_mode = "host";
+};
+
+&usb_2_hsphy {
+	vdd-supply = <&vreg_l2e_0p8>;
+	vdda12-supply = <&vreg_l3e_1p2>;
+
+	phys = <&eusb5_repeater>;
+
+	status = "okay";
+};
+
+&usb_mp {
+	status = "okay";
+};
+
+/* Right side USB-A (eUSB 3) */
+&usb_mp_hsphy0 {
+	vdd-supply = <&vreg_l2e_0p8>;
+	vdda12-supply = <&vreg_l3e_1p2>;
+
+	phys = <&eusb3_repeater>;
+
+	status = "okay";
+};
+
+/* Left side USB-A (eUSB 6) */
+&usb_mp_hsphy1 {
+	vdd-supply = <&vreg_l2e_0p8>;
+	vdda12-supply = <&vreg_l3e_1p2>;
+
+	phys = <&eusb6_repeater>;
+
+	status = "okay";
+};
+
+/* Right side USB-A (USB-SS 3) */
+&usb_mp_qmpphy0 {
+	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-pll-supply = <&vreg_l3c_0p9>;
+
+	status = "okay";
+};
+
+/* Left side USB-A (USB-SS 4) */
+&usb_mp_qmpphy1 {
+	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-pll-supply = <&vreg_l3c_0p9>;
+
+	status = "okay";
+};
-- 
2.43.0

[PATCH v3 7/7] firmware: qcom: scm: Allow QSEECOM on Tuxedo Elite 14 Gen1

[Georg Gottleuber]

From: Ettore Chimenti <ettore.chimenti@linaro.org>

This is needed to access EFI variables from Linux.

Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
---
 drivers/firmware/qcom/qcom_scm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
index e777b7cb9b12..05cf8150fa5e 100644
--- a/drivers/firmware/qcom/qcom_scm.c
+++ b/drivers/firmware/qcom/qcom_scm.c
@@ -2015,6 +2015,7 @@ static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = {
 	{ .compatible = "qcom,x1e80100-crd" },
 	{ .compatible = "qcom,x1e80100-qcp" },
 	{ .compatible = "qcom,x1p42100-crd" },
+	{ .compatible = "tuxedo,elite14gen1" },
 	{ }
 };
 
-- 
2.43.0

Re: [PATCH v3 3/7] drm/bridge: simple: add ASL CS5263 DP-to-HDMI bridge

[Neil Armstrong]

On 11/21/25 15:26, Georg Gottleuber wrote:
> From: Ettore Chimenti <ettore.chimenti@linaro.org>
> 
> Add support for the transparent ASL CS5263 DP-to-HDMI bridge.
> 
> Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
> Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
> ---
>   drivers/gpu/drm/bridge/simple-bridge.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
> index e4d0bc2200f8..94aba5a9c9b9 100644
> --- a/drivers/gpu/drm/bridge/simple-bridge.c
> +++ b/drivers/gpu/drm/bridge/simple-bridge.c
> @@ -261,6 +261,11 @@ static const struct of_device_id simple_bridge_match[] = {
>   			.timings = &default_bridge_timings,
>   			.connector_type = DRM_MODE_CONNECTOR_VGA,
>   		},
> +	}, {
> +		.compatible = "asl-tek,cs5263",
> +		.data = &(const struct simple_bridge_info) {
> +			.connector_type = DRM_MODE_CONNECTOR_HDMIA,
> +		},
>   	}, {
>   		.compatible = "radxa,ra620",
>   		.data = &(const struct simple_bridge_info) {

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH v3 1/7] dt-bindings: vendor-prefixes: Add ASL Xiamen Technology

[Krzysztof Kozlowski]

On 21/11/2025 15:26, Georg Gottleuber wrote:
> From: Ettore Chimenti <ettore.chimenti@linaro.org>
> 
> ASL Xiamen Technology Co. Ltd. is a Chinese high-speed interface and
> display system chip design company. Adding it to the vendor prefixes.
> 
> Link: https://www.asl-tek.com/
> 
> Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
> Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++


Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Re: [PATCH v3 5/7] dt-bindings: arm: qcom: Add TUXEDO Computers device

[Krzysztof Kozlowski]

On 21/11/2025 15:26, Georg Gottleuber wrote:
> Introduce new binding for the TUXEDO Elite 14 Gen1 laptop with X1E78100
> SoC.
> 
> Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)


Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Re: [PATCH v3 2/7] dt-bindings: display: bridge: simple: document the ASL CS5263 DP-to-HDMI bridge

[Krzysztof Kozlowski]

On 21/11/2025 15:26, Georg Gottleuber wrote:
> From: Ettore Chimenti <ettore.chimenti@linaro.org>
> 
> The ASL CS5263 is a high-performance DP1.4 to HDMI2.0b converter,
> designed to connect a DP1.4 source to an HDMI2.0b sink. The CS5263AN
> integrates a DP1.4 compliant receiver, and a HDMI2.0b compliant
> transmitter.
> 
> Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
> Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
> ---


Acked-by: Krzysztof Kozlowski <krzk@kernel.org>


Best regards,
Krzysztof

Re: [PATCH v3 6/7] arm64: dts: qcom: Add device tree for TUXEDO Elite 14 Gen1

[Krzysztof Kozlowski]

On 21/11/2025 15:26, Georg Gottleuber wrote:
> Initial support for TUXEDO Elite 14 Gen1 based on Qualcomm Snapdragon X
> Elite SoC (X1E78100).
> 
> Working:
> * Touchpad
> * Keyboard
> * eDP (no brightness control yet)
> * NVMe
> * USB Type-C port
> * USB-C DP altmode
> * HDMI-A port
> * WiFi (WiFi 7 untested)
> * Bluetooth
> * GPU
> * Video decoding
> * USB Type-A
> * Audio, speakers, microphones
> 	- 4x speakers.
> 	- 2x dmic
> 	- headset
> * Camera
> * Fingerprint reader
> 
> Co-developed-by: Srinivas Kandagatla <srini@kernel.org>
> Signed-off-by: Srinivas Kandagatla <srini@kernel.org>
> Co-developed-by: Ettore Chimenti <ettore.chimenti@linaro.org>
> Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
> Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
> ---


I guess all our reviews are irrelevant now and this should be abandoned:

https://www.tuxedocomputers.com/en/Discontinuation-of-ARM-notebooks-with-Snapdragon-X-Elite-SoC.tuxedo

Best regards,
Krzysztof

Re: [PATCH v3 6/7] arm64: dts: qcom: Add device tree for TUXEDO Elite 14 Gen1

[Krzysztof Kozlowski]

On 22/11/2025 11:07, Krzysztof Kozlowski wrote:
> On 21/11/2025 15:26, Georg Gottleuber wrote:
>> Initial support for TUXEDO Elite 14 Gen1 based on Qualcomm Snapdragon X
>> Elite SoC (X1E78100).
>>
>> Working:
>> * Touchpad
>> * Keyboard
>> * eDP (no brightness control yet)
>> * NVMe
>> * USB Type-C port
>> * USB-C DP altmode
>> * HDMI-A port
>> * WiFi (WiFi 7 untested)
>> * Bluetooth
>> * GPU
>> * Video decoding
>> * USB Type-A
>> * Audio, speakers, microphones
>> 	- 4x speakers.
>> 	- 2x dmic
>> 	- headset
>> * Camera
>> * Fingerprint reader
>>
>> Co-developed-by: Srinivas Kandagatla <srini@kernel.org>
>> Signed-off-by: Srinivas Kandagatla <srini@kernel.org>
>> Co-developed-by: Ettore Chimenti <ettore.chimenti@linaro.org>
>> Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
>> Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
>> ---
> 
> 
> I guess all our reviews are irrelevant now and this should be abandoned:
> 
> https://www.tuxedocomputers.com/en/Discontinuation-of-ARM-notebooks-with-Snapdragon-X-Elite-SoC.tuxedo

Heh, I see you sent it AFTER the above announcement, so knowing this is
not going to be merged. Reviewing code which is not going to be need is
waste of time, so I feel tricked. That's not nice.

Best regards,
Krzysztof

Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Krzysztof Kozlowski]

On 21/11/2025 15:26, Georg Gottleuber wrote:
> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
> Snapdragon X Elite SoC (X1E78100).
> 
> Changes in v3:
> - add DisplayPort audio to dts
> - add el2.dtb to Makefile
> - change dts firmware paths
> - fix dt-binding (x1e78100 instead of x1e80100)
> - improve commit message for elite14gen1 dt-bindings
> - remove smb2360_1 from dts (only one USB-C port is present)
> - remove "VA MIC BIAS1" from dts
> - remove regulator-always-on from vreg_edp_3p3 (display) in dts
> - rename vendor prefix of ASL Xiamen Technology to asl-tek
> - sort dts
> 
> Changes in v2:
> - Rebase to v6.18-rc4/master
> - Add support for accelerated video decoding
> - Add support for audio (speakers, microphones, headset)
> - Add support for Bluetooth
> - Add support for camera
> - Add support for fingerprint reader
> - Add support for HDMI-A port
> - Add support for QSEECOM
> - Add support for USB Type-A
> - Add support for USB-C DP altmode
> - Add ASL Xiamen Technology Co. Ltd. vendor prefix
> - Add TUXEDO vendor prefix
> - Add cover letter
> - Removal of pointless comments
> - Coding style fixes
> - Spell check
> 
> The device tree uses the dtschema from Linaro DisplayPort PHY patch [1].
> ALSA UCM and Audioreach topology patches are available at [2] and [3].
> The fingerprint reader requires USB IDs to be patched into libfprint.
> WiFi requires a firmware patch [4].
> 
> Announcement and request for comments:

This should be FIRST part of cover letter, so we won't waste time on
reviewing it, instead of burying it deep. Additionally, you should have
named the series RFC.

> Because the SoC is now outdated and some functions still do not work as
> well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1
> will not be offered for sale. We would still like to submit our device
> tree to the mainline kernel and thus contribute to Linux support for a
> compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in
> Germany, this device was sold in many large stores. (An official press
> statement will follow on our website.)

For me this is unmergeable, because we do not take stuff which no one
uses (no one can even use), and I am sad I put effort in reviewing AFTER
this was known to be cancelled.


Best regards,
Krzysztof

Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Stephan Gerhold]

On Sat, Nov 22, 2025 at 11:16:25AM +0100, Krzysztof Kozlowski wrote:
> On 21/11/2025 15:26, Georg Gottleuber wrote:
> > [...]
> > Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
> > Snapdragon X Elite SoC (X1E78100).
> > 
> [...]
> 
> > Because the SoC is now outdated and some functions still do not work as
> > well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1
> > will not be offered for sale. We would still like to submit our device
> > tree to the mainline kernel and thus contribute to Linux support for a
> > compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in
> > Germany, this device was sold in many large stores. (An official press
> > statement will follow on our website.)
> 
> For me this is unmergeable, because we do not take stuff which no one
> uses (no one can even use), and I am sad I put effort in reviewing AFTER
> this was known to be cancelled.
> 

I don't think we have any requirement to have a large user base in order
to merge changes. There is already support for plenty of cancelled
products with only a few (if any) remaining users in mainline, e.g.

 - Snapdragon X Elite Dev Kit (x1e001de-devkit), shipped only to a
   handful of users before cancelled
 - All ChromeOS SC7280 devices (including DTB variants for several
   revisions of pre-production samples), never shipped to anyone

There are also plenty of internal reference devices that only a handful
of people have access to (MTP, HDK, CRD etc). What makes these any
different? Ettore has been actively testing and contributing to the port
for the TUXEDO laptop, so if he wants to continue that, I don't think
anything speaks against merging this device tree.

In any case, I don't think the time reviewing these changes is wasted:
As Georg wrote, there is also the Medion SPRCHRGD 14 S1 Elite laptop
that uses basically the same hardware design. I'm sure there are (or
eventually will be) users of that device who would appreciate having a
fully-functional device tree ready to use. There is an open issue in one
of the Ubuntu repositories for example [1] to add automatic DTB
selection for it.

In other words, even if we decide against adding support for the
"x1e80100-tuxedo-elite-14-gen1", the same changes renamed to
"x1e80100-medion-sprchrgd-14-s1" would still be valid and valuable.
I wouldn't expect any other changes to be needed, although obviously
someone with access to the device should confirm that before submitting.

Thanks,
Stephan

[1]: https://github.com/ubuntu/stubble/issues/34

Re: [PATCH v3 6/7] arm64: dts: qcom: Add device tree for TUXEDO Elite 14 Gen1

[Georg Gottleuber]

Am 22.11.25 um 11:09 schrieb Krzysztof Kozlowski:
> On 22/11/2025 11:07, Krzysztof Kozlowski wrote:
>> On 21/11/2025 15:26, Georg Gottleuber wrote:
>>> Initial support for TUXEDO Elite 14 Gen1 based on Qualcomm Snapdragon X
>>> Elite SoC (X1E78100).
>>>
>>> Working:
>>> * Touchpad
>>> * Keyboard
>>> * eDP (no brightness control yet)
>>> * NVMe
>>> * USB Type-C port
>>> * USB-C DP altmode
>>> * HDMI-A port
>>> * WiFi (WiFi 7 untested)
>>> * Bluetooth
>>> * GPU
>>> * Video decoding
>>> * USB Type-A
>>> * Audio, speakers, microphones
>>> 	- 4x speakers.
>>> 	- 2x dmic
>>> 	- headset
>>> * Camera
>>> * Fingerprint reader
>>>
>>> Co-developed-by: Srinivas Kandagatla <srini@kernel.org>
>>> Signed-off-by: Srinivas Kandagatla <srini@kernel.org>
>>> Co-developed-by: Ettore Chimenti <ettore.chimenti@linaro.org>
>>> Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
>>> Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
>>> ---
>>
>>
>> I guess all our reviews are irrelevant now and this should be abandoned:
>>
>> https://www.tuxedocomputers.com/en/Discontinuation-of-ARM-notebooks-with-Snapdragon-X-Elite-SoC.tuxedo
> 
> Heh, I see you sent it AFTER the above announcement, so knowing this is
> not going to be merged. Reviewing code which is not going to be need is
> waste of time, so I feel tricked. That's not nice.

Hi Krzysztof, I am very sorry about that. That was precisely NOT my
intention. That's why I updated the cover letter for v3 and made sure
that this information was first released to the kernel maintainers (so
that they wouldn't find out about it through the press). My patch set
was deliberately published hours before the official press statement.
(Maybe the time gap was too short.)

Please read the updated cover letter.

Regards,
Georg

> Best regards,
> Krzysztof

Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Krzysztof Kozlowski]

On 22/11/2025 12:00, Stephan Gerhold wrote:
> On Sat, Nov 22, 2025 at 11:16:25AM +0100, Krzysztof Kozlowski wrote:
>> On 21/11/2025 15:26, Georg Gottleuber wrote:
>>> [...]
>>> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
>>> Snapdragon X Elite SoC (X1E78100).
>>>
>> [...]
>>
>>> Because the SoC is now outdated and some functions still do not work as
>>> well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1
>>> will not be offered for sale. We would still like to submit our device
>>> tree to the mainline kernel and thus contribute to Linux support for a
>>> compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in
>>> Germany, this device was sold in many large stores. (An official press
>>> statement will follow on our website.)
>>
>> For me this is unmergeable, because we do not take stuff which no one
>> uses (no one can even use), and I am sad I put effort in reviewing AFTER
>> this was known to be cancelled.
>>
> 
> I don't think we have any requirement to have a large user base in order
> to merge changes. There is already support for plenty of cancelled
> products with only a few (if any) remaining users in mainline, e.g.
> 
>  - Snapdragon X Elite Dev Kit (x1e001de-devkit), shipped only to a
>    handful of users before cancelled
>  - All ChromeOS SC7280 devices (including DTB variants for several
>    revisions of pre-production samples), never shipped to anyone
> 

I discuss here the timing primarily and I don't know the timing about them.

> There are also plenty of internal reference devices that only a handful
> of people have access to (MTP, HDK, CRD etc). What makes these any

They are still "maintained" and "offered", even if only for handful
(like 3000 EACH variant) people. That's the amount of board of each
variant, e.g. MTP8750, and all of them run some sort of Linux, even if
downstream. So sorry, but 3000 (or whatever number it is) is not handful.

> different? Ettore has been actively testing and contributing to the port
> for the TUXEDO laptop, so if he wants to continue that, I don't think
> anything speaks against merging this device tree.

I won't be maintaining it, so not my effort in that, but since you speak
about that - maintenance is an effort, thus I decide not to spend it on
cancelled products.

> 
> In any case, I don't think the time reviewing these changes is wasted:

I am happy that you do not find my time wasted, but I disagree on that
because knowing this is cancelled, I would probably not care and review
products which are not cancelled at this time.

> As Georg wrote, there is also the Medion SPRCHRGD 14 S1 Elite laptop
> that uses basically the same hardware design. I'm sure there are (or
> eventually will be) users of that device who would appreciate having a
> fully-functional device tree ready to use. There is an open issue in one
> of the Ubuntu repositories for example [1] to add automatic DTB
> selection for it.
> 
> In other words, even if we decide against adding support for the
> "x1e80100-tuxedo-elite-14-gen1", the same changes renamed to
> "x1e80100-medion-sprchrgd-14-s1" would still be valid and valuable.

That's why you send such patches with RFC title and FIRST (literally
first) explanation in cover letter WHY, so people can decide.

> I wouldn't expect any other changes to be needed, although obviously
> someone with access to the device should confirm that before submitting.

You still cannot apply my review to that other board, so still wasted
time because I would need to review again.


Best regards,
Krzysztof

Re: [PATCH v3 6/7] arm64: dts: qcom: Add device tree for TUXEDO Elite 14 Gen1

[Georg Gottleuber]

Am 22.11.25 um 12:10 schrieb Georg Gottleuber:
> 
> Am 22.11.25 um 11:09 schrieb Krzysztof Kozlowski:
>> On 22/11/2025 11:07, Krzysztof Kozlowski wrote:
>>> On 21/11/2025 15:26, Georg Gottleuber wrote:
>>>> Initial support for TUXEDO Elite 14 Gen1 based on Qualcomm Snapdragon X
>>>> Elite SoC (X1E78100).
>>>>
>>>> Working:
>>>> * Touchpad
>>>> * Keyboard
>>>> * eDP (no brightness control yet)
>>>> * NVMe
>>>> * USB Type-C port
>>>> * USB-C DP altmode
>>>> * HDMI-A port
>>>> * WiFi (WiFi 7 untested)
>>>> * Bluetooth
>>>> * GPU
>>>> * Video decoding
>>>> * USB Type-A
>>>> * Audio, speakers, microphones
>>>> 	- 4x speakers.
>>>> 	- 2x dmic
>>>> 	- headset
>>>> * Camera
>>>> * Fingerprint reader
>>>>
>>>> Co-developed-by: Srinivas Kandagatla <srini@kernel.org>
>>>> Signed-off-by: Srinivas Kandagatla <srini@kernel.org>
>>>> Co-developed-by: Ettore Chimenti <ettore.chimenti@linaro.org>
>>>> Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
>>>> Signed-off-by: Georg Gottleuber <ggo@tuxedocomputers.com>
>>>> ---
>>>
>>>
>>> I guess all our reviews are irrelevant now and this should be abandoned:
>>>
>>> https://www.tuxedocomputers.com/en/Discontinuation-of-ARM-notebooks-with-Snapdragon-X-Elite-SoC.tuxedo
>>
>> Heh, I see you sent it AFTER the above announcement, so knowing this is
>> not going to be merged. Reviewing code which is not going to be need is
>> waste of time, so I feel tricked. That's not nice.
> 
> Hi Krzysztof, I am very sorry about that. That was precisely NOT my
> intention. That's why I updated the cover letter for v3 and made sure
> that this information was first released to the kernel maintainers (so
> that they wouldn't find out about it through the press). My patch set
> was deliberately published hours before the official press statement.
> (Maybe the time gap was too short.)
> 
> Please read the updated cover letter.

One more thing: The timestamp on
https://www.tuxedocomputers.com/en/Discontinuation-of-ARM-notebooks-with-Snapdragon-X-Elite-SoC.tuxedo
is obviously (for me) the date of creation not the date of publication.
I can understand that it made you suspicious.

Regards,
Georg


> Regards,
> Georg
> 
>> Best regards,
>> Krzysztof
> 

Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Georg Gottleuber]

Hello Krzysztof.

Am 22.11.25 um 12:15 schrieb Krzysztof Kozlowski:
> On 22/11/2025 12:00, Stephan Gerhold wrote:
>> On Sat, Nov 22, 2025 at 11:16:25AM +0100, Krzysztof Kozlowski wrote:
>>> On 21/11/2025 15:26, Georg Gottleuber wrote:
>>>> [...]
>>>> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
>>>> Snapdragon X Elite SoC (X1E78100).
>>>>
>>> [...]
>>>
>>>> Because the SoC is now outdated and some functions still do not work as
>>>> well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1
>>>> will not be offered for sale. We would still like to submit our device
>>>> tree to the mainline kernel and thus contribute to Linux support for a
>>>> compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in
>>>> Germany, this device was sold in many large stores. (An official press
>>>> statement will follow on our website.)
>>>
>>> For me this is unmergeable, because we do not take stuff which no one
>>> uses (no one can even use), and I am sad I put effort in reviewing AFTER
>>> this was known to be cancelled.

In fact, there are a couple of these TUXEDO devices, some of these are
already being used by people outside the company (by Linaro). There are
also considerations to give the engineering samples to
Linux/ARM-(kernel) enthusiasts.

>> I don't think we have any requirement to have a large user base in order
>> to merge changes. There is already support for plenty of cancelled
>> products with only a few (if any) remaining users in mainline, e.g.
>>
>>  - Snapdragon X Elite Dev Kit (x1e001de-devkit), shipped only to a
>>    handful of users before cancelled
>>  - All ChromeOS SC7280 devices (including DTB variants for several
>>    revisions of pre-production samples), never shipped to anyone
>>
> 
> I discuss here the timing primarily and I don't know the timing about them.
> 
>> There are also plenty of internal reference devices that only a handful
>> of people have access to (MTP, HDK, CRD etc). What makes these any
> 
> They are still "maintained" and "offered", even if only for handful
> (like 3000 EACH variant) people. That's the amount of board of each
> variant, e.g. MTP8750, and all of them run some sort of Linux, even if
> downstream. So sorry, but 3000 (or whatever number it is) is not handful.
> 
>> different? Ettore has been actively testing and contributing to the port
>> for the TUXEDO laptop, so if he wants to continue that, I don't think
>> anything speaks against merging this device tree.
> 
> I won't be maintaining it, so not my effort in that, but since you speak
> about that - maintenance is an effort, thus I decide not to spend it on
> cancelled products.
>> In any case, I don't think the time reviewing these changes is wasted:
> 
> I am happy that you do not find my time wasted, but I disagree on that
> because knowing this is cancelled, I would probably not care and review
> products which are not cancelled at this time.

Do you maintain your position despite the above circumstances?

>> As Georg wrote, there is also the Medion SPRCHRGD 14 S1 Elite laptop
>> that uses basically the same hardware design. I'm sure there are (or
>> eventually will be) users of that device who would appreciate having a
>> fully-functional device tree ready to use. There is an open issue in one
>> of the Ubuntu repositories for example [1] to add automatic DTB
>> selection for it.
>>
>> In other words, even if we decide against adding support for the
>> "x1e80100-tuxedo-elite-14-gen1", the same changes renamed to
>> "x1e80100-medion-sprchrgd-14-s1" would still be valid and valuable.
> 
> That's why you send such patches with RFC title and FIRST (literally
> first) explanation in cover letter WHY, so people can decide.
> 
>> I wouldn't expect any other changes to be needed, although obviously
>> someone with access to the device should confirm that before submitting.
> 
> You still cannot apply my review to that other board, so still wasted
> time because I would need to review again.

I understand your frustration, but I'm still learning how to contribute
to the Linux kernel. However, we may be able to find a constructive
solution. Here at TUXEDO, we have the necessary Medion device and have
already adapted the device tree.

Would you review a patch set for Medion SPRCHRGD 14 S1 Elite?

(This device is still on sale and can be found in many large electronics
stores, at least in Germany.)

Best regards,
Georg

> 
> Best regards,
> Krzysztof

Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Dmitry Baryshkov]

On Sat, Nov 22, 2025 at 12:15:40PM +0100, Krzysztof Kozlowski wrote:
> On 22/11/2025 12:00, Stephan Gerhold wrote:
> > On Sat, Nov 22, 2025 at 11:16:25AM +0100, Krzysztof Kozlowski wrote:
> >> On 21/11/2025 15:26, Georg Gottleuber wrote:
> >>> [...]
> >>> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
> >>> Snapdragon X Elite SoC (X1E78100).
> >>>
> >> [...]
> >>
> >>> Because the SoC is now outdated and some functions still do not work as
> >>> well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1
> >>> will not be offered for sale. We would still like to submit our device
> >>> tree to the mainline kernel and thus contribute to Linux support for a
> >>> compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in
> >>> Germany, this device was sold in many large stores. (An official press
> >>> statement will follow on our website.)
> >>
> >> For me this is unmergeable, because we do not take stuff which no one
> >> uses (no one can even use), and I am sad I put effort in reviewing AFTER
> >> this was known to be cancelled.
> >>
> > 
> > I don't think we have any requirement to have a large user base in order
> > to merge changes. There is already support for plenty of cancelled
> > products with only a few (if any) remaining users in mainline, e.g.
> > 
> >  - Snapdragon X Elite Dev Kit (x1e001de-devkit), shipped only to a
> >    handful of users before cancelled
> >  - All ChromeOS SC7280 devices (including DTB variants for several
> >    revisions of pre-production samples), never shipped to anyone
> > 
> 
> I discuss here the timing primarily and I don't know the timing about them.
> 
> > There are also plenty of internal reference devices that only a handful
> > of people have access to (MTP, HDK, CRD etc). What makes these any
> 
> They are still "maintained" and "offered", even if only for handful
> (like 3000 EACH variant) people. That's the amount of board of each
> variant, e.g. MTP8750, and all of them run some sort of Linux, even if
> downstream. So sorry, but 3000 (or whatever number it is) is not handful.

Where does 3000 come from? The Bible says 10 people were enough to
maintain Sodom and Gomorrah. For Herobrine we know that there are very
few people still using those devices (maybe less than 10), but we still
keep it. Cheeza was dropped after it was known that the count is exactly
zero.

> 
> > different? Ettore has been actively testing and contributing to the port
> > for the TUXEDO laptop, so if he wants to continue that, I don't think
> > anything speaks against merging this device tree.
> 
> I won't be maintaining it, so not my effort in that, but since you speak
> about that - maintenance is an effort, thus I decide not to spend it on
> cancelled products.
> 
> > 
> > In any case, I don't think the time reviewing these changes is wasted:
> 
> I am happy that you do not find my time wasted, but I disagree on that
> because knowing this is cancelled, I would probably not care and review
> products which are not cancelled at this time.

There still people owning and being happy with those laptops. It's
Bjorn's and Konrad's time being spent on maintaining those. What's the
issue?

> 
> > As Georg wrote, there is also the Medion SPRCHRGD 14 S1 Elite laptop
> > that uses basically the same hardware design. I'm sure there are (or
> > eventually will be) users of that device who would appreciate having a
> > fully-functional device tree ready to use. There is an open issue in one
> > of the Ubuntu repositories for example [1] to add automatic DTB
> > selection for it.
> > 
> > In other words, even if we decide against adding support for the
> > "x1e80100-tuxedo-elite-14-gen1", the same changes renamed to
> > "x1e80100-medion-sprchrgd-14-s1" would still be valid and valuable.
> 
> That's why you send such patches with RFC title and FIRST (literally
> first) explanation in cover letter WHY, so people can decide.
> 
> > I wouldn't expect any other changes to be needed, although obviously
> > someone with access to the device should confirm that before submitting.
> 
> You still cannot apply my review to that other board, so still wasted
> time because I would need to review again.
> 
> 
> Best regards,
> Krzysztof

-- 
With best wishes
Dmitry

Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Krzysztof Kozlowski]

On 24/11/2025 15:34, Dmitry Baryshkov wrote:
> On Sat, Nov 22, 2025 at 12:15:40PM +0100, Krzysztof Kozlowski wrote:
>> On 22/11/2025 12:00, Stephan Gerhold wrote:
>>> On Sat, Nov 22, 2025 at 11:16:25AM +0100, Krzysztof Kozlowski wrote:
>>>> On 21/11/2025 15:26, Georg Gottleuber wrote:
>>>>> [...]
>>>>> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
>>>>> Snapdragon X Elite SoC (X1E78100).
>>>>>
>>>> [...]
>>>>
>>>>> Because the SoC is now outdated and some functions still do not work as
>>>>> well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1
>>>>> will not be offered for sale. We would still like to submit our device
>>>>> tree to the mainline kernel and thus contribute to Linux support for a
>>>>> compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in
>>>>> Germany, this device was sold in many large stores. (An official press
>>>>> statement will follow on our website.)
>>>>
>>>> For me this is unmergeable, because we do not take stuff which no one
>>>> uses (no one can even use), and I am sad I put effort in reviewing AFTER
>>>> this was known to be cancelled.
>>>>
>>>
>>> I don't think we have any requirement to have a large user base in order
>>> to merge changes. There is already support for plenty of cancelled
>>> products with only a few (if any) remaining users in mainline, e.g.
>>>
>>>  - Snapdragon X Elite Dev Kit (x1e001de-devkit), shipped only to a
>>>    handful of users before cancelled
>>>  - All ChromeOS SC7280 devices (including DTB variants for several
>>>    revisions of pre-production samples), never shipped to anyone
>>>
>>
>> I discuss here the timing primarily and I don't know the timing about them.
>>
>>> There are also plenty of internal reference devices that only a handful
>>> of people have access to (MTP, HDK, CRD etc). What makes these any
>>
>> They are still "maintained" and "offered", even if only for handful
>> (like 3000 EACH variant) people. That's the amount of board of each
>> variant, e.g. MTP8750, and all of them run some sort of Linux, even if
>> downstream. So sorry, but 3000 (or whatever number it is) is not handful.
> 
> Where does 3000 come from? The Bible says 10 people were enough to
> maintain Sodom and Gomorrah. For Herobrine we know that there are very
> few people still using those devices (maybe less than 10), but we still
> keep it. Cheeza was dropped after it was known that the count is exactly
> zero.
> 
>>
>>> different? Ettore has been actively testing and contributing to the port
>>> for the TUXEDO laptop, so if he wants to continue that, I don't think
>>> anything speaks against merging this device tree.
>>
>> I won't be maintaining it, so not my effort in that, but since you speak
>> about that - maintenance is an effort, thus I decide not to spend it on
>> cancelled products.
>>
>>>
>>> In any case, I don't think the time reviewing these changes is wasted:
>>
>> I am happy that you do not find my time wasted, but I disagree on that
>> because knowing this is cancelled, I would probably not care and review
>> products which are not cancelled at this time.
> 
> There still people owning and being happy with those laptops. It's
> Bjorn's and Konrad's time being spent on maintaining those. What's the
> issue?


I think I described my issue very precise. Please read my first reply in
this thread. Joining discussion at the end of it, not reading it and
then asking "what is the issue" is not really encouraging me to discuss
whether this is a problem or not.

Best regards,
Krzysztof

Re: (subset) [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Neil Armstrong]

Hi,

On Fri, 21 Nov 2025 15:26:12 +0100, Georg Gottleuber wrote:
> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
> Snapdragon X Elite SoC (X1E78100).
> 
> Changes in v3:
> - add DisplayPort audio to dts
> - add el2.dtb to Makefile
> - change dts firmware paths
> - fix dt-binding (x1e78100 instead of x1e80100)
> - improve commit message for elite14gen1 dt-bindings
> - remove smb2360_1 from dts (only one USB-C port is present)
> - remove "VA MIC BIAS1" from dts
> - remove regulator-always-on from vreg_edp_3p3 (display) in dts
> - rename vendor prefix of ASL Xiamen Technology to asl-tek
> - sort dts
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/7] dt-bindings: vendor-prefixes: Add ASL Xiamen Technology
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/ee4f232dd1ff8e11a18c6dab6f7a3a89eee62436
[2/7] dt-bindings: display: bridge: simple: document the ASL CS5263 DP-to-HDMI bridge
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/0eebd421ac09686f9646ea635ee8920d55ee5d26
[3/7] drm/bridge: simple: add ASL CS5263 DP-to-HDMI bridge
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/d525f967e7a40c08af3e752281ede72e9922b87f

-- 
Neil

Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Dmitry Baryshkov]

On Mon, Nov 24, 2025 at 04:09:56PM +0100, Krzysztof Kozlowski wrote:
> On 24/11/2025 15:34, Dmitry Baryshkov wrote:
> > On Sat, Nov 22, 2025 at 12:15:40PM +0100, Krzysztof Kozlowski wrote:
> >> On 22/11/2025 12:00, Stephan Gerhold wrote:
> >>> On Sat, Nov 22, 2025 at 11:16:25AM +0100, Krzysztof Kozlowski wrote:
> >>>> On 21/11/2025 15:26, Georg Gottleuber wrote:
> >>>>> [...]
> >>>>> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
> >>>>> Snapdragon X Elite SoC (X1E78100).
> >>>>>
> >>>> [...]
> >>>>
> >>>>> Because the SoC is now outdated and some functions still do not work as
> >>>>> well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1
> >>>>> will not be offered for sale. We would still like to submit our device
> >>>>> tree to the mainline kernel and thus contribute to Linux support for a
> >>>>> compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in
> >>>>> Germany, this device was sold in many large stores. (An official press
> >>>>> statement will follow on our website.)
> >>>>
> >>>> For me this is unmergeable, because we do not take stuff which no one
> >>>> uses (no one can even use), and I am sad I put effort in reviewing AFTER
> >>>> this was known to be cancelled.
> >>>>
> >>>
> >>> I don't think we have any requirement to have a large user base in order
> >>> to merge changes. There is already support for plenty of cancelled
> >>> products with only a few (if any) remaining users in mainline, e.g.
> >>>
> >>>  - Snapdragon X Elite Dev Kit (x1e001de-devkit), shipped only to a
> >>>    handful of users before cancelled
> >>>  - All ChromeOS SC7280 devices (including DTB variants for several
> >>>    revisions of pre-production samples), never shipped to anyone
> >>>
> >>
> >> I discuss here the timing primarily and I don't know the timing about them.
> >>
> >>> There are also plenty of internal reference devices that only a handful
> >>> of people have access to (MTP, HDK, CRD etc). What makes these any
> >>
> >> They are still "maintained" and "offered", even if only for handful
> >> (like 3000 EACH variant) people. That's the amount of board of each
> >> variant, e.g. MTP8750, and all of them run some sort of Linux, even if
> >> downstream. So sorry, but 3000 (or whatever number it is) is not handful.
> > 
> > Where does 3000 come from? The Bible says 10 people were enough to
> > maintain Sodom and Gomorrah. For Herobrine we know that there are very
> > few people still using those devices (maybe less than 10), but we still
> > keep it. Cheeza was dropped after it was known that the count is exactly
> > zero.
> > 
> >>
> >>> different? Ettore has been actively testing and contributing to the port
> >>> for the TUXEDO laptop, so if he wants to continue that, I don't think
> >>> anything speaks against merging this device tree.
> >>
> >> I won't be maintaining it, so not my effort in that, but since you speak
> >> about that - maintenance is an effort, thus I decide not to spend it on
> >> cancelled products.
> >>
> >>>
> >>> In any case, I don't think the time reviewing these changes is wasted:
> >>
> >> I am happy that you do not find my time wasted, but I disagree on that
> >> because knowing this is cancelled, I would probably not care and review
> >> products which are not cancelled at this time.
> > 
> > There still people owning and being happy with those laptops. It's
> > Bjorn's and Konrad's time being spent on maintaining those. What's the
> > issue?
> 
> 
> I think I described my issue very precise. Please read my first reply in
> this thread. Joining discussion at the end of it, not reading it and
> then asking "what is the issue" is not really encouraging me to discuss
> whether this is a problem or not.

I had read it before replying.

-- 
With best wishes
Dmitry

Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Krzysztof Kozlowski]

On 25/11/2025 00:41, Dmitry Baryshkov wrote:
> On Mon, Nov 24, 2025 at 04:09:56PM +0100, Krzysztof Kozlowski wrote:
>> On 24/11/2025 15:34, Dmitry Baryshkov wrote:
>>> On Sat, Nov 22, 2025 at 12:15:40PM +0100, Krzysztof Kozlowski wrote:
>>>> On 22/11/2025 12:00, Stephan Gerhold wrote:
>>>>> On Sat, Nov 22, 2025 at 11:16:25AM +0100, Krzysztof Kozlowski wrote:
>>>>>> On 21/11/2025 15:26, Georg Gottleuber wrote:
>>>>>>> [...]
>>>>>>> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
>>>>>>> Snapdragon X Elite SoC (X1E78100).
>>>>>>>
>>>>>> [...]
>>>>>>
>>>>>>> Because the SoC is now outdated and some functions still do not work as
>>>>>>> well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1
>>>>>>> will not be offered for sale. We would still like to submit our device
>>>>>>> tree to the mainline kernel and thus contribute to Linux support for a
>>>>>>> compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in
>>>>>>> Germany, this device was sold in many large stores. (An official press
>>>>>>> statement will follow on our website.)
>>>>>>
>>>>>> For me this is unmergeable, because we do not take stuff which no one
>>>>>> uses (no one can even use), and I am sad I put effort in reviewing AFTER
>>>>>> this was known to be cancelled.
>>>>>>
>>>>>
>>>>> I don't think we have any requirement to have a large user base in order
>>>>> to merge changes. There is already support for plenty of cancelled
>>>>> products with only a few (if any) remaining users in mainline, e.g.
>>>>>
>>>>>  - Snapdragon X Elite Dev Kit (x1e001de-devkit), shipped only to a
>>>>>    handful of users before cancelled
>>>>>  - All ChromeOS SC7280 devices (including DTB variants for several
>>>>>    revisions of pre-production samples), never shipped to anyone
>>>>>
>>>>
>>>> I discuss here the timing primarily and I don't know the timing about them.
>>>>
>>>>> There are also plenty of internal reference devices that only a handful
>>>>> of people have access to (MTP, HDK, CRD etc). What makes these any
>>>>
>>>> They are still "maintained" and "offered", even if only for handful
>>>> (like 3000 EACH variant) people. That's the amount of board of each
>>>> variant, e.g. MTP8750, and all of them run some sort of Linux, even if
>>>> downstream. So sorry, but 3000 (or whatever number it is) is not handful.
>>>
>>> Where does 3000 come from? The Bible says 10 people were enough to
>>> maintain Sodom and Gomorrah. For Herobrine we know that there are very
>>> few people still using those devices (maybe less than 10), but we still
>>> keep it. Cheeza was dropped after it was known that the count is exactly
>>> zero.
>>>
>>>>
>>>>> different? Ettore has been actively testing and contributing to the port
>>>>> for the TUXEDO laptop, so if he wants to continue that, I don't think
>>>>> anything speaks against merging this device tree.
>>>>
>>>> I won't be maintaining it, so not my effort in that, but since you speak
>>>> about that - maintenance is an effort, thus I decide not to spend it on
>>>> cancelled products.
>>>>
>>>>>
>>>>> In any case, I don't think the time reviewing these changes is wasted:
>>>>
>>>> I am happy that you do not find my time wasted, but I disagree on that
>>>> because knowing this is cancelled, I would probably not care and review
>>>> products which are not cancelled at this time.
>>>
>>> There still people owning and being happy with those laptops. It's
>>> Bjorn's and Konrad's time being spent on maintaining those. What's the
>>> issue?
>>
>>
>> I think I described my issue very precise. Please read my first reply in
>> this thread. Joining discussion at the end of it, not reading it and
>> then asking "what is the issue" is not really encouraging me to discuss
>> whether this is a problem or not.
> 
> I had read it before replying.

So I said that issue is that I wasted time on reviewing something I
would not review, if this was clearly marked correctly, because I would
consider it waste of time and you asked "what is the issue?"

What sort of question is that? I just wrote what is the issue... And you
ask what issue?


Best regards,
Krzysztof

Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Neil Armstrong]

On 11/24/25 15:09, Georg Gottleuber wrote:
> Hello Krzysztof.
> 
> Am 22.11.25 um 12:15 schrieb Krzysztof Kozlowski:
>> On 22/11/2025 12:00, Stephan Gerhold wrote:
>>> On Sat, Nov 22, 2025 at 11:16:25AM +0100, Krzysztof Kozlowski wrote:
>>>> On 21/11/2025 15:26, Georg Gottleuber wrote:
>>>>> [...]
>>>>> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
>>>>> Snapdragon X Elite SoC (X1E78100).
>>>>>
>>>> [...]
>>>>
>>>>> Because the SoC is now outdated and some functions still do not work as
>>>>> well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1
>>>>> will not be offered for sale. We would still like to submit our device
>>>>> tree to the mainline kernel and thus contribute to Linux support for a
>>>>> compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in
>>>>> Germany, this device was sold in many large stores. (An official press
>>>>> statement will follow on our website.)
>>>>
>>>> For me this is unmergeable, because we do not take stuff which no one
>>>> uses (no one can even use), and I am sad I put effort in reviewing AFTER
>>>> this was known to be cancelled.
> 
> In fact, there are a couple of these TUXEDO devices, some of these are
> already being used by people outside the company (by Linaro). There are
> also considerations to give the engineering samples to
> Linux/ARM-(kernel) enthusiasts.
> 
>>> I don't think we have any requirement to have a large user base in order
>>> to merge changes. There is already support for plenty of cancelled
>>> products with only a few (if any) remaining users in mainline, e.g.
>>>
>>>   - Snapdragon X Elite Dev Kit (x1e001de-devkit), shipped only to a
>>>     handful of users before cancelled
>>>   - All ChromeOS SC7280 devices (including DTB variants for several
>>>     revisions of pre-production samples), never shipped to anyone
>>>
>>
>> I discuss here the timing primarily and I don't know the timing about them.
>>
>>> There are also plenty of internal reference devices that only a handful
>>> of people have access to (MTP, HDK, CRD etc). What makes these any
>>
>> They are still "maintained" and "offered", even if only for handful
>> (like 3000 EACH variant) people. That's the amount of board of each
>> variant, e.g. MTP8750, and all of them run some sort of Linux, even if
>> downstream. So sorry, but 3000 (or whatever number it is) is not handful.
>>
>>> different? Ettore has been actively testing and contributing to the port
>>> for the TUXEDO laptop, so if he wants to continue that, I don't think
>>> anything speaks against merging this device tree.
>>
>> I won't be maintaining it, so not my effort in that, but since you speak
>> about that - maintenance is an effort, thus I decide not to spend it on
>> cancelled products.
>>> In any case, I don't think the time reviewing these changes is wasted:
>>
>> I am happy that you do not find my time wasted, but I disagree on that
>> because knowing this is cancelled, I would probably not care and review
>> products which are not cancelled at this time.
> 
> Do you maintain your position despite the above circumstances?
> 
>>> As Georg wrote, there is also the Medion SPRCHRGD 14 S1 Elite laptop
>>> that uses basically the same hardware design. I'm sure there are (or
>>> eventually will be) users of that device who would appreciate having a
>>> fully-functional device tree ready to use. There is an open issue in one
>>> of the Ubuntu repositories for example [1] to add automatic DTB
>>> selection for it.
>>>
>>> In other words, even if we decide against adding support for the
>>> "x1e80100-tuxedo-elite-14-gen1", the same changes renamed to
>>> "x1e80100-medion-sprchrgd-14-s1" would still be valid and valuable.
>>
>> That's why you send such patches with RFC title and FIRST (literally
>> first) explanation in cover letter WHY, so people can decide.
>>
>>> I wouldn't expect any other changes to be needed, although obviously
>>> someone with access to the device should confirm that before submitting.
>>
>> You still cannot apply my review to that other board, so still wasted
>> time because I would need to review again.
> 
> I understand your frustration, but I'm still learning how to contribute
> to the Linux kernel. However, we may be able to find a constructive
> solution. Here at TUXEDO, we have the necessary Medion device and have
> already adapted the device tree.
> 
> Would you review a patch set for Medion SPRCHRGD 14 S1 Elite?

I think it's worth re-spining this patchset for the Medion SPRCHRGD 14 S1 Elite
with a comment in the DT mentioning the device tree is compatible with
the defunct Tuxedo Elite 14 Gen 1, since the Medion is an actual product
people can buy it's worth it.

I applied to first 3 patches, so you can remove them from the next version.

Neil

> 
> (This device is still on sale and can be found in many large electronics
> stores, at least in Germany.)
> 
> Best regards,
> Georg
> 
>>
>> Best regards,
>> Krzysztof
> 

Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Konrad Dybcio]

On 11/25/25 11:37 AM, Neil Armstrong wrote:
> On 11/24/25 15:09, Georg Gottleuber wrote:
>> Hello Krzysztof.
>>
>> Am 22.11.25 um 12:15 schrieb Krzysztof Kozlowski:
>>> On 22/11/2025 12:00, Stephan Gerhold wrote:
>>>> On Sat, Nov 22, 2025 at 11:16:25AM +0100, Krzysztof Kozlowski wrote:
>>>>> On 21/11/2025 15:26, Georg Gottleuber wrote:
>>>>>> [...]
>>>>>> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
>>>>>> Snapdragon X Elite SoC (X1E78100).

[...]

>> I understand your frustration, but I'm still learning how to contribute
>> to the Linux kernel. However, we may be able to find a constructive
>> solution. Here at TUXEDO, we have the necessary Medion device and have
>> already adapted the device tree.
>>
>> Would you review a patch set for Medion SPRCHRGD 14 S1 Elite?
> 
> I think it's worth re-spining this patchset for the Medion SPRCHRGD 14 S1 Elite
> with a comment in the DT mentioning the device tree is compatible with
> the defunct Tuxedo Elite 14 Gen 1, since the Medion is an actual product
> people can buy it's worth it.

+1, especially since you mentioned you have an actual Medion at hand

Konrad

Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100)

[Ettore Chimenti]

Hi,

On Tue, 25 Nov 2025 at 11:50, Konrad Dybcio
<konrad.dybcio@oss.qualcomm.com> wrote:
>
> On 11/25/25 11:37 AM, Neil Armstrong wrote:
> > On 11/24/25 15:09, Georg Gottleuber wrote:
> >> Hello Krzysztof.
> >>
> >> Am 22.11.25 um 12:15 schrieb Krzysztof Kozlowski:
> >>> On 22/11/2025 12:00, Stephan Gerhold wrote:
> >>>> On Sat, Nov 22, 2025 at 11:16:25AM +0100, Krzysztof Kozlowski wrote:
> >>>>> On 21/11/2025 15:26, Georg Gottleuber wrote:
> >>>>>> [...]
> >>>>>> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm
> >>>>>> Snapdragon X Elite SoC (X1E78100).
>
> [...]
>
> >> I understand your frustration, but I'm still learning how to contribute
> >> to the Linux kernel. However, we may be able to find a constructive
> >> solution. Here at TUXEDO, we have the necessary Medion device and have
> >> already adapted the device tree.
> >>
> >> Would you review a patch set for Medion SPRCHRGD 14 S1 Elite?
> >
> > I think it's worth re-spining this patchset for the Medion SPRCHRGD 14 S1 Elite
> > with a comment in the DT mentioning the device tree is compatible with
> > the defunct Tuxedo Elite 14 Gen 1, since the Medion is an actual product
> > people can buy it's worth it.
>
> +1, especially since you mentioned you have an actual Medion at hand

I agree, we can actually try to respin the patches for Medion if
TUXEDO is not worth it.

Regards,
Ettore

>
> Konrad