* [PATCH] nvmem: qnap-mcu-eeprom: Fix struct assignments using commas instead of semicolons
@ 2026-03-01 9:51 Felix Gu
2026-03-02 11:15 ` Heiko Stuebner
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Felix Gu @ 2026-03-01 9:51 UTC (permalink / raw)
To: Srinivas Kandagatla, Heiko Stuebner; +Cc: linux-kernel, Felix Gu
The nvcfg struct member assignments were incorrectly using commas instead
of semicolons.
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
drivers/nvmem/qnap-mcu-eeprom.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/nvmem/qnap-mcu-eeprom.c b/drivers/nvmem/qnap-mcu-eeprom.c
index 0b919895b3b2..07bdaa2a33fa 100644
--- a/drivers/nvmem/qnap-mcu-eeprom.c
+++ b/drivers/nvmem/qnap-mcu-eeprom.c
@@ -86,10 +86,10 @@ static int qnap_mcu_eeprom_probe(struct platform_device *pdev)
nvcfg.read_only = true;
nvcfg.root_only = false;
nvcfg.reg_read = qnap_mcu_eeprom_read;
- nvcfg.size = QNAP_MCU_EEPROM_SIZE,
- nvcfg.word_size = 1,
- nvcfg.stride = 1,
- nvcfg.priv = mcu,
+ nvcfg.size = QNAP_MCU_EEPROM_SIZE;
+ nvcfg.word_size = 1;
+ nvcfg.stride = 1;
+ nvcfg.priv = mcu;
ndev = devm_nvmem_register(&pdev->dev, &nvcfg);
if (IS_ERR(ndev))
---
base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
change-id: 20260301-qnap-f91e2ca99aab
Best regards,
--
Felix Gu <ustc.gu@gmail.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] nvmem: qnap-mcu-eeprom: Fix struct assignments using commas instead of semicolons
2026-03-01 9:51 [PATCH] nvmem: qnap-mcu-eeprom: Fix struct assignments using commas instead of semicolons Felix Gu
@ 2026-03-02 11:15 ` Heiko Stuebner
2026-03-03 9:25 ` Markus Elfring
2026-03-11 11:33 ` Srinivas Kandagatla
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2026-03-02 11:15 UTC (permalink / raw)
To: Srinivas Kandagatla, Felix Gu; +Cc: linux-kernel, Felix Gu
Am Sonntag, 1. März 2026, 10:51:16 Mitteleuropäische Normalzeit schrieb Felix Gu:
> The nvcfg struct member assignments were incorrectly using commas instead
> of semicolons.
>
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
I wonder how I managed to make that mistake :-)
Thanks for noticing
Heiko
> ---
> drivers/nvmem/qnap-mcu-eeprom.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/nvmem/qnap-mcu-eeprom.c b/drivers/nvmem/qnap-mcu-eeprom.c
> index 0b919895b3b2..07bdaa2a33fa 100644
> --- a/drivers/nvmem/qnap-mcu-eeprom.c
> +++ b/drivers/nvmem/qnap-mcu-eeprom.c
> @@ -86,10 +86,10 @@ static int qnap_mcu_eeprom_probe(struct platform_device *pdev)
> nvcfg.read_only = true;
> nvcfg.root_only = false;
> nvcfg.reg_read = qnap_mcu_eeprom_read;
> - nvcfg.size = QNAP_MCU_EEPROM_SIZE,
> - nvcfg.word_size = 1,
> - nvcfg.stride = 1,
> - nvcfg.priv = mcu,
> + nvcfg.size = QNAP_MCU_EEPROM_SIZE;
> + nvcfg.word_size = 1;
> + nvcfg.stride = 1;
> + nvcfg.priv = mcu;
>
> ndev = devm_nvmem_register(&pdev->dev, &nvcfg);
> if (IS_ERR(ndev))
>
> ---
> base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
> change-id: 20260301-qnap-f91e2ca99aab
>
> Best regards,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmem: qnap-mcu-eeprom: Fix struct assignments using commas instead of semicolons
2026-03-01 9:51 [PATCH] nvmem: qnap-mcu-eeprom: Fix struct assignments using commas instead of semicolons Felix Gu
2026-03-02 11:15 ` Heiko Stuebner
@ 2026-03-03 9:25 ` Markus Elfring
2026-03-11 11:33 ` Srinivas Kandagatla
2 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2026-03-03 9:25 UTC (permalink / raw)
To: Felix Gu, Heiko Stübner, Srinivas Kandagatla; +Cc: LKML, kernel-janitors
> The nvcfg struct member assignments were incorrectly using commas instead
> of semicolons.
Would a summary phrase like “Prefer separate variable assignment statements
over comma expressions” be more appropriate here?
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc2#n94
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmem: qnap-mcu-eeprom: Fix struct assignments using commas instead of semicolons
2026-03-01 9:51 [PATCH] nvmem: qnap-mcu-eeprom: Fix struct assignments using commas instead of semicolons Felix Gu
2026-03-02 11:15 ` Heiko Stuebner
2026-03-03 9:25 ` Markus Elfring
@ 2026-03-11 11:33 ` Srinivas Kandagatla
2 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2026-03-11 11:33 UTC (permalink / raw)
To: Heiko Stuebner, Felix Gu; +Cc: linux-kernel
On Sun, 01 Mar 2026 17:51:16 +0800, Felix Gu wrote:
> The nvcfg struct member assignments were incorrectly using commas instead
> of semicolons.
>
>
Applied, thanks!
[1/1] nvmem: qnap-mcu-eeprom: Fix struct assignments using commas instead of semicolons
commit: 5a992737b28d0c0869dccf64fa19b135d2c008d8
Best regards,
--
Srinivas Kandagatla <srini@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-11 11:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-01 9:51 [PATCH] nvmem: qnap-mcu-eeprom: Fix struct assignments using commas instead of semicolons Felix Gu
2026-03-02 11:15 ` Heiko Stuebner
2026-03-03 9:25 ` Markus Elfring
2026-03-11 11:33 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox