From: Daniel Walker <dwalker@fifo99.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Prasad <prasad@linux.vnet.ibm.com>,
Alan Stern <stern@rowland.harvard.edu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
Jiri Slaby <jirislaby@gmail.com>, Li Zefan <lizf@cn.fujitsu.com>,
Avi Kivity <avi@redhat.com>, Paul Mackerras <paulus@samba.org>,
Mike Galbraith <efault@gmx.de>,
Masami Hiramatsu <mhiramat@redhat.com>
Subject: Re: [PATCH 4/5] hw-breakpoints: Arbitrate access to pmu following registers constraints
Date: Thu, 10 Sep 2009 07:59:59 -0700 [thread overview]
Message-ID: <1252594799.30578.182.camel@desktop> (raw)
In-Reply-To: <1252594635.7205.39.camel@laptop>
On Thu, 2009-09-10 at 16:57 +0200, Peter Zijlstra wrote:
> On Thu, 2009-09-10 at 07:41 -0700, Daniel Walker wrote:
> > On Thu, 2009-09-10 at 10:29 +0200, Frederic Weisbecker wrote:
> >
> > > +static unsigned int max_task_bp_pinned(int cpu)
> > > {
> > > - if (atomic_inc_return(&bp_slot) == HBP_NUM) {
> > > - atomic_dec(&bp_slot);
> > > + int i;
> > > + unsigned int *tsk_pinned = per_cpu(task_bp_pinned, cpu);
> > >
> > > - return -ENOSPC;
> > > + for (i = HBP_NUM -1; i >= 0; i--) {
> > > + if (tsk_pinned[i] > 0)
> > > + return i + 1;
> > > }
> >
> > One checkpatch error in the code above..
> >
> > ERROR: need consistent spacing around '-' (ctx:WxV)
> > #206: FILE: kernel/hw_breakpoint.c:81:
> > + for (i = HBP_NUM -1; i >= 0; i--) {
> > ^
>
> Don't you have anything useful to do?
Don't get upset Peter ..
Daniel
next prev parent reply other threads:[~2009-09-10 14:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 8:29 [RFC GIT PULL] hw-breakpoints: Rewrite on top of perf counters Frederic Weisbecker
2009-09-10 8:29 ` [PATCH 1/5] perf_counter: Add open/close pmu callbacks Frederic Weisbecker
2009-09-10 11:22 ` Paul Mackerras
2009-09-10 18:46 ` Frederic Weisbecker
2009-09-10 8:29 ` [PATCH 2/5] perf_counter: Export various perf helpers for external users Frederic Weisbecker
2009-09-10 11:28 ` Paul Mackerras
2009-09-10 18:43 ` Frederic Weisbecker
2009-09-10 8:29 ` [PATCH 3/5] hw-breakpoints: Rewrite the hw-breakpoints layer on top of perf counters Frederic Weisbecker
2009-09-10 14:25 ` K.Prasad
2009-09-10 18:53 ` Frederic Weisbecker
2009-09-10 21:18 ` Peter Zijlstra
2009-09-14 21:18 ` Frederic Weisbecker
2009-09-14 17:17 ` K.Prasad
2009-09-14 21:33 ` Frederic Weisbecker
2009-09-11 22:09 ` Jan Kiszka
2009-09-14 3:41 ` Frederic Weisbecker
2009-09-14 6:24 ` Jan Kiszka
2009-09-14 18:01 ` Frederic Weisbecker
2009-09-14 17:28 ` K.Prasad
2009-09-14 21:36 ` Frederic Weisbecker
2009-09-10 8:29 ` [PATCH 4/5] hw-breakpoints: Arbitrate access to pmu following registers constraints Frederic Weisbecker
2009-09-10 14:41 ` Daniel Walker
2009-09-10 14:57 ` Peter Zijlstra
2009-09-10 14:59 ` Daniel Walker [this message]
2009-09-10 15:02 ` Steven Rostedt
2009-09-10 18:53 ` Frederic Weisbecker
2009-09-10 8:29 ` [PATCH 5/5] ksym_tracer: Remove KSYM_SELFTEST_ENTRY Frederic Weisbecker
2009-09-10 10:09 ` [RFC GIT PULL] hw-breakpoints: Rewrite on top of perf counters Paul Mackerras
2009-09-10 17:23 ` Ingo Molnar
2009-09-10 18:24 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252594799.30578.182.camel@desktop \
--to=dwalker@fifo99.com \
--cc=acme@redhat.com \
--cc=avi@redhat.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=prasad@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox