The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] hpimsgx: fix wrong sizeof
@ 2010-07-28  8:58 Axel Lin
  2010-07-28  9:54 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-07-28  8:58 UTC (permalink / raw)
  To: linux-kernel; +Cc: Jaroslav Kysela, Takashi Iwai, Eliot Blennerhassett

The correct size should be sizeof(gRESP_HPI_SUBSYS_FIND_ADAPTERS),
sizeof(&gRESP_HPI_SUBSYS_FIND_ADAPTERS) is incorrect.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 sound/pci/asihpi/hpimsgx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/pci/asihpi/hpimsgx.c b/sound/pci/asihpi/hpimsgx.c
index 2ee90dc..f01ab96 100644
--- a/sound/pci/asihpi/hpimsgx.c
+++ b/sound/pci/asihpi/hpimsgx.c
@@ -741,7 +741,7 @@ static void HPIMSGX__reset(u16 adapter_index)
 		hpi_init_response(&hr, HPI_OBJ_SUBSYSTEM,
 			HPI_SUBSYS_FIND_ADAPTERS, 0);
 		memcpy(&gRESP_HPI_SUBSYS_FIND_ADAPTERS, &hr,
-			sizeof(&gRESP_HPI_SUBSYS_FIND_ADAPTERS));
+			sizeof(gRESP_HPI_SUBSYS_FIND_ADAPTERS));
 
 		for (adapter = 0; adapter < HPI_MAX_ADAPTERS; adapter++) {
 
-- 
1.5.4.3




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] hpimsgx: fix wrong sizeof
  2010-07-28  8:58 [PATCH] hpimsgx: fix wrong sizeof Axel Lin
@ 2010-07-28  9:54 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2010-07-28  9:54 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Jaroslav Kysela, Eliot Blennerhassett

At Wed, 28 Jul 2010 16:58:42 +0800,
Axel Lin wrote:
> 
> The correct size should be sizeof(gRESP_HPI_SUBSYS_FIND_ADAPTERS),
> sizeof(&gRESP_HPI_SUBSYS_FIND_ADAPTERS) is incorrect.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Applied now.  Thanks.


Takashi

> ---
>  sound/pci/asihpi/hpimsgx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/pci/asihpi/hpimsgx.c b/sound/pci/asihpi/hpimsgx.c
> index 2ee90dc..f01ab96 100644
> --- a/sound/pci/asihpi/hpimsgx.c
> +++ b/sound/pci/asihpi/hpimsgx.c
> @@ -741,7 +741,7 @@ static void HPIMSGX__reset(u16 adapter_index)
>  		hpi_init_response(&hr, HPI_OBJ_SUBSYSTEM,
>  			HPI_SUBSYS_FIND_ADAPTERS, 0);
>  		memcpy(&gRESP_HPI_SUBSYS_FIND_ADAPTERS, &hr,
> -			sizeof(&gRESP_HPI_SUBSYS_FIND_ADAPTERS));
> +			sizeof(gRESP_HPI_SUBSYS_FIND_ADAPTERS));
>  
>  		for (adapter = 0; adapter < HPI_MAX_ADAPTERS; adapter++) {
>  
> -- 
> 1.5.4.3
> 
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-07-28  9:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-28  8:58 [PATCH] hpimsgx: fix wrong sizeof Axel Lin
2010-07-28  9:54 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox