From: Peter Zijlstra <peterz@infradead.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Don Zickus <dzickus@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Vivek Goyal <vgoyal@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Jason Wessel <jason.wessel@windriver.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Haren Myneni <hbabu@us.ibm.com>
Subject: Re: perf hw in kexeced kernel broken in tip
Date: Wed, 08 Dec 2010 11:39:53 +0100 [thread overview]
Message-ID: <1291804793.28378.0.camel@laptop> (raw)
In-Reply-To: <4CFED0AE.9000900@kernel.org>
On Tue, 2010-12-07 at 16:26 -0800, Yinghai Lu wrote:
> > +++ b/arch/x86/kernel/cpu/perf_event.c
> > @@ -377,10 +377,10 @@ static bool check_hw_exists(void)
> > u64 val, val_new = 0;
> > int ret = 0;
> >
> > - val = 0xabcdUL;
> > - ret |= checking_wrmsrl(x86_pmu.perfctr, val);
> > - ret |= rdmsrl_safe(x86_pmu.perfctr, &val_new);
> > - if (ret || val != val_new)
> > + val = 0xabUL;
> > + ret |= checking_wrmsrl(x86_pmu.eventsel, val);
> > + ret |= rdmsrl_safe(x86_pmu.eventsel, &val_new);
> > + if (ret || val != (val_new & 0xFF))
> > return false;
> >
> > return true;
>
> Thanks. it fixes the problem.
>
Won't merge it though, I think it stinks..
next prev parent reply other threads:[~2010-12-08 10:40 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 8:00 perf hw in kexeced kernel broken in tip Yinghai Lu
2010-12-01 11:27 ` Peter Zijlstra
2010-12-01 16:06 ` Vivek Goyal
2010-12-01 16:11 ` Peter Zijlstra
2010-12-01 16:23 ` Vivek Goyal
2010-12-01 19:38 ` Peter Zijlstra
2010-12-01 19:46 ` Vivek Goyal
2010-12-01 19:49 ` Peter Zijlstra
2010-12-01 19:58 ` Vivek Goyal
2010-12-01 20:07 ` Peter Zijlstra
2010-12-01 21:48 ` Eric W. Biederman
2010-12-02 5:23 ` Don Zickus
2010-12-02 7:34 ` Peter Zijlstra
2010-12-02 16:15 ` Don Zickus
2010-12-07 23:30 ` Peter Zijlstra
2010-12-08 14:01 ` Don Zickus
2010-12-08 14:20 ` Peter Zijlstra
2010-12-08 14:42 ` Vivek Goyal
2010-12-08 14:48 ` Peter Zijlstra
2010-12-08 15:02 ` Vivek Goyal
2010-12-08 15:15 ` Peter Zijlstra
2010-12-08 15:22 ` Vivek Goyal
2010-12-08 21:16 ` Eric W. Biederman
2010-12-08 14:59 ` Peter Zijlstra
2010-12-08 18:43 ` Yinghai Lu
2010-12-08 19:01 ` Don Zickus
2010-12-08 19:05 ` Yinghai Lu
2010-12-08 19:17 ` Peter Zijlstra
2010-12-08 19:20 ` Yinghai Lu
2010-12-08 19:06 ` Peter Zijlstra
2010-12-08 19:20 ` Yinghai Lu
2010-12-08 22:37 ` Don Zickus
2010-12-08 23:20 ` Eric W. Biederman
2010-12-09 4:34 ` Don Zickus
2010-12-09 20:20 ` Don Zickus
2010-12-09 20:44 ` Cyrill Gorcunov
2010-12-08 14:33 ` Peter Zijlstra
2010-12-08 14:39 ` Vivek Goyal
2010-12-07 21:16 ` Don Zickus
2010-12-08 0:26 ` Yinghai Lu
2010-12-08 10:39 ` Peter Zijlstra [this message]
2010-12-01 20:41 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291804793.28378.0.camel@laptop \
--to=peterz@infradead.org \
--cc=dzickus@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hbabu@us.ibm.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=vgoyal@redhat.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox