[PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data
@ 2011-06-22  4:28 Ankur Patel
  0 siblings, 0 replies; 6+ messages in thread
From: Ankur Patel @ 2011-06-22  4:28 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck; +Cc: linux-kernel, Ankur Patel

From: Ankur Patel <ankur.patel@quipment.in>

In tmp102.ko driver support for 12 bit data is added.

Signed-off-by: Ankur Patel <ankur.patel@quipment.in>
---
 drivers/hwmon/tmp102.c |   28 ++++++++++++++++++++--------
 1 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c
index 5bd1949..6e03a87 100644
--- a/drivers/hwmon/tmp102.c
+++ b/drivers/hwmon/tmp102.c
@@ -47,6 +47,9 @@
 #define	TMP102_TLOW_REG			0x02
 #define	TMP102_THIGH_REG		0x03
 
+#define TMP102_CONFIG  (TMP102_CONF_TM | TMP102_CONF_EM | TMP102_CONF_CR1)
+#define TMP102_CONFIG_RD_ONLY (TMP102_CONF_R0 | TMP102_CONF_R1 | TMP102_CONF_AL)
+
 struct tmp102 {
 	struct device *hwmon_dev;
 	struct mutex lock;
@@ -68,16 +71,26 @@ static inline int tmp102_write_reg(struct i2c_client *client, u8 reg, u16 val)
 	return i2c_smbus_write_word_data(client, reg, swab16(val));
 }
 
-/* convert left adjusted 13-bit TMP102 register value to milliCelsius */
+/* convert left adjusted TMP102 register value to milliCelsius for 13 bit &
+ * 12 bit by dividing with 128 & 256 respectively*/
 static inline int tmp102_reg_to_mC(s16 val)
 {
-	return ((val & ~0x01) * 1000) / 128;
+	#if TMP102_CONFIG & TMP102_CONF_EM
+		return ((val & ~0x01) * 1000) / 128;
+	#else
+		return ((val & ~0x01) * 1000) / 256;
+	#endif
 }
 
-/* convert milliCelsius to left adjusted 13-bit TMP102 register value */
+/* convert milliCelsius to left adjusted TMP102 register value for 13 bit &
+ * 12 bit by multiplying with 128 & 256 respectivley*/
 static inline u16 tmp102_mC_to_reg(int val)
 {
-	return (val * 128) / 1000;
+	#if TMP102_CONFIG & TMP102_CONF_EM
+		return (val * 128) / 1000;
+	#else
+		return (val * 256) / 1000;
+	#endif
 }
 
 static const u8 tmp102_reg[] = {
@@ -126,7 +139,9 @@ static ssize_t tmp102_set_temp(struct device *dev,
 
 	if (strict_strtol(buf, 10, &val) < 0)
 		return -EINVAL;
-	val = SENSORS_LIMIT(val, -256000, 255000);
+	/* It will limit the Input temperature range to -55 Deg. Cel to
+	 * 150 Deg. Cel */
+	val = SENSORS_LIMIT(val, -55000, 150000);
 
 	mutex_lock(&tmp102->lock);
 	tmp102->temp[sda->index] = val;
@@ -155,9 +170,6 @@ static const struct attribute_group tmp102_attr_group = {
 	.attrs = tmp102_attributes,
 };
 
-#define TMP102_CONFIG  (TMP102_CONF_TM | TMP102_CONF_EM | TMP102_CONF_CR1)
-#define TMP102_CONFIG_RD_ONLY (TMP102_CONF_R0 | TMP102_CONF_R1 | TMP102_CONF_AL)
-
 static int __devinit tmp102_probe(struct i2c_client *client,
 				  const struct i2c_device_id *id)
 {
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data
@ 2011-06-22  2:21 Ankur Patel
  2011-06-23  8:06 ` Jean Delvare
  0 siblings, 1 reply; 6+ messages in thread
From: Ankur Patel @ 2011-06-22  2:21 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck; +Cc: linux-kernel

From: Ankur Patel <ankur.patel@quipment.in>

In the tmp102.ko driver support for 12 bit data is added. Also, the
sysfs names are replaced with the actual chip supported fuctionality
names.

Signed-off-by: Ankur Patel <ankur.patel@quipment.in>
---
 drivers/hwmon/tmp102.c |   40 ++++++++++++++++++++++++++--------------
 1 files changed, 26 insertions(+), 14 deletions(-)

diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c
index 5bd1949..a13b572 100644
--- a/drivers/hwmon/tmp102.c
+++ b/drivers/hwmon/tmp102.c
@@ -47,6 +47,9 @@
 #define	TMP102_TLOW_REG			0x02
 #define	TMP102_THIGH_REG		0x03
 
+#define TMP102_CONFIG  (TMP102_CONF_TM | TMP102_CONF_EM | TMP102_CONF_CR1)
+#define TMP102_CONFIG_RD_ONLY (TMP102_CONF_R0 | TMP102_CONF_R1 | TMP102_CONF_AL)
+
 struct tmp102 {
 	struct device *hwmon_dev;
 	struct mutex lock;
@@ -68,16 +71,26 @@ static inline int tmp102_write_reg(struct i2c_client *client, u8 reg, u16 val)
 	return i2c_smbus_write_word_data(client, reg, swab16(val));
 }
 
-/* convert left adjusted 13-bit TMP102 register value to milliCelsius */
+/* convert left adjusted TMP102 register value to milliCelsius for 13 bit &
+ * 12 bit by dividing with 128 & 256 respectively*/
 static inline int tmp102_reg_to_mC(s16 val)
 {
-	return ((val & ~0x01) * 1000) / 128;
+	#if TMP102_CONFIG & TMP102_CONF_EM
+		return ((val & ~0x01) * 1000) / 128;
+	#else
+		return ((val & ~0x01) * 1000) / 256;
+	#endif
 }
 
-/* convert milliCelsius to left adjusted 13-bit TMP102 register value */
+/* convert milliCelsius to left adjusted TMP102 register value for 13 bit &
+ * 12 bit by multiplying with 128 & 256 respectivley*/
 static inline u16 tmp102_mC_to_reg(int val)
 {
-	return (val * 128) / 1000;
+	#if TMP102_CONFIG & TMP102_CONF_EM
+		return (val * 128) / 1000;
+	#else
+		return (val * 256) / 1000;
+	#endif
 }
 
 static const u8 tmp102_reg[] = {
@@ -126,7 +139,9 @@ static ssize_t tmp102_set_temp(struct device *dev,
 
 	if (strict_strtol(buf, 10, &val) < 0)
 		return -EINVAL;
-	val = SENSORS_LIMIT(val, -256000, 255000);
+	/* It will limit the Input temperature range to -55 Deg. Cel to
+	 * 150 Deg. Cel */
+	val = val = SENSORS_LIMIT(val, -55000, 150000);
 
 	mutex_lock(&tmp102->lock);
 	tmp102->temp[sda->index] = val;
@@ -138,16 +153,16 @@ static ssize_t tmp102_set_temp(struct device *dev,
 
 static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, tmp102_show_temp, NULL , 0);
 
-static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IWUSR | S_IRUGO, tmp102_show_temp,
-			  tmp102_set_temp, 1);
+static SENSOR_DEVICE_ATTR(temp1_low_thresold, S_IWUSR | S_IRUGO,
+					tmp102_show_temp, tmp102_set_temp, 1);
 
-static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, tmp102_show_temp,
-			  tmp102_set_temp, 2);
+static SENSOR_DEVICE_ATTR(temp1_max_thresold, S_IWUSR | S_IRUGO,
+\					tmp102_show_temp, tmp102_set_temp, 2);
 
 static struct attribute *tmp102_attributes[] = {
 	&sensor_dev_attr_temp1_input.dev_attr.attr,
-	&sensor_dev_attr_temp1_max_hyst.dev_attr.attr,
-	&sensor_dev_attr_temp1_max.dev_attr.attr,
+	&sensor_dev_attr_temp1_low_thresold.dev_attr.attr,
+	&sensor_dev_attr_temp1_max_thresold.dev_attr.attr,
 	NULL
 };
 
@@ -155,9 +170,6 @@ static const struct attribute_group tmp102_attr_group = {
 	.attrs = tmp102_attributes,
 };
 
-#define TMP102_CONFIG  (TMP102_CONF_TM | TMP102_CONF_EM | TMP102_CONF_CR1)
-#define TMP102_CONFIG_RD_ONLY (TMP102_CONF_R0 | TMP102_CONF_R1 | TMP102_CONF_AL)
-
 static int __devinit tmp102_probe(struct i2c_client *client,
 				  const struct i2c_device_id *id)
 {
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data
  2011-06-22  2:21 Ankur Patel
@ 2011-06-23  8:06 ` Jean Delvare
       [not found]   ` <BANLkTikLSmXKG67NroavRb+FjzVE5ie21Q@mail.gmail.com>
  0 siblings, 1 reply; 6+ messages in thread
From: Jean Delvare @ 2011-06-23  8:06 UTC (permalink / raw)
  To: Ankur Patel; +Cc: Guenter Roeck, linux-kernel

On Wed, 22 Jun 2011 07:51:39 +0530, Ankur Patel wrote:
> From: Ankur Patel <ankur.patel@quipment.in>
> 
> In the tmp102.ko driver support for 12 bit data is added. Also, the
> sysfs names are replaced with the actual chip supported fuctionality
> names.

Nack. These attribute names are standard, see
Documentation/hwmon/sysfs-interface. You don't get to change them.

What problem were you trying to solve? libsensors expects the attribute
names which are in use today.

> 
> Signed-off-by: Ankur Patel <ankur.patel@quipment.in>
> ---
>  drivers/hwmon/tmp102.c |   40 ++++++++++++++++++++++++++--------------
>  1 files changed, 26 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c
> index 5bd1949..a13b572 100644
> --- a/drivers/hwmon/tmp102.c
> +++ b/drivers/hwmon/tmp102.c
> @@ -47,6 +47,9 @@
>  #define	TMP102_TLOW_REG			0x02
>  #define	TMP102_THIGH_REG		0x03
>  
> +#define TMP102_CONFIG  (TMP102_CONF_TM | TMP102_CONF_EM | TMP102_CONF_CR1)
> +#define TMP102_CONFIG_RD_ONLY (TMP102_CONF_R0 | TMP102_CONF_R1 | TMP102_CONF_AL)
> +
>  struct tmp102 {
>  	struct device *hwmon_dev;
>  	struct mutex lock;
> @@ -68,16 +71,26 @@ static inline int tmp102_write_reg(struct i2c_client *client, u8 reg, u16 val)
>  	return i2c_smbus_write_word_data(client, reg, swab16(val));
>  }
>  
> -/* convert left adjusted 13-bit TMP102 register value to milliCelsius */
> +/* convert left adjusted TMP102 register value to milliCelsius for 13 bit &
> + * 12 bit by dividing with 128 & 256 respectively*/
>  static inline int tmp102_reg_to_mC(s16 val)
>  {
> -	return ((val & ~0x01) * 1000) / 128;
> +	#if TMP102_CONFIG & TMP102_CONF_EM
> +		return ((val & ~0x01) * 1000) / 128;
> +	#else
> +		return ((val & ~0x01) * 1000) / 256;
> +	#endif
>  }
>  
> -/* convert milliCelsius to left adjusted 13-bit TMP102 register value */
> +/* convert milliCelsius to left adjusted TMP102 register value for 13 bit &
> + * 12 bit by multiplying with 128 & 256 respectivley*/
>  static inline u16 tmp102_mC_to_reg(int val)
>  {
> -	return (val * 128) / 1000;
> +	#if TMP102_CONFIG & TMP102_CONF_EM
> +		return (val * 128) / 1000;
> +	#else
> +		return (val * 256) / 1000;
> +	#endif
>  }
>  
>  static const u8 tmp102_reg[] = {
> @@ -126,7 +139,9 @@ static ssize_t tmp102_set_temp(struct device *dev,
>  
>  	if (strict_strtol(buf, 10, &val) < 0)
>  		return -EINVAL;
> -	val = SENSORS_LIMIT(val, -256000, 255000);
> +	/* It will limit the Input temperature range to -55 Deg. Cel to
> +	 * 150 Deg. Cel */
> +	val = val = SENSORS_LIMIT(val, -55000, 150000);
>  
>  	mutex_lock(&tmp102->lock);
>  	tmp102->temp[sda->index] = val;
> @@ -138,16 +153,16 @@ static ssize_t tmp102_set_temp(struct device *dev,
>  
>  static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, tmp102_show_temp, NULL , 0);
>  
> -static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IWUSR | S_IRUGO, tmp102_show_temp,
> -			  tmp102_set_temp, 1);
> +static SENSOR_DEVICE_ATTR(temp1_low_thresold, S_IWUSR | S_IRUGO,
> +					tmp102_show_temp, tmp102_set_temp, 1);
>  
> -static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, tmp102_show_temp,
> -			  tmp102_set_temp, 2);
> +static SENSOR_DEVICE_ATTR(temp1_max_thresold, S_IWUSR | S_IRUGO,
> +\					tmp102_show_temp, tmp102_set_temp, 2);
>  
>  static struct attribute *tmp102_attributes[] = {
>  	&sensor_dev_attr_temp1_input.dev_attr.attr,
> -	&sensor_dev_attr_temp1_max_hyst.dev_attr.attr,
> -	&sensor_dev_attr_temp1_max.dev_attr.attr,
> +	&sensor_dev_attr_temp1_low_thresold.dev_attr.attr,
> +	&sensor_dev_attr_temp1_max_thresold.dev_attr.attr,
>  	NULL
>  };
>  
> @@ -155,9 +170,6 @@ static const struct attribute_group tmp102_attr_group = {
>  	.attrs = tmp102_attributes,
>  };
>  
> -#define TMP102_CONFIG  (TMP102_CONF_TM | TMP102_CONF_EM | TMP102_CONF_CR1)
> -#define TMP102_CONFIG_RD_ONLY (TMP102_CONF_R0 | TMP102_CONF_R1 | TMP102_CONF_AL)
> -
>  static int __devinit tmp102_probe(struct i2c_client *client,
>  				  const struct i2c_device_id *id)
>  {


-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 6+ messages in thread

[parent not found: <BANLkTikLSmXKG67NroavRb+FjzVE5ie21Q@mail.gmail.com>]

* Re: [PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data
       [not found]   ` <BANLkTikLSmXKG67NroavRb+FjzVE5ie21Q@mail.gmail.com>
@ 2011-06-23  8:45     ` Jean Delvare
       [not found]       ` <BANLkTikYbpeSbt5VHndJnsWXax1MX+Xk-w@mail.gmail.com>
  0 siblings, 1 reply; 6+ messages in thread
From: Jean Delvare @ 2011-06-23  8:45 UTC (permalink / raw)
  To: Ankur Patel; +Cc: Guenter Roeck, linux-kernel

On Thu, 23 Jun 2011 13:56:53 +0530, Ankur Patel wrote:
> On Thu, Jun 23, 2011 at 1:36 PM, Jean Delvare <khali@linux-fr.org> wrote:
> 
> > On Wed, 22 Jun 2011 07:51:39 +0530, Ankur Patel wrote:
> > > From: Ankur Patel <ankur.patel@quipment.in>
> > >
> > > In the tmp102.ko driver support for 12 bit data is added. Also, the
> > > sysfs names are replaced with the actual chip supported fuctionality
> > > names.
> >
> > Nack. These attribute names are standard, see
> > Documentation/hwmon/sysfs-interface. You don't get to change them.
> >
> >
> > What problem were you trying to solve? libsensors expects the attribute
> > names which are in use today.
> >
> > Agree, But using temp1_max_hyst as an attribute for presenting low level
> threshold, will it not more feasible to use temp1_low instead?.

No. This isn't a min temperature limit. Please read the TMP102
datasheet and in particular Figure 10 "Output Transfer Function
Diagrams" and the description of the AL configuration bit.

-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 6+ messages in thread

[parent not found: <BANLkTikYbpeSbt5VHndJnsWXax1MX+Xk-w@mail.gmail.com>]

* Re: [PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data
       [not found]       ` <BANLkTikYbpeSbt5VHndJnsWXax1MX+Xk-w@mail.gmail.com>
@ 2011-06-23  9:08         ` Jean Delvare
  2011-06-23  9:26           ` Ankur Patel
  0 siblings, 1 reply; 6+ messages in thread
From: Jean Delvare @ 2011-06-23  9:08 UTC (permalink / raw)
  To: Ankur Patel; +Cc: Guenter Roeck, linux-kernel

On Thu, 23 Jun 2011 14:35:31 +0530, Ankur Patel wrote:
> On Thu, Jun 23, 2011 at 2:15 PM, Jean Delvare <khali@linux-fr.org> wrote:
> 
> > On Thu, 23 Jun 2011 13:56:53 +0530, Ankur Patel wrote:
> > > On Thu, Jun 23, 2011 at 1:36 PM, Jean Delvare <khali@linux-fr.org>
> > wrote:
> > >
> > > > On Wed, 22 Jun 2011 07:51:39 +0530, Ankur Patel wrote:
> > > > > From: Ankur Patel <ankur.patel@quipment.in>
> > > > >
> > > > > In the tmp102.ko driver support for 12 bit data is added. Also, the
> > > > > sysfs names are replaced with the actual chip supported fuctionality
> > > > > names.
> > > >
> > > > Nack. These attribute names are standard, see
> > > > Documentation/hwmon/sysfs-interface. You don't get to change them.
> > > >
> > > >
> > > > What problem were you trying to solve? libsensors expects the attribute
> > > > names which are in use today.
> > > >
> > > > Agree, But using temp1_max_hyst as an attribute for presenting low
> > level
> > > threshold, will it not more feasible to use temp1_low instead?.
> >
> > No. This isn't a min temperature limit. Please read the TMP102
> > datasheet and in particular Figure 10 "Output Transfer Function
> > Diagrams" and the description of the AL configuration bit.
> >
> > Understood. Thank you. I am reverting back the changes for sysfs attribute
> names in the submitted patch to original. Do you have other Issue apart from
> that?

I didn't read the patch, only the header. So I don't know yet. Just
resubmit and wait for review.

-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data
  2011-06-23  9:08         ` Jean Delvare
@ 2011-06-23  9:26           ` Ankur Patel
  0 siblings, 0 replies; 6+ messages in thread
From: Ankur Patel @ 2011-06-23  9:26 UTC (permalink / raw)
  To: Jean Delvare; +Cc: Guenter Roeck, linux-kernel

On Thu, Jun 23, 2011 at 2:38 PM, Jean Delvare <khali@linux-fr.org> wrote:
>
> On Thu, 23 Jun 2011 14:35:31 +0530, Ankur Patel wrote:
> > On Thu, Jun 23, 2011 at 2:15 PM, Jean Delvare <khali@linux-fr.org> wrote:
> >
> > > On Thu, 23 Jun 2011 13:56:53 +0530, Ankur Patel wrote:
> > > > On Thu, Jun 23, 2011 at 1:36 PM, Jean Delvare <khali@linux-fr.org>
> > > wrote:
> > > >
> > > > > On Wed, 22 Jun 2011 07:51:39 +0530, Ankur Patel wrote:
> > > > > > From: Ankur Patel <ankur.patel@quipment.in>
> > > > > >
> > > > > > In the tmp102.ko driver support for 12 bit data is added. Also, the
> > > > > > sysfs names are replaced with the actual chip supported fuctionality
> > > > > > names.
> > > > >
> > > > > Nack. These attribute names are standard, see
> > > > > Documentation/hwmon/sysfs-interface. You don't get to change them.
> > > > >
> > > > >
> > > > > What problem were you trying to solve? libsensors expects the attribute
> > > > > names which are in use today.
> > > > >
> > > > > Agree, But using temp1_max_hyst as an attribute for presenting low
> > > level
> > > > threshold, will it not more feasible to use temp1_low instead?.
> > >
> > > No. This isn't a min temperature limit. Please read the TMP102
> > > datasheet and in particular Figure 10 "Output Transfer Function
> > > Diagrams" and the description of the AL configuration bit.
> > >
> > > Understood. Thank you. I am reverting back the changes for sysfs attribute
> > names in the submitted patch to original. Do you have other Issue apart from
> > that?
>
> I didn't read the patch, only the header. So I don't know yet. Just
> resubmit and wait for review.
>
> --
> Jean Delvare

I forgot to switch from HTML to plain text and it get bounced from
mailing list. I will resubmit patch soon.

Thank you,
Ankur.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-06-23 10:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-22  4:28 [PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data Ankur Patel
  -- strict thread matches above, loose matches on Subject: below --
2011-06-22  2:21 Ankur Patel
2011-06-23  8:06 ` Jean Delvare
     [not found]   ` <BANLkTikLSmXKG67NroavRb+FjzVE5ie21Q@mail.gmail.com>
2011-06-23  8:45     ` Jean Delvare
     [not found]       ` <BANLkTikYbpeSbt5VHndJnsWXax1MX+Xk-w@mail.gmail.com>
2011-06-23  9:08         ` Jean Delvare
2011-06-23  9:26           ` Ankur Patel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox