public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephane Eranian <eranian@google.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com,
	acme@redhat.com, jolsa@redhat.com, namhyung.kim@lge.com
Subject: [PATCH v4 15/18] perf: add PERF_RECORD_MISC_MMAP_DATA to RECORD_MMAP
Date: Thu, 20 Dec 2012 16:41:45 +0100	[thread overview]
Message-ID: <1356018108-6081-16-git-send-email-eranian@google.com> (raw)
In-Reply-To: <1356018108-6081-1-git-send-email-eranian@google.com>

Type of mapping was lost and made it hard for a tool
to distinguish code vs. data mmaps. Perf has the ability
to distinguish the two.

Use a bit in the header->misc bitmask to keep track of
the mmap type. If PERF_RECORD_MISC_MMAP_DATA is set then
the mapping is not executable (!VM_EXEC). If not set, then
the mapping is executable.

Signed-off-by: Stephane Eranian <eranian@google.com>
---
 include/uapi/linux/perf_event.h |    1 +
 kernel/events/core.c            |    3 +++
 2 files changed, 4 insertions(+)

diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index b2a78bb..0fa3feb 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -446,6 +446,7 @@ struct perf_event_mmap_page {
 #define PERF_RECORD_MISC_GUEST_KERNEL		(4 << 0)
 #define PERF_RECORD_MISC_GUEST_USER		(5 << 0)
 
+#define PERF_RECORD_MISC_MMAP_DATA		(1 << 13)
 /*
  * Indicates that the content of PERF_SAMPLE_IP points to
  * the actual instruction that triggered the event. See also
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 3366f89..3a19a45 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -4764,6 +4764,9 @@ static void perf_event_mmap_event(struct perf_mmap_event *mmap_event)
 	mmap_event->file_name = name;
 	mmap_event->file_size = size;
 
+	if (!(vma->vm_flags & VM_EXEC))
+		mmap_event->event_id.header.misc |= PERF_RECORD_MISC_MMAP_DATA;
+
 	mmap_event->event_id.header.size = sizeof(mmap_event->event_id) + size;
 
 	rcu_read_lock();
-- 
1.7.9.5


  parent reply	other threads:[~2012-12-20 15:49 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20 15:41 [PATCH v4 00/18] perf: add memory access sampling support Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 01/18] perf, x86: Support CPU specific sysfs events Stephane Eranian
2013-01-02 14:04   ` Jiri Olsa
2013-01-02 17:07     ` Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 02/18] perf/x86: improve sysfs event mapping with event string Stephane Eranian
2013-01-02 14:05   ` Jiri Olsa
2012-12-20 15:41 ` [PATCH v4 03/18] perf/x86: add flags to event constraints Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 04/18] perf, core: Add a concept of a weightened sample Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 05/18] perf: add minimal support for PERF_SAMPLE_WEIGHT Stephane Eranian
2013-01-02 14:07   ` Jiri Olsa
2013-01-07 13:10     ` Stephane Eranian
2013-01-07 13:27       ` Jiri Olsa
2013-01-07 14:03         ` Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 06/18] perf: add support for PERF_SAMPLE_ADDR in dump_sampple() Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 07/18] perf: add generic memory sampling interface Stephane Eranian
2013-01-05 18:38   ` Jiri Olsa
2013-01-05 19:05   ` Jiri Olsa
2013-01-06  6:43     ` Andi Kleen
2012-12-20 15:41 ` [PATCH v4 08/18] perf/x86: add memory profiling via PEBS Load Latency Stephane Eranian
2013-01-05 18:43   ` Jiri Olsa
2013-01-06 20:37     ` Stephane Eranian
2013-01-07 10:11       ` Jiri Olsa
2013-01-07 12:34         ` Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 09/18] perf/x86: export PEBS load latency threshold register to sysfs Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 10/18] perf/x86: add support for PEBS Precise Store Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 11/18] perf tools: add mem access sampling core support Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 12/18] perf report: add support for mem access profiling Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 13/18] perf record: " Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 14/18] perf tools: add new mem command for memory " Stephane Eranian
2013-01-02 14:16   ` Jiri Olsa
2013-01-07 13:04     ` Stephane Eranian
2013-01-07 13:08       ` Jiri Olsa
2012-12-20 15:41 ` Stephane Eranian [this message]
2012-12-20 15:41 ` [PATCH v4 16/18] perf tools: detect data vs. text mappings Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 17/18] perf tools: Ignore ABS symbols when loading data maps Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 18/18] perf tools: Fix output of symbol_daddr offset Stephane Eranian
2012-12-20 16:05 ` [PATCH v4 00/18] perf: add memory access sampling support Jiri Olsa
2012-12-20 16:07   ` Stephane Eranian
2012-12-20 16:12     ` Jiri Olsa
2012-12-20 16:44       ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356018108-6081-16-git-send-email-eranian@google.com \
    --to=eranian@google.com \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung.kim@lge.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox