From: Andi Kleen <ak@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Stephane Eranian <eranian@google.com>,
linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, acme@redhat.com, namhyung.kim@lge.com
Subject: Re: [PATCH v4 07/18] perf: add generic memory sampling interface
Date: Sat, 5 Jan 2013 22:43:54 -0800 [thread overview]
Message-ID: <20130106064354.GK29714@tassilo.jf.intel.com> (raw)
In-Reply-To: <20130105190552.GC995@krava.brq.redhat.com>
> Why dont use enums for this?
enums can have unpredictable signed/unsignedness issues. #defines for
hardware constants is usually far safer.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2013-01-06 6:43 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 15:41 [PATCH v4 00/18] perf: add memory access sampling support Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 01/18] perf, x86: Support CPU specific sysfs events Stephane Eranian
2013-01-02 14:04 ` Jiri Olsa
2013-01-02 17:07 ` Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 02/18] perf/x86: improve sysfs event mapping with event string Stephane Eranian
2013-01-02 14:05 ` Jiri Olsa
2012-12-20 15:41 ` [PATCH v4 03/18] perf/x86: add flags to event constraints Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 04/18] perf, core: Add a concept of a weightened sample Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 05/18] perf: add minimal support for PERF_SAMPLE_WEIGHT Stephane Eranian
2013-01-02 14:07 ` Jiri Olsa
2013-01-07 13:10 ` Stephane Eranian
2013-01-07 13:27 ` Jiri Olsa
2013-01-07 14:03 ` Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 06/18] perf: add support for PERF_SAMPLE_ADDR in dump_sampple() Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 07/18] perf: add generic memory sampling interface Stephane Eranian
2013-01-05 18:38 ` Jiri Olsa
2013-01-05 19:05 ` Jiri Olsa
2013-01-06 6:43 ` Andi Kleen [this message]
2012-12-20 15:41 ` [PATCH v4 08/18] perf/x86: add memory profiling via PEBS Load Latency Stephane Eranian
2013-01-05 18:43 ` Jiri Olsa
2013-01-06 20:37 ` Stephane Eranian
2013-01-07 10:11 ` Jiri Olsa
2013-01-07 12:34 ` Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 09/18] perf/x86: export PEBS load latency threshold register to sysfs Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 10/18] perf/x86: add support for PEBS Precise Store Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 11/18] perf tools: add mem access sampling core support Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 12/18] perf report: add support for mem access profiling Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 13/18] perf record: " Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 14/18] perf tools: add new mem command for memory " Stephane Eranian
2013-01-02 14:16 ` Jiri Olsa
2013-01-07 13:04 ` Stephane Eranian
2013-01-07 13:08 ` Jiri Olsa
2012-12-20 15:41 ` [PATCH v4 15/18] perf: add PERF_RECORD_MISC_MMAP_DATA to RECORD_MMAP Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 16/18] perf tools: detect data vs. text mappings Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 17/18] perf tools: Ignore ABS symbols when loading data maps Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 18/18] perf tools: Fix output of symbol_daddr offset Stephane Eranian
2012-12-20 16:05 ` [PATCH v4 00/18] perf: add memory access sampling support Jiri Olsa
2012-12-20 16:07 ` Stephane Eranian
2012-12-20 16:12 ` Jiri Olsa
2012-12-20 16:44 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130106064354.GK29714@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox