public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@elte.hu, ak@linux.intel.com, acme@redhat.com,
	namhyung.kim@lge.com
Subject: Re: [PATCH v4 08/18] perf/x86: add memory profiling via PEBS Load Latency
Date: Sat, 5 Jan 2013 19:43:29 +0100	[thread overview]
Message-ID: <20130105184329.GB995@krava.brq.redhat.com> (raw)
In-Reply-To: <1356018108-6081-9-git-send-email-eranian@google.com>

On Thu, Dec 20, 2012 at 04:41:38PM +0100, Stephane Eranian wrote:
> This patch adds support for memory profiling using the
> PEBS Load Latency facility.
> 
> Load accesses are sampled by HW and the instruction
> address, data address, load latency, data source, tlb,
> locked information can be saved in the sampling buffer
> if using the PERF_SAMPLE_COST (for latency),

PERF_SAMPLE_WEIGHT ?

> PERF_SAMPLE_ADDR, PERF_SAMPLE_DSRC types.
> 
> To enable PEBS Load Latency, users have to use the
> model specific event:
> - on NHM/WSM: MEM_INST_RETIRED:LATENCY_ABOVE_THRESHOLD
> - on SNB/IVB: MEM_TRANS_RETIRED:LATENCY_ABOVE_THRESHOLD
> 
> To make things easier, this patch also exports a generic
> alias via sysfs: mem-loads. It export the right event
> encoding based on the host CPU and can be used directly
> by the perf tool.
> 
> Loosely based on Intel's Lin Ming patch posted on LKML
> in July 2011.
> 
> Signed-off-by: Stephane Eranian <eranian@google.com>

SNIP

> +/*
> + * Map PEBS Load Latency Data Source encodings to generic
> + * memory data source information
> + */
> +#define P(a, b) PERF_MEM_S(a, b)
> +#define OP_LH (P(OP, LOAD) | P(LVL, HIT))
> +#define SNOOP_NONE_MISS (P(SNOOP, NONE) | P(SNOOP, MISS))
> +

I checked Intel SDM 'Table 18-13. Data Source Encoding for Load Latency Record'
and it seems to be different (below) at some points.. did you use another source?

> +static const u64 pebs_data_source[] = {
> +	P(OP, LOAD) | P(LVL, MISS) | P(LVL, L3) | P(SNOOP, NA),/* 0x00:ukn L3 */
> +	OP_LH | P(LVL, L1) | P(SNOOP, NONE),	/* 0x01: L1 local */
> +	OP_LH | P(LVL, LFB)| P(SNOOP, NONE),	/* 0x02: LFB hit */
> +	OP_LH | P(LVL, L2) | P(SNOOP, NONE),	/* 0x03: L2 hit */
> +	OP_LH | P(LVL, L3) | P(SNOOP, NONE),	/* 0x04: L3 hit */
> +	OP_LH | P(LVL, L3) | P(SNOOP, MISS),	/* 0x05: L3 hit, snoop miss */
> +	OP_LH | P(LVL, L3) | P(SNOOP, HIT),	/* 0x06: L3 hit, snoop hit */

0x6:
L3 HIT. Local or Remote home requests that hit the L3 cache and was serviced by
another processor core with a cross core snoop where modified copies were found.
(HITM).


> +	OP_LH | P(LVL, L3) | P(SNOOP, HITM),	/* 0x07: L3 hit, snoop hitm */

0x7:
Reserved

> +	OP_LH | P(LVL, REM_CCE1) | P(SNOOP, HIT),  /* 0x08: L3 miss snoop hit */
> +	OP_LH | P(LVL, REM_CCE1) | P(SNOOP, HITM), /* 0x09: L3 miss snoop hitm*/

0x9:
Reserved

> +	OP_LH | P(LVL, LOC_RAM)  | P(SNOOP, HIT),  /* 0x0a: L3 miss, shared */
> +	OP_LH | P(LVL, REM_RAM1) | P(SNOOP, HIT),  /* 0x0b: L3 miss, shared */
> +	OP_LH | P(LVL, LOC_RAM)  | SNOOP_NONE_MISS,/* 0x0c: L3 miss, excl */
> +	OP_LH | P(LVL, REM_RAM1) | SNOOP_NONE_MISS,/* 0x0d: L3 miss, excl */
> +	OP_LH | P(LVL, IO) | P(SNOOP, NONE), /* 0x0e: I/O */
> +	OP_LH | P(LVL,UNC) | P(SNOOP, NONE), /* 0x0f: uncached */
> +};

thanks,
jirka

  reply	other threads:[~2013-01-05 18:43 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20 15:41 [PATCH v4 00/18] perf: add memory access sampling support Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 01/18] perf, x86: Support CPU specific sysfs events Stephane Eranian
2013-01-02 14:04   ` Jiri Olsa
2013-01-02 17:07     ` Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 02/18] perf/x86: improve sysfs event mapping with event string Stephane Eranian
2013-01-02 14:05   ` Jiri Olsa
2012-12-20 15:41 ` [PATCH v4 03/18] perf/x86: add flags to event constraints Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 04/18] perf, core: Add a concept of a weightened sample Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 05/18] perf: add minimal support for PERF_SAMPLE_WEIGHT Stephane Eranian
2013-01-02 14:07   ` Jiri Olsa
2013-01-07 13:10     ` Stephane Eranian
2013-01-07 13:27       ` Jiri Olsa
2013-01-07 14:03         ` Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 06/18] perf: add support for PERF_SAMPLE_ADDR in dump_sampple() Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 07/18] perf: add generic memory sampling interface Stephane Eranian
2013-01-05 18:38   ` Jiri Olsa
2013-01-05 19:05   ` Jiri Olsa
2013-01-06  6:43     ` Andi Kleen
2012-12-20 15:41 ` [PATCH v4 08/18] perf/x86: add memory profiling via PEBS Load Latency Stephane Eranian
2013-01-05 18:43   ` Jiri Olsa [this message]
2013-01-06 20:37     ` Stephane Eranian
2013-01-07 10:11       ` Jiri Olsa
2013-01-07 12:34         ` Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 09/18] perf/x86: export PEBS load latency threshold register to sysfs Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 10/18] perf/x86: add support for PEBS Precise Store Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 11/18] perf tools: add mem access sampling core support Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 12/18] perf report: add support for mem access profiling Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 13/18] perf record: " Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 14/18] perf tools: add new mem command for memory " Stephane Eranian
2013-01-02 14:16   ` Jiri Olsa
2013-01-07 13:04     ` Stephane Eranian
2013-01-07 13:08       ` Jiri Olsa
2012-12-20 15:41 ` [PATCH v4 15/18] perf: add PERF_RECORD_MISC_MMAP_DATA to RECORD_MMAP Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 16/18] perf tools: detect data vs. text mappings Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 17/18] perf tools: Ignore ABS symbols when loading data maps Stephane Eranian
2012-12-20 15:41 ` [PATCH v4 18/18] perf tools: Fix output of symbol_daddr offset Stephane Eranian
2012-12-20 16:05 ` [PATCH v4 00/18] perf: add memory access sampling support Jiri Olsa
2012-12-20 16:07   ` Stephane Eranian
2012-12-20 16:12     ` Jiri Olsa
2012-12-20 16:44       ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130105184329.GB995@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung.kim@lge.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox