From: Ian Kent <raven@themaw.net>
To: NeilBrown <neilb@suse.de>
Cc: autofs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] autofs4: remove a redundant assignment
Date: Wed, 16 Jul 2014 11:27:12 +0800 [thread overview]
Message-ID: <1405481232.2527.12.camel@perseus.fritz.box> (raw)
In-Reply-To: <20140709234114.4525.3341.stgit@notabene.brown>
On Thu, 2014-07-10 at 09:41 +1000, NeilBrown wrote:
> The variable 'ino' already exists and already
> has the correct value. The d_fsdata of a dentry
> is never changed after the d_fsdata is instantiated,
> so this new assignment cannot be necessary.
>
> It was introduced in
> commit b5b801779d59165c4ecf1009009109545bd1f642
> autofs4: Add d_manage() dentry operation
>
> Signed-off-by: NeilBrown <neilb@suse.de>
Again, an obvious cleanup, thanks for that.
Acked-by: Ian Kent <raven@themaw.net>
> ---
> fs/autofs4/expire.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/autofs4/expire.c b/fs/autofs4/expire.c
> index 394e90b02c5e..a7be57e39be7 100644
> --- a/fs/autofs4/expire.c
> +++ b/fs/autofs4/expire.c
> @@ -333,7 +333,6 @@ struct dentry *autofs4_expire_direct(struct super_block *sb,
> if (ino->flags & AUTOFS_INF_PENDING)
> goto out;
> if (!autofs4_direct_busy(mnt, root, timeout, do_now)) {
> - struct autofs_info *ino = autofs4_dentry_ino(root);
> ino->flags |= AUTOFS_INF_EXPIRING;
> init_completion(&ino->expire_complete);
> spin_unlock(&sbi->fs_lock);
>
>
next prev parent reply other threads:[~2014-07-16 3:33 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 23:41 [PATCH 0/6] autofs4: support RCU-walk NeilBrown
2014-07-09 23:41 ` [PATCH 1/6] autofs4: remove unused autofs4_ispending() NeilBrown
2014-07-16 3:26 ` Ian Kent
2014-07-09 23:41 ` [PATCH 4/6] autofs4: factor should_expire() out of autofs4_expire_indirect NeilBrown
2014-07-14 0:53 ` [PATCH 4/6 v2] " NeilBrown
2014-07-15 3:48 ` Ian Kent
2014-07-15 4:05 ` NeilBrown
2014-07-15 7:44 ` Ian Kent
2014-07-16 7:50 ` Ian Kent
2014-07-17 4:34 ` NeilBrown
2014-07-09 23:41 ` [PATCH 5/6] autofs4: avoid taking fs_lock during rcu-walk NeilBrown
2014-07-16 9:52 ` Ian Kent
2014-07-09 23:41 ` [PATCH 2/6] autofs4: remove a redundant assignment NeilBrown
2014-07-16 3:27 ` Ian Kent [this message]
2014-07-09 23:41 ` [PATCH 6/6] autofs4: don't take spinlock when not needed in autofs4_lookup_expiring NeilBrown
2014-07-16 3:42 ` Ian Kent
2014-07-16 6:10 ` NeilBrown
2014-07-09 23:41 ` [PATCH 3/6] autofs4: allow RCU-walk to walk through autofs4 NeilBrown
2014-07-16 4:44 ` Ian Kent
2014-07-16 5:51 ` NeilBrown
2014-07-16 6:56 ` Ian Kent
2014-07-17 5:00 ` Ian Kent
2014-07-17 8:04 ` NeilBrown
2014-07-17 10:17 ` Ian Kent
2014-07-29 1:51 ` NeilBrown
2014-07-29 6:37 ` Ian Kent
2014-07-10 7:43 ` [PATCH 0/6] autofs4: support RCU-walk Ian Kent
2014-07-10 7:45 ` Ian Kent
2014-07-10 8:25 ` NeilBrown
2014-07-11 2:49 ` Ian Kent
2014-07-16 3:24 ` Ian Kent
2014-07-16 6:00 ` NeilBrown
2014-07-16 7:21 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405481232.2527.12.camel@perseus.fritz.box \
--to=raven@themaw.net \
--cc=autofs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox