From: Ian Kent <raven@themaw.net>
To: NeilBrown <neilb@suse.de>
Cc: autofs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] autofs4: allow RCU-walk to walk through autofs4.
Date: Thu, 17 Jul 2014 13:00:56 +0800 [thread overview]
Message-ID: <1405573256.3002.25.camel@perseus.fritz.box> (raw)
In-Reply-To: <1405493777.2527.72.camel@perseus.fritz.box>
On Wed, 2014-07-16 at 14:56 +0800, Ian Kent wrote:
> > That looks a bit messy ... I wonder if we could have a new "ino" flag which
> > says "This dentry is mounted-on if it needs to be. Gets set by ->lookup
> > and cleared by ->d_automount or when ->d_manage returns -EISDIR.
>
> At one point DCACHE_NEED_AUTOMOUNT and DCACHE_MANAGE_TRANSIT were
> handled separately and DCACHE_NEED_AUTOMOUNT was cleared for rootless
> multi-mount dentrys following a mount and set again at expire. Not
> having to worry about managing that flag was also part of the
> optimization.
>
> We could go back to managing DCACHE_NEED_AUTOMOUNT or add a new flag.
> I'm not fussy how it's done as long as it works. IIRC there was one
> quite convoluted if check (in the expire code) that was removed due to
> the optimization.
Umm ... using DCACHE_NEED_AUTOMOUNT rather than a new flag means using
an additional lock so perhaps a new flag would be preferred since
reducing lock overhead was the point of this.
Just a thought
Ian
next prev parent reply other threads:[~2014-07-17 5:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 23:41 [PATCH 0/6] autofs4: support RCU-walk NeilBrown
2014-07-09 23:41 ` [PATCH 1/6] autofs4: remove unused autofs4_ispending() NeilBrown
2014-07-16 3:26 ` Ian Kent
2014-07-09 23:41 ` [PATCH 4/6] autofs4: factor should_expire() out of autofs4_expire_indirect NeilBrown
2014-07-14 0:53 ` [PATCH 4/6 v2] " NeilBrown
2014-07-15 3:48 ` Ian Kent
2014-07-15 4:05 ` NeilBrown
2014-07-15 7:44 ` Ian Kent
2014-07-16 7:50 ` Ian Kent
2014-07-17 4:34 ` NeilBrown
2014-07-09 23:41 ` [PATCH 5/6] autofs4: avoid taking fs_lock during rcu-walk NeilBrown
2014-07-16 9:52 ` Ian Kent
2014-07-09 23:41 ` [PATCH 2/6] autofs4: remove a redundant assignment NeilBrown
2014-07-16 3:27 ` Ian Kent
2014-07-09 23:41 ` [PATCH 6/6] autofs4: don't take spinlock when not needed in autofs4_lookup_expiring NeilBrown
2014-07-16 3:42 ` Ian Kent
2014-07-16 6:10 ` NeilBrown
2014-07-09 23:41 ` [PATCH 3/6] autofs4: allow RCU-walk to walk through autofs4 NeilBrown
2014-07-16 4:44 ` Ian Kent
2014-07-16 5:51 ` NeilBrown
2014-07-16 6:56 ` Ian Kent
2014-07-17 5:00 ` Ian Kent [this message]
2014-07-17 8:04 ` NeilBrown
2014-07-17 10:17 ` Ian Kent
2014-07-29 1:51 ` NeilBrown
2014-07-29 6:37 ` Ian Kent
2014-07-10 7:43 ` [PATCH 0/6] autofs4: support RCU-walk Ian Kent
2014-07-10 7:45 ` Ian Kent
2014-07-10 8:25 ` NeilBrown
2014-07-11 2:49 ` Ian Kent
2014-07-16 3:24 ` Ian Kent
2014-07-16 6:00 ` NeilBrown
2014-07-16 7:21 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405573256.3002.25.camel@perseus.fritz.box \
--to=raven@themaw.net \
--cc=autofs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox