From: Masami Hiramatsu <mhiramat@kernel.org>
To: linux-kselftest@vger.kernel.org, shuah@kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Cc: mhiramat@kernel.org, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org
Subject: [PATCH v3 1/5] selftests: ftrace: Do not failure if there is unsupported tests
Date: Thu, 6 Jul 2017 18:07:41 +0900 [thread overview]
Message-ID: <149933205136.8910.7889612343393464587.stgit@devbox> (raw)
In-Reply-To: <149933198569.8910.14570277134817357038.stgit@devbox>
Do not return failure exit code (1) for unsupported testcases,
since it is expected for stable kernels.
Previously, ftracetest is expected to run only on current
release for avoiding regressions. However, nowadays we run
it on stable kernels. This means some test cases must return
unsupported result. In such case, we should NOT exit
ftracetest with error status for unsupported results so that
kselftest (upper tests wrapper) shows it passed correctly.
Note that we continue to treat unresolved results as failure,
if test writers would like to notice user that the test result
should be reviewed, they can use exit_unresolved.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
tools/testing/selftests/ftrace/ftracetest | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index 14a03ea..290cd42 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -187,7 +187,7 @@ eval_result() { # sigval
$UNSUPPORTED)
prlog " [UNSUPPORTED]"
UNSUPPORTED_CASES="$UNSUPPORTED_CASES $CASENO"
- return 1 # this is not a bug, but the result should be reported.
+ return 0 # this is not a bug.
;;
$XFAIL)
prlog " [XFAIL]"
next prev parent reply other threads:[~2017-07-06 9:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 9:06 [PATCH v3 0/5] selftests: ftrace: ftracetest improvements Masami Hiramatsu
2017-07-06 9:07 ` Masami Hiramatsu [this message]
2017-07-06 9:08 ` [PATCH v3 2/5] selftests: ftrace: Add --fail-unsupported option Masami Hiramatsu
2017-07-06 9:09 ` [PATCH v3 3/5] selftests: ftrace: Add more verbosity for immediate log Masami Hiramatsu
2017-07-06 9:10 ` [PATCH v3 4/5] selftests: ftrace: Output only to console with "--logdir -" Masami Hiramatsu
2017-07-06 13:50 ` Steven Rostedt
2017-07-07 0:42 ` Masami Hiramatsu
2017-07-06 9:12 ` [PATCH v3 5/5] selftests: ftrace: Check given string is not zero-length Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149933205136.8910.7889612343393464587.stgit@devbox \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=naresh.kamboju@linaro.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox